Re: [Flightgear-devel] VR Options Menu Is Not Available In Daily Build

[James H. <ja...@al...>]

On 24 August 2022 09:00:26 BST, James Turner <ja...@fl...> wrote:
>> On 23 Aug 2022, at 15:57, James Hogan via Flightgear-devel <fli...@li...> wrote:
>> 
>> Sorry about that. Does the following patch fix it for you?
>> Feels a bit wrong that you have to magically know what to include before
>> openxr_platform.h in the presence of future extensions, but the
>> xr_dependencies.h header in the openxr sdk appears to be internal to the
>> loader.
>
>This does feel a bit weird to me : I’ve never seen any code before, need to manually include unknwn.h before (I think it’s one of those things you are meant to get via a specified top-level include, not pull in yourself)
>
>So, maybe we consider this a work-around, anyway : it’s not a terrible fix, just … odd … so at least a comment stating why it’s needed?
>
>Kind regards,
>James

the openxr loader does it too when including platform headers, after having the same issue, but it feels like it should be explicit in the openxr standard or implicit in the header given its only extensions that need it (which i'm not even using). also that its specific to older versions of msvc implies its maybe unintended and already fixed in msvc headers, just needing a workaround for compat. i'll definitely raise an openxr-sdk-source issue to query that as it seems the headers should do the workaround, and add a comment.

Cheers
James Hogan