Re: [Flightgear-devel] Launcher: Multiplayer models missing, custom aircraft path and default hangar

[James T. <ja...@fl...>]

> On 15 Apr 2021, at 08:14, Benedikt Hallinger <be...@ha...> wrote:
> 
> Now, if I add the default hangar dir (/var/cache/fgfs/Aircraft/org.flightgear.fgaddon.trunk) also, it works again.
> It yields the same launcher line, except the second occurence of the --fg-aircraft parameter:
>  --fg-aircraft=/home/beni/Dokumente/FGFS/Aircraft --fg-aircraft=/var/cache/fgfs/Aircraft/org.flightgear.fgaddon.trunk/Aircraft
> The drawback of this approach is, that I see all aircraft duplicated in the launcher.
> The easy solution is to add both location parameters to the custom code area of the launcher instead.
> 
> 
> Why is that so?
> Shouldn't the launcher always include the installed hangar cache locations in the launcher line as additonal --fg-aircraft parameter?

The current design is that the launcher only specifices the active aircraft’s hangar via —aircraft-dir : we only specify additional dirs via —fg-aircraft if you manually add them.

This is to allow the same aircraft to exist in multiple hangars: we want to ensure the correct aircraft dir is found and used.

We could *additionally* add all the hangars afterwards via —fg-aircraft : this should (in theory) make zero difference to loading the user aircraft (since —aircraft-dir takes precedence) but allow them all to be searched in the provided order, for MP model loading. Before doing that, I’d want to have a bit of discussion here, if there’s any negative consequences to doing that. (I can’t think of any right now, but I only had tea so far, not coffee…)

Kind regards,
James