Re: [Flightgear-devel] MiG-15 patches

[Michael D. <mik...@gm...>]

On Thu, Dec 10, 2020 at 02:28:41AM +0100, Ludovic Brenta wrote:
> Michael Danilov <mik...@gm...> writes:
> > Dear MiG-15 maintainers,
> [...]
> > Despite the fact that Ludovic Brenta -- the current maintainer --
> > was quick to remind me about uploading patches to Sf for review, once
> > I had posted the link to my GitLab WIP repo (which is that -- only for
> > WIP stuff -- and I _do_ want to cooperate with upstream) just to tell
> > a user that the instruments are being worked on -- I have never heard
> > from either him or anyone else despite me having shared the link in
> > that same thread.
> >
> > I guess I'm doing something horribly wrong here. [Shrug]
> 
> Hello Michael,
> 
> You're not doing anything wrong.  As you may have noticed, I have been
> dormant on this list since then and that is because of Real Life issues.
> I have only had time to review the first 3 or 4 commits on your
> repository but not even to test them; then I reached those that touch
> the FDM, which is maintained by andreas-z and is way out of my area of
> expertise.  I was hoping, and I still hope, that the other maintainers
> can and will step in as their time permits.  I am really sorry to be
> holding you up and possibly discouraging you.
> 
> in the first commit ea6377feced7fb7310b91c3bd23fd0387d173976:
> [...]
> 
> -- 
> Ludovic Brenta.

Hello, Ludovic,

Thank you for the kind reply! I want to apolgize for the tone because
was so easy to forget that people may not reply because of being busy.

The commits that "touch the FDM" -- while technically being part of
JSBSim, they are just systems (at least mostly). ;)

There indeed may be too many patches to review at once, I will try
holding back with more big patches until review catches up.

About editing old patches after review -- how should I proceed?
a) simply add a new commit with the name like 'fixup to "commit name"'
b) squash the changes into the patches and reupload

Kind regards,
Mike