Re: [Flightgear-devel] Independent view windows

[James T. <ja...@fl...>]

> On 3 Aug 2020, at 22:34, Julian Smith <ju...@op...> wrote:
> 
> I think CompositeViewer is fundamentally risk-free, in a way that most
> significant changes to a project like Flightgear are not, because
> ultimately OSG CompositeViewer is a very simple generalisation of OSG
> Viewer - instead of a Viewer also /being/ a View, a CompositeViewer
> /has/ one or more Views. That's all there is to it.
> 
> So we've always got the basic scenario to fall back on where there is
> just a single view and things are essentially identical to a standard
> non-CompositeViewer setup.

I’m going to do a different thread about road-map and pace of development :)

About this specific feature, there’s one concern: from memory (which may be incorrect), the CompositeViewer changes the OSG multi-threading model significantly, because there are multiple contexts. And since most of our long-standing crashing bugs are around OSG multi-threading, usually in combination with some other feature (eg, particles, or reset), I am not in agreement about the ‘risk free’ nature, if it touches threading at all. But, I guess, if it’s off by default, we can find out.

I would also be happier if you could get Fernando to do a code review, to make sure you’re not touching anything which might affect the CompositOR.

And, I’ll do a code review as well, hopefully in the next few days … although that brings me back to the other thread I will write :)

Kind regards,
James