Re: [Flightgear-devel] ILS not working on some aircrafts

[James T. <ja...@fl...>]

> On 22 Apr 2020, at 17:03, Red Griffin <pro...@gm...> wrote:
> 
> For the moment, I modified the file Cessna337-set.xml and changed power-btn for nav 1 and 2 to "true".
> Interestingly, power-btn property of nav radios are the only ones set to false whereas in all the other cases (comm, adf, dme) is set to true.

This is an interesting one:

- the C337 declares it radios as defaulting to off in the -sst XML

- it has no 3D UI (or any other way) to turn them on

- in 2018.3 (and prior), the nav-radio C++ automatically sets the following properties to true *regardless of what’s in the -set XML*:

    power_btn_node->setBoolValue( true );
    ident_btn_node = node->getChild("ident", 0, true);
    ident_btn_node->setBoolValue( true );
    audio_btn_node = node->getChild("audio-btn", 0, true);
    audio_btn_node->setBoolValue( true );

In other words, ‘power-btn’, ‘ident’ and ‘audio-btn’ will always start up true, even if you set them to false in the XML / overlay / command line.

I’ve done a grep over FGaddon trunk:

10:28 $ grep -r "<power-btn type=\"bool\">false" .
./Antonov-An-12/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Antonov-An-12/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Antonov-An-12/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Antonov-An-12/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Socata-ST10/st10-base.xml:      <power-btn type="bool">false</power-btn>
./Socata-ST10/st10-base.xml:      <power-btn type="bool">false</power-btn>
./Socata-ST10/st10-base.xml:      <power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./707/Systems/instrumentation-init.xml:	<power-btn type="bool">false</power-btn>
./Beagle-Pup/pup-common.xml:      <power-btn type="bool">false</power-btn>
./Beagle-Pup/pup-common.xml:      <power-btn type="bool">false</power-btn>
./Beagle-Pup/pup-common.xml:      <power-btn type="bool">false</power-btn>
./DR400-dauphin/dr400-dauphin-set.xml:      <power-btn type="bool">false</power-btn>
./DR400-dauphin/dr400-dauphin-set.xml:      <power-btn type="bool">false</power-btn>
./DR400-dauphin/dr400-dauphin-set.xml:      <power-btn type="bool">false</power-btn>
./DR400-dauphin/dr400-dauphin-set.xml:      <power-btn type="bool">false</power-btn>
./DR400-dauphin/dr400-dauphin-set.xml:      <power-btn type="bool">false</power-btn>
./Caproni-C22J/c22j-base.xml:      <power-btn type="bool">false</power-btn>
./Caproni-C22J/c22j-base.xml:      <power-btn type="bool">false</power-btn>
./Caproni-C22J/c22j-base.xml:      <power-btn type="bool">false</power-btn>
./Tecnam-P2006T/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Tecnam-P2006T/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Tecnam-P2006T/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Velocity-XL/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Velocity-XL/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Velocity-XL/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Yak-52/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Yak-52/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Yak-52/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./DR400/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./DR400/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./DR400/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Cessna337/Cessna337-set.xml:		<power-btn type="bool">false</power-btn>
./Cessna337/Cessna337-set.xml:		<power-btn type="bool">false</power-btn>
./Piaggio-P166/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Piaggio-P166/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Piaggio-P166/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Piaggio-P166/Systems/instrumentation2.xml:    <power-btn type="bool">false</power-btn>
./Cessna-421-Golden-Eagle/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Cessna-421-Golden-Eagle/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./Cessna-421-Golden-Eagle/Systems/instrumentation.xml:    <power-btn type="bool">false</power-btn>
./JA37/Viggen-set-base.xml:            <power-btn type="bool">false</power-btn>
./c150/c150-set.xml:            <power-btn type="bool">false</power-btn>
./c150/c150-set.xml:            <power-btn type="bool">false</power-btn>


.. and so far all the aircraft I found *except* the C337 have 3D pick animations or other logic to turn the radio on. And they’re making the value be off explicitly, so they can turn the radio on as part of a startup procedure.

Therefore my preference at this point is the fix the C337 (by removing the offending lines from the -set.xml), and add this to our ‘list of things to check, when validating an aircraft for 2020.2’.

Kind regards,
James