Re: [Flightgear-devel] Moonlight

[James T. <jam...@kd...>]

> On 29 May 2017, at 12:46, Edward d'Auvergne <tru...@gm...> wrote:
> 
> I'm not sure what the earlier email is, but do you mean using
> SGPropertyNode_ptr rather than SGPropertyNode*:
> 
>    https://sourceforge.net/u/edauvergne/flightgear/ci/0cc07e456c3aec1dd0dd38d37f74cb4236ee98e2/ <https://sourceforge.net/u/edauvergne/flightgear/ci/0cc07e456c3aec1dd0dd38d37f74cb4236ee98e2/>
> 
> If so, should _latProp be converted as well?

Yes, certainly.

Every raw pointer to a property node ptr is potentially either a leaked property on reset / subsystem re-init, or an ‘uncounted’ property - depending on how bind and unbind are implemented in the subsystem. Mostly we get away with ‘not counting’ the properties because the global tree owns them, but as we move towards are more modular strucutre, there are more times that won’t be true.

Kind regards,
James