Re: [Flightgear-devel] Moonlight

[Edward d'A. <tru...@gm...>]

On 29 May 2017 at 10:00, Thorsten Renk <tho...@sc...> wrote:
>
>> I've made a merge request for a small commit simply untying the
>> /environment/moonlight property:
>>
>>
>> https://sourceforge.net/u/edauvergne/flightgear/ci/a0dc7b5ba3fdf110fe3b9716a3fd6a0a87a7a210/
>>
>> Is this the best (intermediate) solution for the ALS renderer?
>
>
> I've posted a list with a couple of items that I currently see as
> problematic. This solves one of them.

Great!  Could someone accept the merge request?  For another item, I
now have a set of reproducible testing conditions:

# Moonrise for a full moon.
fgfs --airport=KSFO --aircraft=UFO
--start-date-lat=2017:05:11:06:52:00 --altitude=1000 --heading=251
--enable-freeze

# Moonset for a full moon.
fgfs --airport=KSFO --aircraft=UFO
--start-date-lat=2017:05:11:20:59:00 --altitude=1000 --heading=111
--enable-freeze

# Moonrise for a new moon.
fgfs --airport=KSFO --aircraft=UFO
--start-date-lat=2017:05:25:06:06:00 --altitude=1000 --heading=71
--enable-freeze

# Moonset for a new moon.
fgfs --airport=KSFO --aircraft=UFO
--start-date-lat=2017:05:25:20:23:00 --altitude=1000 --heading=292
--enable-freeze


It might be a little longer until I refactor the CppUnit test suite
code I have and convert these into permanent system/functional tests.
These conditions show that something is strange with
/sim/time/moon-angle-rad.

Regards,

Edward