Re: [Flightgear-devel] Nasal error with YASim aircraft having < 4 fuel tanks

[LeeE <le...@sp...>]

On Monday 07 January 2008 18:24, LeeE wrote:
> On Monday 07 January 2008 11:07, Chris Metzler wrote:
> > On Sun, 6 Jan 2008 23:00:22 +0000
> >
> > LeeE wrote:
> > > Can anyone else confirm this problem on the OSG cvs branch?
> >
> > Yes, I see it too, and have for at least a couple of weeks.
> >
> > -c
>
> Thanks - confirms it's not just a local problem here.
>
> LeeE

Searching through Aircraft/controls.hxx gives

    enum {
	ALL_TANKS = -1,
	MAX_TANKS = 8
    };

but in Aircraft/controls.cxx there's

FGControls::set_feed_tank( int engine, int tank )
{ 
    if ( engine == ALL_ENGINES ) {
	for ( int i = 0; i < MAX_ENGINES; i++ ) {
	    feed_tank[i] = tank;
	    CLAMP( &feed_tank[i], -1, 4 );
	}
    } else {
	if ( (engine >= 0) && (engine < MAX_ENGINES) ) {
	    feed_tank[engine] = tank;
	    CLAMP( &feed_tank[engine], -1, 4 );
	}
    } 
 //   feed_tank[engine] = engine;
}

If these bits of code are relevant to the problem MAX_TANKS seems 
too low - many large aircraft will have more than 8 fuel tanks.

If I understand CLAMP syntax correctly, it's limiting the value to 
4, which ties in with the number of tank nodes that are created by 
default.

I didn't find any other occurrences of 'tank' in the FG source code 
that seemed relevant.

LeeE