Re: [Flightgear-devel] [Flightgear-cvslogs] CVS: source/src/Traffic TrafficMgr.cxx, 1.13.2.3, 1.13.2.4

[Durk T. <d.t...@xs...>]

On Friday 25 May 2007 10:37, Melchior FRANZ wrote:
> * Durk Talsma -- 5/25/2007 9:20 AM:
> > Log Message:
> > Don't fix what ain't broke.
> >
> > -   runCount = 0;
> > +   //runCount = 0
>
> I explained why I reset that counter. Could you explain why you changed
> it back?
>
> This counter wasn't my idea, but yours. It could/should have been used to
> make the traffic manager stuff not run in every frame. (Traffic does
> probably not have to be reconsidered 60 times per second, one would
> assume.) Before my change the whole counter setup was dead code, and
> now you made it dead code again. Why not remove it, if it has no
> purpose?
>

Hi Melchior,

I barely managed to get this fix into CVS before heading out to work this 
morning, making sure above all that this wouldn't get into the final release, 
as the side effects will not be favorable. So, sorry I didn't have time for a 
more elaborate explanation. ;-)

I added the counter to skip the first number of frames (more of less 
arbitrarily set to 1000) after initialization, because the AI system needs 
some time until all the right weather is loaded. If not the first AI aircraft 
may taxi to a different runway than those departing later. 

Once frame count is reaching 1000, whether is usually initialized, and from 
that point on the update code needs to run once everyframe, otherwise it's 
going to take much too long between the processing of two successive 
aircraft.

Admittedly, the skipping the first 1000 frames is rather arbitrary, and should 
probably be replaced by checking a metar related property, but that's a 
different issue. :-)

Cheers,
Durk