[Flightgear-devel] Re: Resigning as patch committer.

[Melchior F. <mf...@ao...>]

* Erik Hofman -- Tuesday 21 February 2006 13:20:
> I have finally made the decision not to commit any patches from others 
> anymore. I think I've done my time over the last few years but this 
> accident this morning alone has cost me more than half a day.

Sorry to hear that. I'm aware that you had to carry the main load
of committing patch contributions.



On the other hand, I do now feel the need to defend myself, because
it may appear as if it was my fault. It was not.

1. I didn't want to make this FSF address patch at all, but was
   encouraged. (When I explained why I wouldn't do it, I only got
   a "Bah.", as in: "weak excuse!". So I made and submitted it anyway.)

2. The patch was well tested & against a clean SG/CVS/HEAD. It is
   correct as you can see here in the originally submitted file:
   http://members.aon.at/mfranz/simgear.diff.gz  [7.8 kB]
   I tried it again right now and it applied cleanly *and* correctly,
   as did reverting it.  ($ zcat simgear.diff.gz|patch -R -p0)

3. I don't see how reverting two patches takes more than a half
   day. Actually, I'd be surprised if it took more than half an
   hour. I'd give it no more than 10 minutes. Unless, of course,
   cvs or patch has a bug that doesn't allow it.

I can't, however, imagine that Erik made a mistake. It looks very
much like a "cvs" or "patch" bug. Nothing in the patch justifies
the outcome. Not even if it had been applied wrongly (which it
hardly was -- Erik isn't a cvs beginner).

m.