Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

[Frederic B. <fre...@fr...>]

Andy Ross wrote :
> Frederic Bouvier wrote:
>   
>> Melchior FRANZ wrote:
>>     
>>> Why the #ifdef? Is there a reasonable case where CONFIG_H is *not*
>>> available?
>>>       
>> It has always been the practice to enclose #include <config.h> by
>> #ifdef HAVE_CONFIG_H from the beginning of autoconf/automake.
>>     
>
> That's not really an answer to the question: do we or will we ever do
> a build where there is no config.h?  Can such a build work even if we
> tried it?  Based on your recent checking, the answer clearly seems to
> be no.
>
> Just drop the #ifdefs.  They're needless complexity, and using them
> simply because "it's always been done that way" is bad software
> engineering.


I'd read the whole thread before extracting a single phrase from its
context.

-Fred