Re: [Firemen-game] Player and Score classes

[Thierry M. <thierry.mallard@IDEALX.com>]

On Sun, Jul 30, 2000 at 08:33:01PM +0200, Bruno Galet wrote:
>=20
> Hi there,

Hi fluxy !

Humble suggestions :

> class Player
> {
> 	char name[MAX_DIGIT];  // probably 3 digits to save the player

char* sName;

> 	char miss;             // do you remember ? 3 misses -> Gameover

int	iMissed;

> public :
> 	Player(char*, char);   // constructor

I prefer that the variable names are given in the header, even
if not technically necessary, to avoid confusion.
=09
> class Score
> {
> 	short score;           // humm...Tell me if I am right but the=20
>                                // max score is 9999 ? (in the original
>                                // version of the game).

int ?

> 	short high_score;      // the current high_score

int also

> public:
> 	Score(short,short);

see remark above

> }
>=20
> Any comments before I follow the definition of this two classes ?


We should add methods to change the Score for example.
I think you typed the variables according to console programming,=20
didn't you ? ;)


	Best regards,

		Shaman
	=09

--=20
Thierry Mallard                    | GnuPG key on pgp.ai.mit.edu
http://IDEALX.com                  | key 0xA3D021CB
http://thierry.mallard.com         |=20