Re: [fink-core] HEAD buildlocks (and maybe others?) don't handle epoch

[Daniel M. <dm...@ne...>]

On Sun, Feb 26, 2006 at 11:17:47PM -0500, Benjamin Reed wrote:
> So I found a bug in the HEAD buildlock code that might explain some of
> the weirdness we're seeing.
> 
> The stable version of squid-ssl (2.5.STABLE5) comes up as newer than the
> unstable unified splitoff squid-ssl (2.5.STABLE11), so I'm putting out a
> new version (from upstream) with the epoch set to 1.
> 
> The buildlock code doesn't handle epochs at all, though, so you end up
> with this:
> 
> ---(snip!)---
> ranger$ fink install squid-unified
> Information about 5897 packages read in 9 seconds.
> The following package will be installed or updated:
>  squid-unified
> Setting runtime build-lock...
> dpkg-deb -b
> /sw/compile.build/root-fink-buildlock-squid-unified-2.5.stable12-1
> /sw/compile.build
> dpkg-deb: building package `fink-buildlock-squid-unified-2.5.stable12-1'
> in
> `/sw/compile.build/fink-buildlock-squid-unified-2.5.stable12-1_2006.02.26-23.14.02_darwin-powerpc.deb'.
> Installing build-lock package...
> /sw/bin/dpkg-lockwait -i
> /sw/compile.build/fink-buildlock-squid-unified-2.5.stable12-1_2006.02.26-23.14.02_darwin-powerpc.deb
> Selecting previously deselected package
> fink-buildlock-squid-unified-2.5.stable12-1.
> (Reading database ... 107177 files and directories currently installed.)
> Unpacking fink-buildlock-squid-unified-2.5.stable12-1 (from
> .../fink-buildlock-squid-unified-2.5.stable12-1_2006.02.26-23.14.02_darwin-powerpc.deb)
> ...
> dpkg: dependency problems prevent configuration of
> fink-buildlock-squid-unified-2.5.stable12-1:
>  fink-buildlock-squid-unified-2.5.stable12-1 depends on squid-unified (=
> 2.5.stable12-1); however:
>   Package squid-unified is not installed.
[...]
> ---(snip!)---
> 
> Note the "fink-buildlock-squid-unified-2.5.stable12-1 depends on
> squid-unified (= 2.5.stable12-1); however:"
> 
> I tried digging through the buildlock code but it's too big for me to
> just do a quick hack to fix.  Any ideas how to go about making the
> buildlock handle %e?

In this regard, buildlock is trivial. The lockpackage dependencies are
set by:

	$depfield = &lol2pkglist($self->get_depends(1, 0));
	if (length $depfield) {
		$control .= "Depends: $depfield\n";
	}

So either there's a bug in get_depends (either its implementation or
how it is being called in this code snippet) or there's a bug in your
.info file (missing %e in the Depends line).

dan

-- 
Daniel Macks
dm...@ne...
http://www.netspace.org/~dmacks