Re: [Fink-devel] atk1 does not build on Mac OS 10.15 / Xcode 12.1

[<fi...@sn...>]

On 11/24/20 8:35 PM, Scott Hannahs via Fink-devel wrote:
> In trying to build emacs I need atk1, I have set my job numbers to 1 as suggested, but the problem is the new requirement of declaring functions?
> 
> /bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DG_DISABLE_DEPRECATED -DATK_DISABLE_DEPRECATED -DATK_COMPILATION -DAT
> K_LOCALEDIR="\"/opt/sw/share/locale\"" -I/opt/sw/include/glib-2.0 -I/opt/sw/lib/glib-2.0/include  -I/opt/sw/include -DG_DISABLE_SINGLE_INCLUDES -DATK
> _DISABLE_SINGLE_INCLUDES  -Os -Wall -MT atkhyperlink.lo -MD -MP -MF .deps/atkhyperlink.Tpo -c -o atkhyperlink.lo atkhyperlink.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DG_DISABLE_DEPRECATED -DATK_DISABLE_DEPRECATED -DATK_COMPILATION -DATK_LOCALEDIR=\"/opt/sw/shar
> e/locale\" -I/opt/sw/include/glib-2.0 -I/opt/sw/lib/glib-2.0/include -I/opt/sw/include -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_SINGLE_INCLUDES -Os
> -Wall -MT atkhyperlink.lo -MD -MP -MF .deps/atkhyperlink.Tpo -c atkhyperlink.c  -fno-common -DPIC -o .libs/atkhyperlink.o
> atkhyperlink.c:165:35: error: implicit declaration of function 'atk_hyperlink_is_selected_link' is invalid in C99 [-Werror,-Wimplicit-function-declar
> ation]
>        g_value_set_boolean (value, atk_hyperlink_is_selected_link (link));
>                                    ^
> atkhyperlink.c:165:35: note: did you mean 'atk_hyperlink_is_inline'?
> ./atkhyperlink.h:97:18: note: 'atk_hyperlink_is_inline' declared here
> gboolean         atk_hyperlink_is_inline             (AtkHyperlink     *link_);
>                   ^
> 1 error generated.
> make[3]: *** [atkhyperlink.lo] Error 1
> make[2]: *** [all] Error 2
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> ### execution of /tmp/fink.96ti5 failed, exit code 2
> ### execution of /tmp/fink.iTxXR failed, exit code 2
> Removing runtime build-lock...
> Attaching full output.  But that function is defined in atkhyperlink.h.  However it enclosed in a conditional for “ATK_DISABLE_DEPRECATED”.  I think this is set in the Makefile but I don’t see it in the configure files.  Is it set manually to remove a deprecated function but is still referencing that function in the code??

Thanks for the tracking. ATK_DISABLE_DEPRECATED is defined 
unconditionally in atk/Makefile.am, so it's not from a hidden configure 
failure. This does look like they deprecated the function declaration in 
atkhyperlink.h, but forgot to deprecate it as well in atkhyperlink.c.

On 10.13, I also get the implicit declaration issue but as a warning (as 
expected). Either removing the ATK_DISABLE_DEPRECATED guard in 
atkhyperlink.h or adding it to atkhyperlink.c fixes the implicit 
declaration issue. CC'ing gnome owner.

Hanspeter

-- 
Science is like sex: sure, it may give some practical results, but
that's not why we do it.
   --Richard Feynman