[Fink-devel] A few things to fix in basket4-mac

[Alexander H. <ale...@gm...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I didn't catch these before I added the package to Fink.

1)  The library links to x11:

$ otool -L /sw32/opt/kde4/mac/lib/libbasketcommon.4.dylib
/sw32/opt/kde4/mac/lib/libbasketcommon.4.dylib:
	/sw32/opt/kde4/mac/lib/libbasketcommon.4.dylib (compatibility version
4.0.0, current version 4.4.0)
	/sw32/opt/kde4/mac/lib/libkde3support.4.dylib (compatibility version
4.0.0, current version 4.4.0)
	/sw32/opt/kde4/mac/lib/libkio.5.dylib (compatibility version 5.0.0,
current version 5.4.0)
	/sw32/opt/kde4/mac/lib/libkdeui.5.dylib (compatibility version 5.0.0,
current version 5.4.0)
	/sw32/opt/kde4/mac/lib/libkparts.4.dylib (compatibility version 4.0.0,
current version 4.4.0)
	/sw32/opt/kde4/mac/lib/libkfile.4.dylib (compatibility version 4.0.0,
current version 4.4.0)
	/sw32/lib/qt4-mac/lib/phonon.framework/Versions/4/phonon (compatibility
version 4.3.0, current version 4.3.80)
	/sw32/opt/kde4/mac/lib/libqimageblitz.4.dylib (compatibility version
4.0.0, current version 4.0.0)
	/usr/X11/lib/libSM.6.dylib (compatibility version 7.0.0, current
version 7.0.0)
	/usr/X11/lib/libICE.6.dylib (compatibility version 10.0.0, current
version 10.0.0)
	/usr/X11/lib/libX11.6.dylib (compatibility version 9.0.0, current
version 9.0.0)
	/usr/X11/lib/libXext.6.dylib (compatibility version 11.0.0, current
version 11.0.0)
	/sw32/lib/libgpgme.11.dylib (compatibility version 18.0.0, current
version 18.6.0)
	/sw32/lib/libgpg-error.0.dylib (compatibility version 5.0.0, current
version 5.0.0)
	/sw32/lib/qt4-mac/lib/QtNetwork.framework/Versions/4/QtNetwork
(compatibility version 4.6.0, current version 4.6.3)
	/sw32/lib/qt4-mac/lib/QtXml.framework/Versions/4/QtXml (compatibility
version 4.6.0, current version 4.6.3)
	/sw32/lib/qt4-mac/lib/QtSvg.framework/Versions/4/QtSvg (compatibility
version 4.6.0, current version 4.6.3)
	/sw32/opt/kde4/mac/lib/libsolid.4.dylib (compatibility version 4.0.0,
current version 4.4.0)
	/sw32/opt/kde4/mac/lib/libkdecore.5.dylib (compatibility version 5.0.0,
current version 5.4.0)
	/sw32/lib/qt4-mac/lib/QtDBus.framework/Versions/4/QtDBus (compatibility
version 4.6.0, current version 4.6.3)
	/System/Library/Frameworks/Carbon.framework/Versions/A/Carbon
(compatibility version 2.0.0, current version 152.0.0)
	/sw32/lib/qt4-mac/lib/QtCore.framework/Versions/4/QtCore (compatibility
version 4.6.0, current version 4.6.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
version 125.2.1)
	/sw32/lib/qt4-mac/lib/QtGui.framework/Versions/4/QtGui (compatibility
version 4.6.0, current version 4.6.3)
	/sw32/lib/qt4-mac/lib/Qt3Support.framework/Versions/4/Qt3Support
(compatibility version 4.6.0, current version 4.6.3)
	/sw32/opt/kde4/mac/lib/libkpty.4.dylib (compatibility version 4.0.0,
current version 4.4.0)
	/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current
version 7.9.0)

I'd recommend patching out the items that reference X11 in the top-level
CMakeLists.txt file.  It's pretty common to have to do this kind of
thing with cmake-based packages.

2) You need actually to expand the docbook files into usable documents
(and manpages, perhaps).  That appears also to be governed by the
top-level CMakeLists.txt file, since the "doc" item is commented out.
It looks like you get a "doc-handbook" target in the Makefile if you
activate that.

3) The DocFiles: field needs to be specified more explicitly (i.e. not
just 'doc/*'), because you are installing a couple of CMakeLists.txt
files, which users don't need.

...
/sw32/share/doc/basket4-mac/CMakeLists.txt
/sw32/share/doc/basket4-mac/INSTALL
/sw32/share/doc/basket4-mac/README
/sw32/share/doc/basket4-mac/TODO
/sw32/share/doc/basket4-mac/en
/sw32/share/doc/basket4-mac/en/CMakeLists.txt
...


- -- 
Alexander Hansen, Ph.D.
Fink User Liaison
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAk1pQ5wACgkQB8UpO3rKjQ+T9gCgkMj4I9o1fW6rzF5L51JVL1Ej
RAAAl2Yj3l2kdciHEPjLKTcQzMs0Pnk=
=Dd0f
-----END PGP SIGNATURE-----