Menu

#688 Debugging labels not loading correctly on open

Win32
closed:fixed
None
5
2015-01-28
2015-01-25
rainwarrior
No

When the debugger is first opened, it appears to read the symbol files, and applies symbolic names in the disassembly next to instructions, but line labels don't appear until I click the "reload symbols" button.

Not sure when this changed, looking at 3094, was working in 2.2.2 release.

1 Attachments

Discussion

  • rainwarrior

    rainwarrior - 2015-01-25

    src/drivers/win/debuggersp.cpp line 48:
    int pageNumbersLoaded[32]; //TODO - need to initialize these to -1 somehow

    I tried a 32 entry initalizer list of -1,-1,-1... but this alone isn't a complete fix (when you switch ROMs, it needs to be re-initialized, for example).

    I tried this, which seemed to work a little better:

    src/drivers/win/debugger.cpp replacing line 397:
    ramBankNamesLoaded = false;
    for(int i=0;i<ARRAYSIZE(pageNumbersLoaded);i++)
    pageNumbersLoaded[i] = -1;
    loadNameFiles();

    I'm not entirely sure this is the correct place, but it seems that we need to (re)initialize pageNumbersLoaded, and probably also ramBankNamesLoaded in one or more places.

     
  • rainwarrior

    rainwarrior - 2015-01-28

    The initializer list seems good enough; older versions of FCEUX don't appear to reload symbols across ROM change anyway. Might not be important.

     
  • rainwarrior

    rainwarrior - 2015-01-28
    • status: open --> closed:fixed
    • assigned_to: rainwarrior
     

Log in to post a comment.