#1 CPrinter::IsHomed() has undefined control path

[David Hoelscher]

Note: very low severity, just comes up as a warning on compile, and current setup may not allow bug to surface during runtime...

In Printer.cpp:

bool CPrinter::IsHomed()
{
if(bEmulateHardware)
return m_bHomed;
if(!bEmulateHardware && bHardwareInitialized)
return (m_bHomed && m_stateFlags.HOMED);
}

Code could have no defined return value if bEmulateHardware == false and bHardwareInitialized == false

Recommended fix:
if(bEmulateHardware)
return m_bHomed;
else if(bHardwareInitialized)
return (m_bHomed && m_stateFlags.HOMED);
else
{
CString msg;
msg.Format("Hardware and/or emulation must be initialized");
AfxMessageBox(msg, MB_OK);
}