Re: [Emutos-devel] Re: Nasty boot sector programs

[Laurent V. <lv...@cl...>]

Thomas Huth a écrit:
> 
> > Thomas wrote:
> >
> >>What do you think about this solution? Is it okay to use
> >>inline-assembler in the C source code or is this a bad style?
> >
> > I don't like it very much. Up to now gcc-isms are limited to
> > header files and even pseudo-functions like SetSR() could
> > be implemented as external functions if we want to compile
> > EmuTOS with another compiler. Unless there is a clear agreement
> > on the fact that EmuTOS should ONLY be compiled using gcc,
> > I would prefer to avoid asm in .c files, and to design
> > assembler in .h files in such a way that they can be
> > replaced by real assembler functions.
> 
> Okay, so do you agree if I add a regsafe_call() function to include/asm.h and
> use it in floppy.c?

yeah, sure. in asm.h or in some .S file, doesn't matter.

> BTW: What about always adding -fomit-frame-pointer to the Makefile? I think
> this is a good optimization flag, isn't it?

I dunno. never checked, but if it works no problem.

Laurent.