Re: [Emutos-devel] Avoid GCC 6 warning in bug.c

[Thomas H. <th...@po...>]

Am Wed, 21 Jun 2017 00:22:14 +0200
schrieb Thorsten Otto <ad...@th...>:

> On Mittwoch, 21. Juni 2017 00:08:30 CEST Roger Burrows wrote:
> > I'm not using GCC 6 yet on the host, but I don't suppose we have a
> > particular policy on that.  
> 
> I didn't either until some days ago, when i had to replace my whole
> system due to hardware failures. 
> 
> >How/why does moving a comment fix that?  
> 
> The comment is /* fallthrough */, which will suppress the warning.
> But it is inside an #ifdef and therefore not recognized. Thats all.

Well, but the code that it refers to is also within the #ifdef, and the
code before the #ifdef has a "break;" - so moving the comment outside
of the #ifdef sounds wrong to me, too. I think this is a GCC bug and
you should report this to the GCC folks instead.

Concerning EmuTOS: I'd like to suggest to remove the "-W" (aka
"-Wextra") from NATIVECC. In my experience, -Wextra is often causing
bogus or even clearly wrong warnings and you're then forced to add work
arounds to the code without a real need. -Wextra is OK for testing your
code occasionally (by adding it only locally to your Makefile), but
IMHO it should really not be enabled by default. So if nobody objects,
I'm going to remove that flag...

 Thomas