From: SourceForge.net <no...@so...> - 2008-09-22 06:38:02
|
Feature Requests item #2117781, was opened at 2008-09-18 14:26 Message generated for change (Comment added) made by eraonel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=460300&aid=2117781&group_id=50595 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: clearcase Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mikael Petterson (eraonel) Assigned to: Nobody/Anonymous (nobody) Summary: Remove antlr Initial Comment: We have been using antlr to handle the output from cleartool. However I find the number of shortcomnings with it: - Learning cureve is steep. - Person that implemented it no longer active in project. - Debug with anlrworks is not working. An alternative approach is to use only pure java code. It is easy to understand and test. My suggestion is to use the Composite pattern. I have attached a zip file with an example. The suggestion is to replace the current parseOutput in ClearCaseCLIImpl with a new method called parseCCOutput(final String [] output). There will be a class for each output to handle. The parseCCOutput will return a ClearCaseElementState. If there is an error then we will throw an ClearCaseException. Same as before. For each output that we handle we must implement a junit test case that proves that it works. I will add a list output that we need to handle at the momemnt to make sure that we don't break any functionality. //mike ---------------------------------------------------------------------- >Comment By: Mikael Petterson (eraonel) Date: 2008-09-22 08:37 Message: Fixed: checkin //mike ---------------------------------------------------------------------- Comment By: Mikael Petterson (eraonel) Date: 2008-09-19 07:09 Message: Here is a short description for implementation. //mike File Added: redesign1.txt ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=460300&aid=2117781&group_id=50595 |