Menu
▾
▴
Re: [Eciadsl-users] eciadsl-usermode-0.12 patch: use sysconf(_SC_PAGESIZE) instead of (PAGE_SIZE) from asm/page.h
|
From: FlashCode <fla...@fl...> - 2008-07-29 09:39:44
|
On Tue, Apr 01, 2008 at 11:30:14AM +0800, Hetfield wrote: > ACK for me. > > 2008/3/31, Kirill Maslinsky <ki...@al...>: > > > > Hi all! > > > > I'm packaging eciadsl-usermode for the ALT Linux Sisyphus and > > eventually package rebuild failed due to call to asm/page.h constant > > PAGE_SIZE. Developers at devel@altlinux recommended to replace it with > > call > > to sysconf(_SC_PAGESIZE) to avoid other potential problems: > > > > Reasons to avoid use of PAGE_SIZE are as follows: > > - It's not easily portable between different kernel versions > > and different distributions. E.g. in kernels >= 2.6.25 > > asm/page.h is not exported into userspace. > > - Value of this constant may differ from the actual value > > of page size in the running kernel. > > - Actual value of page size is correctly returned by > > sysconf(_SC_PAGESIZE). > > > > So attached is a draft patch aimed to highlight (and roughly fix) the > > problem > > (however you may wish to optimize number of calls to sysconf(_SC_PAGESIZE) > > there). > > > > With hope it will be useful, :) > > -- > > Kirill Maslinsky > > ALT Linux Team > > > > ------------------------------------------------------------------------- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > > > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > > _______________________________________________ > > Eciadsl-users mailing list > > Eci...@li... > > https://lists.sourceforge.net/lists/listinfo/eciadsl-users > > > > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > _______________________________________________ > Eciadsl-users mailing list > Eci...@li... > https://lists.sourceforge.net/lists/listinfo/eciadsl-users Commited to CVS, I used getpagesize(). -- Cordialement / Best regards Sebastien. Web: http://www.flashtux.org - email: fla...@fl... IRC: FlashCode on irc.freenode.net |