Re: [E1000-devel] 6.2.15 changes affect IPMI

[Al C. <ch...@ll...>]

Hey Jesse,

This is RHEL4 update 4.  The src.rpm can be found here

ftp://ftp.redhat.com/pub/redhat/linux/updates/enterprise/4WS/en/os/SRPMS/kernel-2.6.9-42.0.3.EL.src.rpm

I actually filed through the internal bugzilla at Redhat.  I'll make a
public one too. 

Thanks,
Al

On Wed, 2006-10-18 at 14:19 -0700, Brandeburg, Jesse wrote:
> Al Chu wrote:
> > Hi Jesse,
> > 
> > Is this all that needs to be done??
> > 
> > --- e1000_main.c.orig   2006-10-18 13:09:07.859552000 -0700
> > +++ e1000_main.c        2006-10-18 13:05:32.786046000 -0700
> > @@ -1588,8 +1588,11 @@ e1000_setup_rctl(struct e1000_adapter *a
> >                 E1000_RCTL_LBM_NO | E1000_RCTL_RDMTS_HALF |
> >                 (adapter->hw.mc_filter_type << E1000_RCTL_MO_SHIFT);
> > 
> > -       if (adapter->hw.mac_type > e1000_82543)
> > -               rctl |= E1000_RCTL_SECRC;
> > +        /* FIXME: disable the stripping of CRC because it breaks
> > +         * BMC firmware connected over SMBUS
> > +        if (adapter->hw.mac_type > e1000_82543)
> > +                rctl |= E1000_RCTL_SECRC;
> > +        */
> > 
> >         if (adapter->hw.tbi_compatibility_on == 1)
> >                 rctl |= E1000_RCTL_SBP;
> > @@ -1650,7 +1653,9 @@ e1000_setup_rctl(struct e1000_adapter *a
> >                 rfctl |= E1000_RFCTL_IPV6_DIS;
> >                 E1000_WRITE_REG(&adapter->hw, RFCTL, rfctl);
> > 
> > -               rctl |= E1000_RCTL_DTYP_PS | E1000_RCTL_SECRC;
> > +                /* FIXME: disable the stripping of CRC because it
> > breaks
> > +                 * BMC firmware connected over SMBUS */
> > +                rctl |= E1000_RCTL_DTYP_PS /* | E1000_RCTL_SECRC */;
> > 
> >                 psrctl |= adapter->rx_ps_bsize0 >>
> >                         E1000_PSRCTL_BSIZE0_SHIFT;
> > 
> > If so, no need for a patch.
> 
> This will fix the immediate problem but there is also a slight bit more
> with removing the CRC now for each received packet.  If you aren't
> running fancy network configs like VPN, or bridging, bonding, etc,
> things should be okay like this.
> 
> What kernel exactly shall I patch against?  even better what was the
> bugzilla and I will put my patch in it.
> 
-- 
Albert Chu
ch...@ll...
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory