Re: [E1000-devel] X710-T4L: 5Gb support for IEEE1588

[Fujinaka, T. <tod...@in...>]

I would recommend posting the patch to int...@os...

Todd Fujinaka
Software Application Engineer
Data Center Group
Intel Corporation
tod...@in...

-----Original Message-----
From: Alex Sergeev <ase...@ca...> 
Sent: Friday, April 30, 2021 11:12 PM
To: e10...@li...
Subject: [E1000-devel] X710-T4L: 5Gb support for IEEE1588

Hello,

We have tried to use PTP with X710-T4L and 5Gb link, and encountered clockcheck problem in phc2sys:

Apr 30 22:57:36 budtb phc2sys[5940]: [50.569] clockcheck: clock jumped forward or running faster than expected!

After further code examination, it turned out that 5Gb case is not handled in i40e_ptp.c

Here's the naive version of the patch that fixed the problem for us:

--- a/src/i40e_ptp.c 2021-02-23 07:02:32.900071129 -0800
+++ b/src/i40e_ptp.c 2021-04-30 22:58:15.365811522 -0700
@@ -18,12 +18,13 @@
  *
  * Much like the 82599, the update period is dependent upon the link speed:
  * At 40Gb link or no link, the period is 1.6ns.
- * At 10Gb link, the period is multiplied by 2. (3.2ns)
+ * At 5Gb or 10Gb link, the period is multiplied by 2. (3.2ns)
  * At 1Gb link, the period is multiplied by 20. (32ns)
  * 1588 functionality is not supported at 100Mbps.
  */
 #define I40E_PTP_40GB_INCVAL 0x0199999999ULL  #define I40E_PTP_10GB_INCVAL_MULT 2
+#define I40E_PTP_5GB_INCVAL_MULT 2
 #define I40E_PTP_1GB_INCVAL_MULT 20
 #define I40E_ISGN 0x80000000

@@ -935,6 +936,9 @@
  case I40E_LINK_SPEED_10GB:
      mult = I40E_PTP_10GB_INCVAL_MULT;
      break;
+ case I40E_LINK_SPEED_5GB:
+     mult = I40E_PTP_5GB_INCVAL_MULT;
+     break;
  case I40E_LINK_SPEED_1GB:
      mult = I40E_PTP_1GB_INCVAL_MULT;
      break;

What's the process to get it applied upstream?

Thanks,
Alex Sergeev

_______________________________________________
E1000-devel mailing list
E10...@li...
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel Ethernet, visit https://forums.intel.com/s/topic/0TO0P00000018NbWAI/intel-ethernet