[E1000-devel] potential bug in e1000_main.c

[Dietrich P. <die...@mi...>]

Dear sirs,

i have succesfully used the e1000 in a production system for years,
recently i needed to install a USB-Stick to my system for storage, and this 
was problematic.

What happened is that the usb was using the same interrup as the NIC. (irq 
#11)
The system stop working as soon as I load the usb-storage module with the 
following kernel message:
 
RTDM: xnintr_irq_handler: IRQ11 not handled. Disabling IRQ line.

There was no way for my board BIOS to assign other interrupts.

So I started to investigate a solution, and ad the end I found the following 
which seems to work.
Perhaps someone could consider to adopt this patch in the code of e1000.


in e1000_main.c in the e1000_intr routine I changed:

	if (unlikely(!icr)) {
        return RTDM_IRQ_NONE;  /* Not our interrupt */
	}


to 

	if (unlikely(!icr)) {
        return XN_ISR_PROPAGATE;  /* Not our interrupt */
	}


i.e. I m telling the RTDM to propagate the interrupt.

This small change solved my problem.

Please let me know if my point was clear

Bye,
Dietrich