Re: [E1000-devel] [patch] ixgbe: in shutdown, do netif_running() under rtnl_lock

[Skidmore, D. C <don...@in...>]

Hey Arthur,

Sorry about the slow reply, I think we got into a case of Jeff waiting for me to reply while was I waiting for Jeff to pull the patch into his queue.

As far as the patch goes it looks good to me.  In fact we the out of tree driver was already doing the rtnl lock out side of netif_running().  I'm not 100% sure at the moment how this difference crept into the drivers.  Regardless thanks for noticing this and bringing it to our attention.

Next Jeff will pull your patch into his tree for testing.  It has my ack though.

Thanks again,
-Don Skidmore <don...@in...>

> -----Original Message-----
> From: akepner [mailto:ak...@ri...]
> Sent: Tuesday, March 12, 2013 11:15 AM
> To: e10...@li...
> Subject: Re: [E1000-devel] [patch] ixgbe: in shutdown, do netif_running()
> under rtnl_lock
> 
> 
> Hi e1000-devel;
> 
> I sent a patch (same subject line as this mail) last Friday to both e1000-devel,
> and netdev.
> 
> Could you have a look at it, and give it an ack, or nak?
> 
> Thanks.
> 
> --
> Arthur
> 
> 
> ------------------------------------------------------------------------------
> Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
> Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
> endpoint security space. For insight on selecting the right partner to
> tackle endpoint security challenges, access the full report.
> http://p.sf.net/sfu/symantec-dev2dev
> _______________________________________________
> E1000-devel mailing list
> E10...@li...
> https://lists.sourceforge.net/lists/listinfo/e1000-devel
> To learn more about Intel&#174; Ethernet, visit
> http://communities.intel.com/community/wired