Re: [E1000-devel] igb_down from bottom half context

[anil d. <ani...@gm...>]

You know, you are doing wrong thing i.e sleeping in interrupt context.

As suggested by Ben, move code work queue or somewhere else. Other option
is dont sleep here.

--Anil
On Wed, Mar 6, 2013 at 11:08 PM, Ben Hutchings <bhu...@so...>wrote:

> On Wed, 2013-03-06 at 09:38 +0530, ratheesh kannoth wrote:
> > I  have kernel timer which  check for flag.
> >
> > if(flag ) {
> >           igb_down(adapter);
> >  } else {
> >          igb_up(adapter);
> >  }
> >
> >
> > I could see a kernel crash; because  there are a lot of  msleep() in
> > igb_down function.
> >
> > #define msleep(x)    do { set_current_state(TASK_UNINTERRUPTIBLE); \
> >                                 schedule_timeout((x * HZ)/1000 + 2); \
> >                               } while (0)
> >
> > sleep() is called from bottom half context; this is the cause of kernel
> crash.
> >
> > 1) Since timer call back dont have process context associated with it;
> > i think , "current" points to the last preempted task ?
> > 2) How can i introduce delays in interrupt context to avoid the kernel
> > crash. mdelay()  will work ?
> > 3) is there any better mechanism to do this job ?
>
> Use a work item and schedule_work().
>
> Ben.
>
> --
> Ben Hutchings, Staff Engineer, Solarflare
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
> the body of a message to maj...@vg...
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.linux-learn.org/faqs
>