Re: [E1000-devel] BUG? strange behavior with vlans and virtual functions on i350 -- possible solution

[Chris F. <chr...@ge...>]

On 11/15/2012 06:40 PM, Williams, Mitch A wrote:
> OK, got it reproduced and fixed. Turns out that your fix with the
> masking and byte swapping was spot on.
>
> If you want to respin your patch to remove the unconditional setting
> of the IGBVF_FLAG_RX_LB_VLAN_BSWAP flag, you should be good to go.
> Send that patch to this list and Jeff will add it to his queue and
> get it pushed upstream so you get credit for the fix.

Thanks for checking it out.  I'll follow this up with a patch.

Are you eventually going to be adding the IGBVF_FLAG_RX_LB_VLAN_BSWAP 
flag to the mainline igbvf driver or should I also send in a patch for that?

I am a bit curious about the endianness thing.  The datasheets for both 
the 82576 and i350 state that the VLAN tag is in network byte order, but 
the igbvf driver calls le16_to_cpu() for the normal case and only uses 
be16_to_cpu() for the errata case.  Am I missing a byte-swap along the 
way somewhere, or are both the datasheets wrong?

Chris