Re: [E1000-devel] BUG? strange behavior with vlans and virtual functions on i350

[Chris F. <chr...@ge...>]

On 11/08/2012 02:58 PM, Chris Friesen wrote:
> I tried
> using "ethtool -K ethX rxvlan off" but for some reason that option
> always showed as off even when CTRL.VME was actually set.

This is not my main problem, but somewhat related.  I think I found a 
flaw in the driver.

If you have a kernel where HAVE_VLAN_RX_REGISTER is set (newer than 
2.4.18) but where HAVE_NDO_SET_FEATURES is not set (older than 2.6.39), 
then it appears that

ethtool -K ethX rxvlan <off|on>"

will not actually change the hardware settings.  It will call 
igb_set_flags(), which will call ethtool_op_set_flags(), but nothing 
calls igb_vlan_mode() to actually change the hardware setting.

Chris