Menu
▾
▴
Re: [E1000-devel] [PATCH net-next v2 0/4] e1000e: ethtool setfeatures fixes + loopback
|
From: David D. <dav...@go...> - 2011-11-22 21:13:47
|
Jeff, Bruce, Please drop this patch series as I was informed that: - http://patchwork.ozlabs.org/patch/95175/ already implemented loopback for ethtool and is under review. Please note, though, that the version (patch 2) I submitted builds on top of newer net-next changes - Maciej Żenczykowski would prefer not to use the version I sent for patches 3 and 4, and will provide an improved patch I will mark the series as rejected on patchwork and will resend patch 1 (fix) as "v3". My apologies for this hick-up. Regards, -- David Decotigny On Tue, Nov 22, 2011 at 12:46 PM, Jeff Kirsher <jef...@in...> wrote: > On Tue, 2011-11-22 at 11:23 -0800, David Decotigny wrote: >> This series fixes a bug in ethtool setfeatures and adds loopback >> support through ethtool setfeatures. >> >> I believe these patches could easily be adapted to e1000, but I don't >> have the hardware to test. >> >> Changes since v1: >> - simplification in patch 1/4 (from Michał Mirosław) >> >> ############################################ >> # Patch Set Summary: >> >> David Decotigny (2): >> net-e1000e: fix ethtool set_features taking new features into account >> too late >> net-e1000e: ethtool loopback support >> >> Maciej Żenczykowski (2): >> net-e1000e: reworked carrier detection logic >> net-e1000e: Report carrier in loopback mode >> >> drivers/net/ethernet/intel/e1000e/e1000.h | 2 + >> drivers/net/ethernet/intel/e1000e/ethtool.c | 6 +- >> drivers/net/ethernet/intel/e1000e/netdev.c | 32 +++++++++++- >> drivers/net/ethernet/intel/e1000e/phy.c | 69 +++++++++++++++++---------- >> 4 files changed, 78 insertions(+), 31 deletions(-) >> > > Thanks David for the patch set. I have added the e1000e patches to my > queue. As an fyi, I want Bruce Allan to look over these patches and he > is out this week on vacation. |