From: Ben H. <bhu...@so...> - 2011-04-28 12:46:50
|
On Thu, 2011-04-28 at 09:34 +0200, Stanislaw Gruszka wrote: > On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote: > > --- a/drivers/net/stmmac/stmmac_ethtool.c > > +++ b/drivers/net/stmmac/stmmac_ethtool.c > > @@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev, > > > > if (phy->autoneg) { > > if (netif_running(netdev)) { > > - struct ethtool_cmd cmd; > > + struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET }; > > /* auto-negotiation automatically restarted */ > > - cmd.cmd = ETHTOOL_NWAY_RST; > > Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ? Because the function it's calling is an implementation of ETHTOOL_SSET, not ETHTOOL_NWAY_RST. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. |