From: David M. <da...@da...> - 2010-06-30 21:10:20
|
From: Ben Hutchings <bhu...@so...> Date: Wed, 30 Jun 2010 13:44:32 +0100 > ethtool_op_set_flags() does not check for unsupported flags, and has > no way of doing so. This means it is not suitable for use as a > default implementation of ethtool_ops::set_flags. > > Add a 'supported' parameter specifying the flags that the driver and > hardware support, validate the requested flags against this, and > change all current callers to pass this parameter. > > Change some other trivial implementations of ethtool_ops::set_flags to > call ethtool_op_set_flags(). > > Signed-off-by: Ben Hutchings <bhu...@so...> > Reviewed-by: Stanislaw Gruszka <sgr...@re...> > Acked-by: Jeff Garzik <jg...@re...> Applied. |