Re: [E1000-devel] [PATCH 2/2] ixgbe: fix select_queue management

[Waskiewicz J. P. P <pet...@in...>]

On Thu, 19 Mar 2009, Stephen Hemminger wrote:

> Convert ixgbe to use net_device_ops properly.
> Rather than changing the select_queue function pointer
> just check the flag.
> 
> Signed-off-by: Stephen Hemminger <she...@vy...>

Thanks Stephen.  I was looking at reassigning a DCB netdev_ops struct when 
DCB is enabled, and then having a default netdev_ops struct when it's not 
enabled.  I agree the check is cleaner the way you have it below, but it's 
another conditional check in the Tx hotpath, which we have too many of in 
the first place.

On a related side note, why is the netdev_ops member of net_device 
declared const?

Cheers,
-PJ Waskiewicz