#159 THookedObjects.Proxify reads past the end of the original class data

[Thomas Mueller]

THookedObjects.Proxify in gnugettext.pas allocates room for the class name plus the !dx suffix (dx_ChangeProxyClassname) and a trailing #0, but copied that whole size from the original class, whose ClassName is 4 bytes shorter.

So System.Move read 3 to 4 bytes past the end of the original class data and its name. If the class name ends exactly at a page or section boundary (e.g. last in a package's data), this is a read access violation; otherwise unrelated bytes are copied into the proxy. This happens even when dx_ChangeProxyClassname is not defined.

Fixed in revision 202: Proxify now copies only the original class data, up to the end of its ClassName; AllocMem has already zeroed the rest. Tested with Delphi 12, Win32 and Win64, with and without dx_ChangeProxyClassname.

[Thomas Mueller]

fixed in revision [r202]