[Docutils-develop] [docutils:patches] #216 Fix type annotation for get_default_settings

[Günter M. <mi...@us...>]

- **status**: open-accepted --> closed-accepted
- **Comment**:

Fixed in [Docutils 0.23](https://pypi.org/project/docutils/0.23/).
Thank you again for report and patch.



---

**[patches:#216] Fix type annotation for get\_default\_settings**

**Status:** closed-accepted
**Group:** None
**Created:** Thu Jan 22, 2026 09:04 AM UTC by Dmitry Shachnev
**Last Updated:** Sun Jan 25, 2026 02:16 PM UTC
**Owner:** nobody
**Attachments:**

- [0001-Fix-type-annotation-for-get\_default\_settings.patch](https://sourceforge.net/p/docutils/patches/216/attachment/0001-Fix-type-annotation-for-get_default_settings.patch) (966 Bytes; text/x-patch)


It accepts classes themselves, not instances of those classes.

This fixes error from mypy that I have for code that calls `get_default_settings(Writer)`.
```
error: Argument 1 to "get_default_settings" has incompatible type "type[Writer]"; expected "SettingsSpec"  [arg-type]
```


---

Sent from sourceforge.net because doc...@li... is subscribed to https://sourceforge.net/p/docutils/patches/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/patches/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.