Re: [Docutils-develop] handle_io_errors (was: 1.0.0 & API)

[David G. <go...@py...>]

On Wed, Jan 18, 2017 at 1:00 AM, Guenter Milde <mi...@us...> wrote:
> Dear David,
>
> API change request:
>
>>>>> We should consider some clean-up first, e.g.
>
>>>>> * remove the `handle_io_errors` option from io.FileInput/Output.
>
> handle_io_errors() is redundant and ignored
> since Release 0.10 (2012-12-16) but
>
>>>>> .. used by Sphinx up to version 1.3.1,
>>>>> see https://github.com/sphinx-doc/sphinx/issues/1834
>
> Fixed in Sphinx Release 1.3.2 (released Nov 29, 2015).
> Sphinx is now at 1.5.1 (stable) and 1.6 (dev).
>
> More than a year on and with the announcement still in place, is
> it OK to finally remove the redundant code?

Fine with me. Although a true deprecation should have included a
deprecation warning in the code itself. What guarantee do we have that
no other client code uses this?

This should be accompanied by a release note that (1) specifies the
removal and (2) states that Docutils version X (the released version)
is not compatible with Sphinx versions up to 1.3.1.

David Goodger
<http://python.net/~goodger>