From: Guenter M. <mi...@us...> - 2012-06-05 14:27:15
|
On 2012-05-30, Guenter Milde wrote: > On 2012-05-15, David Goodger wrote: >> On Mon, May 14, 2012 at 8:58 AM, Todd <tod...@gm...> wrote: >>> When compiling docutils 9 for python 3 I get > ... >>> directories that are not present in the python 2 version. > ... >> Indeed, that is a bug. ... >> The test directory should not be installed at all IMO. It isn't >> installed under Python 2.x. While it may need to be converted with >> 2to3.py for Python 3.x, I think that should be a separate step from >> package installation. > The conversion is part of ``setup.py build`` which I think is correct. > However, they should not be installed [...] The last commit solves the issue by placing converted tests and utils in test3/ and utils3/ subdirectories of the package archive root instead of build/test/ and build/utils/. Test required adaption, because the relative path to the default CSS stylesheet differs between the setups for Python 2 vs Python 3. As a consequence, tests are now self-contained and can also be run from any location (with an installed docutils version). To me, this bug seems severe enough to merit a 0.9.1 bugfix release. ------------------------------------------------- >> An idea for whoever implements a fix: perhaps we could >> include a Makefile with a "make tests" clause for this (as well as >> "make install" and anything else that makes sense). > I'll leave this to whoever feels inclined. (I'd prefer "targets" for the > Python setuptools over `make`, though.) The distutils docs http://docs.python.org/distutils/extending.html suggest that it should be possible to write and register classes so that ``python setup.py test`` and ``python setup.py buildhtml`` would trigger the expected actions. Günter |