From: David G. <go...@py...> - 2006-03-09 22:30:52
|
[Felix Wiemann] > I have added a "parsers.rst.Directive" base class on the > "directives" branch. I didn't want to call it > "parsers.rst.directives.Directive, =2E.. I thought about that too; your choice seems fine to me. > David, could you please have a look at the code? If you think it's > OK, I'll refactor the rest of the directives. The refactored directive looks fine. So far it's just moving the code out of a "directive" function into the Directive.run method, and adding "self." as appropriate, right? The modified docutils.rst.states.Body.parse_directive_block doesn't support the new required_arguments, optional_arguments, & final_argument_whitespace attributes yet though. I'm sure you would have discovered this quickly ;-) --=20 David Goodger <http://python.net/~goodger> |