Menu ▾ ▴

#306 draw:name is fixed in the ODT writer backend and figures and images are not correctly rendered in ODT outputs as a result

closed-fixed
nobody
ODT Writer (19)
7
2020-03-03
2017-02-07
No

It seems that rst2odt does not generate unique draw:name attribute for
each images embedded with '.. image::' or '.. figure::' directives,
and that causes strange problem that only 1st and 2nd images are shown
in generated ODT document.

I've created an experimental patch looks resolving this problem in https://bugzilla.redhat.com/show_bug.cgi?id=1360651 (The patch is https://bugzilla.redhat.com/attachment.cgi?id=1248317 ).

Discussion

  • Günter Milde

    Günter Milde - 2017-06-28
    • labels: --> ODT Writer
     
    • Dave Kuhlman

      Dave Kuhlman - 2017-07-03

      I've applied the patch mentioned below. And, the patch does
      actually make a difference in the content.xml file created in
      the resulting .odt file.

      However, I do not know how to re-creajte the error. I've place 3
      ".. image::" directives in a test input file. Those 3 images all
      seem to show up OK both with and without this patch.

      So, the patch works. The images are generated. The resulting file,
      when viewed in LibreOffice looks good. Maybe that's good enough.

      Or, maybe you can you give me a suggestion on how to produce the
      error condition.

      Dave K

       

      Last edit: Günter Milde 2017-07-17
  • Günter Milde

    Günter Milde - 2017-07-17
    • status: open --> closed-fixed
     
  • Günter Milde

    Günter Milde - 2017-07-17

    The point not mentioned in the description above but in the sample provided with the "downstream" bug report at redhat is that all three image directives pointed to the same image file.

    I could reproduce the error with the pre-patch version and the fix with the post-patch version.
    Thanks for report, patch, and fixing.

     
  • Masatake YAMATO

    Masatake YAMATO - 2017-08-09

    Is the patch merged?

     
  • Günter Milde

    Günter Milde - 2017-08-10

    Yes, it is.

     

Log in to post a comment.