[Dirssync-opendisc] inputs panel

[Mark C. <xs...@uk...>]

> From:   vincent delft <vin...@ya...>
> To:   dir...@li...
> Subject:   [Dirssync-opendisc] about inputs panel
> Date:   Thu, 11 Dec 2003 19:45:39 +0000 

 
> As requested I've added the "edit" button.
> But the delete is done when you rightclick on the job
> 
> Does it's not better to uniformize those actions ?
> Having buttons or via menus. 
> 
> What do you think ?
> what do you prefer ? button or menus ? knowing that
> the "add" MUST stay a button.

Keep with the buttons. I only synchronize a few directories, so there is
plenty of "screen real estate" to accommodate the buttons on the inputs
panel. It also makes it more obvious what you can do on the inputs
panel.

You can keep the behaviour that rightclicking on a job can cause a
deletion. That works fine enough. You might also consider having a
button called 'delete', which, suprise suprise, would delete the
currently highlighted job.

I think that it would also be useful to have a "save" button, which
overwrites the old job with the new details (c.f. the "add job" button").

BTW, I recently cleaned up some of the code. I did the unit test - and
found that I introduced a bug. I couldn't sort out what it was, so in
the end I decided to abandon the change and just stick with the latest
code in the repository. And the lesson is: UNIT TESTS ARE YOUR FRIEND.
They're boring to write, and really I should write more (although how
one can test the GUI is something that I haven't worked out yet) - but
when they're written, that's when the benefits kick in.

Vincent: do you *always* use vim to edit the code? The reason I ask is
that, going through some of the code that you wrote recently, they
appear to have tabs in them (which I cleaned up). This is a bit odd,
because the vim line at the bottom of the code ought to have inserted
spaces. Leading me to believe that vim was not used to edit the code.
BTW, I think it would be better if we actually used tabs instead of
spaces - it's what most people will use.

Another tip: seeings as I have been commiting code changes to the
repository, Vincent, or others, need to be aware of this; or they may get
a suprise when trying to commit code (they'll need to do an update
first). So it may become more important that we maintain communication
about who intends to alter code, what it is they're altering, and
generally get a feel for what's going on. 
> 
> Thanks
> 
> 
>  


_____________________________________________________________
Sign up for your very own email  address from UKmail.com To-day !!