Menu

#1538 [Regression] Bad render on Planet Rescue Animal Emergency (E)

SVN past 0.9.10
closed-fixed
rogerman
None
0.9.12
5
2016-03-04
2016-03-02
DottorLeo
No

On SVN 5372, on Planet Rescue Animal Emergency (E), the rendering is all messed up, as you can see on the screenshot. Also ingame, all the 3d stuff isn't rendered anymore. I've tried to track down where it start to do that but i've stopped on SVN5358. Both renderer are affected (Softrast and OpenGL 3.2). In the past the game works fine (except a problem with shadows, see #952 ).

1 Attachments

Discussion

  • rogerman

    rogerman - 2016-03-02
    • status: open --> open-accepted
    • assigned_to: rogerman
     
  • rogerman

    rogerman - 2016-03-02

    The problem started in [r5259]. Most likely, some register parsing got mangled. Will investigate further.

     

    Related

    Commit: [r5259]

  • rogerman

    rogerman - 2016-03-02
     
  • rogerman

    rogerman - 2016-03-02

    Fixed in [r5373].

    When I was redoing register handling in [r5259], I allowed the acknowledgment bits in DISP3DCNT to be written normally, thinking that it would have no effect on rendering. I now see that these bits do affect rendering.

    Do note that the acknowledgment bits were also dropped in the implementation prior to r5259, so I simply reverted that particular change. This is clearly a hack -- we should be able to handle the acknowledgment bits for the sake of accuracy.

    Please confirm the fix so I can close this issue, thanks!

     

    Related

    Commit: [r5259]
    Commit: [r5373]

  • DottorLeo

    DottorLeo - 2016-03-04

    Fix Confirmet, closing! Thank you!

     
  • DottorLeo

    DottorLeo - 2016-03-04
    • status: open-accepted --> closed-fixed
     

Anonymous
Anonymous

Add attachments
Cancel