Re: [Deinterlace-discuss] Bugs in scheduling code
Brought to you by:
adcockj,
dschmelzer
|
From: Radoslav M. <rad...@se...> - 2007-03-02 13:34:05
|
>I did not notice until now. The code in DScaler is not perfect.
I noticed it in CChannel class in getName function.
>Note that I am not trying to find all the bugs in your code. When
>comparing your patch with the original I happened to notice this
>issue. I hope you don't mind I brought it up.
>I hope you can enjoy a friendly debate and that we all learn something
from it.
No problem I like discussions like this. We can learn much...
>But how long does the static array contain the correct info? Looks
>like a race condition.
At the moment that is not an issue....while the array is used in code,
it doesn't change it's contents. However, I agree that technically is
better to make it old style just like:
void getTime(char* chTime)
{
...strcpy to chTime
}
>Maybe it is better to just let the calling code allocate the buffer
>and pass the pointer?
I won't bother with this I will declare m_name, m_program arrays in
class as we discussed earlier.
|