#74 detected IP is ignored when using freedns

[ste-fan]

When using the freedns protocol the IP that ddclient detected (by whatever means) gets ignored, since freedns's update.php script uses its own IP detection method. One has to append &address=<IP> to the update URL to circumvent that, e.g.:

https://freedns.afraid.org/dynamic/update.php?S7nZab8RPYjv19GqEkpQNNlT9sdbkBby2CHBvt2=&address=76.205.59.185

Most of the time this surely wouldn't be a problem since the IP ddclient detected should be the same as the one the PHP script found out. Possible use cases where this matters might be: ddclient instance on host A updating (different) IP address of host B; updating an AAAA record (IPv6). (IPs in these cases possibly retrieved by a cmd.)

A fixing patch to the current version (3.8.2) is attached. (As well as full outputs of ddclient unpatched and patched and my ddclient.conf.)

[ste-fan]

LOL! I should have searched first. Ticket #63 covers the exact same thing. But hopefully the information I gathered here (and the readymade patch) are useful for you anyway.

[ste-fan]

I improved the patch by handling empty update URLs (occur when hostname is wrong) correctly. See Attachment.

Edit: Posted the patch to the wrong version (3.8.1 which is the current one in ubuntu trusty) => but now that's updated: patches are performed to 3.8.2 again (besides line #s not much seems to change).

[Mykola Orliuk]

Heh, I did some patch also.... Had to look for ticket first:

https://github.com/ony/ddclient/commit/11e6304671ddc7c45a14a6a6f6278ab302f2e807

The only difference is that I moved out appending any query params to URL into a separate function urladd().