From: Jan E. <je...@co...> - 2007-06-23 21:47:48
|
On Jun 23 2007 23:06, Werner Baumann wrote: > > I am still missing arguments why not to use the standard way to > pass credentials to davfs2: the secrets file. Please tell me. After > all: there will rarely be cases where the login password is the > same as the webdav password. Users wanting to use pam_mount with davfs2 know that their regular PAM password will be used for any mounting. Hence, they have their webdav one set accordingly. > So editing the secrets file is not an extra effort. Users cannot edit the files in /etc/davfs2. >> Do not ever assume a line is always terminated >> with \n, because _it is not_. pam_mount sends the password without an >> \n. After all, /bin/mount reads _only_ a password, and nothing more, so >> that's established protocol. > > I will change this. But I would be interested in some documentation > about this 'established protocol'. (pam_mount is just an > application, not a protocol). What was the need to introduce lines > that are not terminated by a new line? Right... I am referring to samba-3.0.25a/source/client/mount.cifs.c:get_password_from_file(). Apparently, it allows for an \n to be present, but it is known to also accept input that is just the bare password without any \n. util-linux-2.12r+git20070530/mount/lomount.c:xgetpass() does the same (accepting either \n or no \n). The 'protocol' is described in mount(8), though it does not say anything special about newline in single-key mode. davfs however, always strips a character. > getpass(): There seems to be some confusion in the documentation > (man page : The GNU C Library Reference Manual). But I agree that > trying to get the real tty is problematic. So I will return to the > handmade code that reads from stdin. Don't worry too much about that. lomount also uses getpass :-/ Jan -- |