#7 OS and MEM command bugs

[Jared Smith]

The first time asked the reply is the previous text said in the channel. After that when the os or mem command are used it responds properly. The first time simply replies with the last text said in the channel before the command is issued.

[onefang]

This may have been fixed already, I can't reproduce it now.

[Luiz Castelo-Branco]

Confirmed - It gets buffer(?) from previous command.
... I did a !restart 3 queries before the occurrence, so that implies it might not be any sort of overflow.

<BotUser> !LANG
<DB> I speak English.
<BotUser> help lang
<BotUser> !MEM
<BotUser> help mem
<DB> MEM | RAM [level 3] - Shows some memory usage and process statistics.  SYNTAX - MEM
.... /msg DB login ....
<BotUser> !MEM
<DB> ps: botuser:+i+speak+english.
<BotUser> MEM
<DB> ps: USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMANDlcb       8004  0.0  0.0   6756   856 ?        S    12:15   0:00 ./darkbot

...
Unfortunately I were not running the bot in debug mode at the time of the error.
In debug the same command afterwards shows...

IN: :BotUser!~lcb@computer.home PRIVMSG #Darkbot :!MEM
OUT: PRIVMSG #Darkbot :ps: USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMANDlcb       9544  0.0  0.0   6756   852 pts/1    S+   13:35   0:00 ./darkbot -DEBUG

System logs didn't show anything abnormal.

ps.: We might need to think of any sort of '!RESTART -DEBUG' in future, probably by redirecting the messages to a darkbot/logs/debug.log file, being cautious on not allowing the usage of any -argument other that -DEBUG ... for system security. Also, it seems debug is parsing a very superficial set of messages - maybe tweaking it to have more than 1 debug level if a full debug is too much.

[Luiz Castelo-Branco]

I have a feeling the bug is preceded by a quick series of random commands or any type of entries directed to the bot.

<BotUser> ram?
<BotUser> help ram?
<BotUser> db help ram?
<BotUser> db
<DB> yes BotUser?
<BotUser> !ram?
<BotUser> !ram
<DB> ps: db+que