Re: [Conky-development] specials array size

[<sd....@gm...>]

On Wed, 22 Nov 2006 12:31:01 -0700
John Harrigan <jfh...@fe...> wrote:

> This might be related to bug 1574523 "Bug if 200+ variables."

Definately was related :) 

> The fix didn't mention changing the size of the specials array
> so I apologize if this has already been fixed.

No, we changed the size of the TEXT buffer, and made it configurable
 
> conky-1.4.4 was crashing on me with large config files with lots
> of variables.  I traced the problem to new_special() in src/conky.c.
> On line 520, there is a check to make sure there are no more than
> 512 items in the specials array.  The specials array is only
> initialized with 128 elements though.
>
> When I modified the specials array to hold 512, my crashes went
> away.  I've attached a diff against conky-1.4.4 to this e-mail.
> 
> --- conky-1.4.4/src/conky.c     2006-11-11 21:14:36.000000000 -0700
> +++ conky-modified/src/conky.c  2006-11-22 11:49:14.000000000 -0700
> @@ -506,7 +506,7 @@
>         short font_added;
>         unsigned long first_colour; // for graph gradient
>         unsigned long last_colour;
> -} specials[128];
> +} specials[512];
>  
>  static int special_count;
>  #ifdef X11

This fixes my issue as well, I'll see that this is committed shortly.
This is rest the bug that we just couldn't track down.  Thank you for
the patch! :)

-Bill