codestriker-user Mailing List for Codestriker: collaborative code reviewer (Page 5)
Brought to you by:
sits
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(12) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
|
Mar
(1) |
Apr
(6) |
May
(3) |
Jun
(1) |
Jul
|
Aug
(9) |
Sep
(2) |
Oct
(2) |
Nov
(8) |
Dec
(6) |
| 2004 |
Jan
(12) |
Feb
(19) |
Mar
(2) |
Apr
(2) |
May
(4) |
Jun
(11) |
Jul
|
Aug
(14) |
Sep
(4) |
Oct
(27) |
Nov
(4) |
Dec
(22) |
| 2005 |
Jan
(14) |
Feb
(2) |
Mar
(11) |
Apr
(3) |
May
(14) |
Jun
(60) |
Jul
(58) |
Aug
(76) |
Sep
(72) |
Oct
(59) |
Nov
|
Dec
(4) |
| 2006 |
Jan
(1) |
Feb
(5) |
Mar
(13) |
Apr
(11) |
May
(30) |
Jun
(17) |
Jul
(18) |
Aug
(39) |
Sep
|
Oct
|
Nov
|
Dec
(17) |
| 2007 |
Jan
(18) |
Feb
(5) |
Mar
(20) |
Apr
(2) |
May
(3) |
Jun
(13) |
Jul
(11) |
Aug
(4) |
Sep
(6) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
(10) |
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
(9) |
Jul
(10) |
Aug
(10) |
Sep
(13) |
Oct
(34) |
Nov
(12) |
Dec
(8) |
| 2009 |
Jan
(4) |
Feb
(11) |
Mar
(12) |
Apr
(3) |
May
(36) |
Jun
(4) |
Jul
(11) |
Aug
(12) |
Sep
(25) |
Oct
(13) |
Nov
(9) |
Dec
|
| 2010 |
Jan
|
Feb
(12) |
Mar
(6) |
Apr
(10) |
May
(12) |
Jun
|
Jul
(4) |
Aug
(9) |
Sep
(12) |
Oct
(3) |
Nov
(6) |
Dec
(3) |
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(3) |
Jun
(8) |
Jul
|
Aug
(14) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2012 |
Jan
(2) |
Feb
(10) |
Mar
(4) |
Apr
(3) |
May
(2) |
Jun
(5) |
Jul
|
Aug
(3) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(2) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: David S. <dav...@gm...> - 2010-09-22 10:15:46
|
Hi Dean, Thanks for your message. I haven't tried this, but edit the html/codestriker.css file, and replace: white-space: pre; white-space: pre-wrap; This might give you something closer to what you want.. Cheers, David On Wed, Sep 22, 2010 at 9:26 AM, Dean Arnold <dea...@pa...> wrote: > 1st, many thnx for a great tool! And in my old favorite language! > > > > But I’ve got a request: my source code has long lines, and the lack of a > wrapping capability is a serious limitation. Is it possible to break the > display table into 2 nested, fixed width tables w/ horizontal scrolling ? Or > alternately, into iframes w/ horizontal scrollbars ? > > > > If you can point me at the general area where this might be applied, I’d be > happy to play w/ it and submit a patch. > > > > Thanks, > > > > ParAccel, Inc. > > > > Dean Arnold > > Sr. Connectivity Engineer > > dea...@pa... > > 3 Results Way, Cupertino, CA 95014 > > Phone: (858)309-4733 x158 YIM: renodino1 > > www.paraccel.com > > > > > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > > |
|
From: Dean A. <dea...@pa...> - 2010-09-21 23:42:52
|
1st, many thnx for a great tool! And in my old favorite language! But I've got a request: my source code has long lines, and the lack of a wrapping capability is a serious limitation. Is it possible to break the display table into 2 nested, fixed width tables w/ horizontal scrolling ? Or alternately, into iframes w/ horizontal scrollbars ? If you can point me at the general area where this might be applied, I'd be happy to play w/ it and submit a patch. Thanks, ParAccel, Inc. Dean Arnold Sr. Connectivity Engineer dea...@pa...<mailto:kim...@pa...> 3 Results Way, Cupertino, CA 95014 Phone: (858)309-4733 x158 YIM: renodino1 www.paraccel.com<http://www.paraccel.com> |
|
From: David S. <dav...@gm...> - 2010-09-08 08:39:47
|
Hi Nick, I am afraid that is the only way at the moment. Cheers, David On Wed, Sep 8, 2010 at 6:11 PM, Nicolae Badiu <nic...@te...> wrote: > Hi all, > > Does anyone know of a way to add a new topic file to an existing topic? Currently, the only way I found to do this is to obsolete the topic and merge the two patch files into one. > > Thanks, > Nick |
|
From: Nicolae B. <nic...@te...> - 2010-09-08 08:30:24
|
Hi all, Does anyone know of a way to add a new topic file to an existing topic? Currently, the only way I found to do this is to obsolete the topic and merge the two patch files into one. Thanks, Nick |
|
From: tag98007 <tag...@gm...> - 2010-08-31 15:42:32
|
I called Perforce and they suggested this article: http://kb.perforce.com/article/723 The article exlains how to set up a ticket but more importantly how to set up a ticket that doesn't expire. Essentially it was: p4 -p <p4machine>:<port> -u <username> login -a </filelocationofpassword Then I tracked down the p4ticket location (it varies depending on the opsys, and is mentioned in the article), and took the number from the p4ticket and placed it in the codestriker.conf file where the password would be. According to Perforce you can use ticket numbers just like. -- View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5483258.html Sent from the Codestriker User mailing list archive at Nabble.com. |
|
From: David S. <dav...@gm...> - 2010-08-30 22:28:28
|
A ticket? Just for future reference.. what command did you use to create it? On Tue, Aug 31, 2010 at 7:43 AM, tag98007 <tag...@gm...> wrote: > > Yeah!!! I finally got this sorted out. It turns out I needed to create a > ticket that wouldn't expire and put the ticket number instead of the > password in the codestriker.conf file. |
|
From: tag98007 <tag...@gm...> - 2010-08-30 21:43:56
|
Yeah!!! I finally got this sorted out. It turns out I needed to create a ticket that wouldn't expire and put the ticket number instead of the password in the codestriker.conf file. -- View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5480247.html Sent from the Codestriker User mailing list archive at Nabble.com. |
|
From: David S. <dav...@gm...> - 2010-08-29 08:49:50
|
Why don't you email me your codestriker.conf file and the error message you get on apache (which should show in full) and email it to me personally, and leave the list of it for now. On Sat, Aug 28, 2010 at 3:01 AM, tag98007 <tag...@gm...> wrote: > > Apparently I’m having issues finding the saved per-user config in the > documentation. Could you give me more guidance, please? > > Is the username:password in the valid_repositories section of the > codestriker.conf ever used? I have the correct information there but I'm > still getting: Perforce password (P4PASSWD) invalid or unset even after I've > changed the default Web App User to something that should have access to > Perforce. > > I'm really confused about where the Perforce Password gets set. > > Any help would be greatly appreciated! > > thanks > -- > View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5470312.html > Sent from the Codestriker User mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: tag98007 <tag...@gm...> - 2010-08-27 17:01:27
|
Apparently I’m having issues finding the saved per-user config in the documentation. Could you give me more guidance, please? Is the username:password in the valid_repositories section of the codestriker.conf ever used? I have the correct information there but I'm still getting: Perforce password (P4PASSWD) invalid or unset even after I've changed the default Web App User to something that should have access to Perforce. I'm really confused about where the Perforce Password gets set. Any help would be greatly appreciated! thanks -- View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5470312.html Sent from the Codestriker User mailing list archive at Nabble.com. |
|
From: David S. <dav...@gm...> - 2010-08-20 23:08:10
|
You'll have to check the manual. I just have vague memories you can setup via some saved per-user config how to connect to perforce. The commands are run via the apache process, so you just need to set it up so the same user can connect to perforce. On Sat, Aug 21, 2010 at 8:51 AM, tag98007 <tag...@gm...> wrote: > > So there's not a way for a user other than the webserver user to access > Perforce? Where does the login take place? > > Thanks > -- > View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5446390.html > Sent from the Codestriker User mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: tag98007 <tag...@gm...> - 2010-08-20 22:51:57
|
So there's not a way for a user other than the webserver user to access Perforce? Where does the login take place? Thanks -- View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5446390.html Sent from the Codestriker User mailing list archive at Nabble.com. |
|
From: David S. <dav...@gm...> - 2010-08-20 22:36:16
|
> Is there a way to give the login and password for another user other than > the user running the webserver? We use LDAP authentication for Perforce and > I can create a name that can be used for the Perforce login, but I can't use > that as the user for the webserver. I don't use Perforce.. but I remember there was a way to specify all this through configuration. You should be able to log in as the web-server user, and set up all this config from the shell, and make it use a specific perforce user. Cheers, David |
|
From: tag98007 <tag...@gm...> - 2010-08-20 19:33:30
|
I think I've tracked the issue down to : # You also need to make sure that the user running your webserver has # permission to run the client SCM program (eg, cvs, p4, svn), and to # connect to the repository. Is there a way to give the login and password for another user other than the user running the webserver? We use LDAP authentication for Perforce and I can create a name that can be used for the Perforce login, but I can't use that as the user for the webserver. Any suggestions? Thanks tag98007 -- View this message in context: http://codestriker-user.684701.n2.nabble.com/Perforce-login-issue-tp5445810p5445810.html Sent from the Codestriker User mailing list archive at Nabble.com. |
|
From: David S. <dav...@gm...> - 2010-07-17 07:09:12
|
Hi Ken, There is no "Approved" state in a default Codestriker install, so it sounds like you have made some customisations on your install? Perhaps you can send me your codestriker.conf file, and any mods you have made to the default install, and possible your apache error.log file to help diagnose. Cheers, David On Sat, Jul 17, 2010 at 8:39 AM, Kenneth Wolcott <ken...@gm...> wrote: > > Hi Codestriker experts; > > While attempting to change the state of the topic from Open to Approved an error appears: " No email address was entered". > > I wrote up a Codestriker bug (3030778) on this since I did not find a pre-existing bug that was at all similar. > > I am going (very soon now) to be migrating to a brand new Linux vm (vmware) server for Codestriker (up-to-date Linux, up-to-date MySQL, up-to-date Apache and up-to-date Codestriker). > > Meanwhile I have Codestirker reviewers (including myself) who have been able to change the state of a topic from Open to Approved in the past but who are no longer able to do so. > > Now I am getting pressure to fix this as the workaround I have devised works but is silly (ask someone else to be the Codestriker reviewer, even if he/she is not technically qualified to be the reviewer of the specific topic). > > I have no idea how to troubleshoot/debug this state change failure. > > Thanks in advance to all useful advice received. > > Ken Wolcott > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Sprint > What will you do first with EVO, the first 4G phone? > Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: Kenneth W. <ken...@gm...> - 2010-07-16 22:39:24
|
Hi Codestriker experts; While attempting to change the state of the topic from Open to Approved an error appears: " No email address was entered". I wrote up a Codestriker bug (3030778) on this since I did not find a pre-existing bug that was at all similar. I am going (very soon now) to be migrating to a brand new Linux vm (vmware) server for Codestriker (up-to-date Linux, up-to-date MySQL, up-to-date Apache and up-to-date Codestriker). Meanwhile I have Codestirker reviewers (including myself) who have been able to change the state of a topic from Open to Approved in the past but who are no longer able to do so. Now I am getting pressure to fix this as the workaround I have devised works but is silly (ask someone else to be the Codestriker reviewer, even if he/she is not technically qualified to be the reviewer of the specific topic). I have no idea how to troubleshoot/debug this state change failure. Thanks in advance to all useful advice received. Ken Wolcott |
|
From: David S. <dav...@gm...> - 2010-07-12 00:42:34
|
Hi David, > 1 - the default URL is not the FQDN, I get https://host/codestriker/codestriker.pl?action=view&topic=866028&mode=1 > > Rather than the expected https://host.my.domain/<blah> > > What configuration option do I need to tweak? Have a look at http://sourceforge.net/tracker/?func=detail&atid=429860&aid=1574585&group_id=41136. > 2 - Clicking on parallel generates the following: > /usr/bin/svn cat -r1444 --username myuser --password mypass --no-auth-cache --non-interactive https://host. My.domain/svn/path/to/my/file.c > Check your webserver error log for more information. > at /var/www/codestriker/codestriker-1.9.10/lib/Codestriker/Repository/Subversion.pm line 89 > > Since this is Selinux, what do I need to tweak to bypass this error condition? This extra space in the final path looks strange. This would have happened either from your codestriker.conf repository settings, or your diff file. If you like, email me a sample diff file you are using and your codestriker.conf file and we should be able to figure out what is going wrong. Cheers, David |
|
From: David B. <db...@qu...> - 2010-07-07 19:36:56
|
1 - the default URL is not the FQDN, I get https://host/codestriker/codestriker.pl?action=view&topic=866028&mode=1 Rather than the expected https://host.my.domain/<blah> What configuration option do I need to tweak? 2 - Clicking on parallel generates the following: /usr/bin/svn cat -r1444 --username myuser --password mypass --no-auth-cache --non-interactive https://host. My.domain/svn/path/to/my/file.c Check your webserver error log for more information. at /var/www/codestriker/codestriker-1.9.10/lib/Codestriker/Repository/Subversion.pm line 89 Since this is Selinux, what do I need to tweak to bypass this error condition? David David Barto Software Engineering Manager Quake Global, Inc. 9765 Clairemont Mesa Blvd., Suite A San Diego, CA 92124 Phone (858)277-7290 x 280 Fax (858) 277-7259 Web: http://www.quakeglobal.com Email: db...@qu... NOTE: This communication (including any attachments) contains privileged or confidential information intended for a specific individual and purpose, and is protected by law. If you are not the intended recipient or believe that you may have received this communication in error, please reply to the sender indicating that fact and delete the copy you received. In addition, you should not print, copy, retransmit, disseminate, or otherwise use the information. Thank you. |
|
From: David S. <dav...@gm...> - 2010-05-13 11:11:25
|
> [Thu May 13 16:11:37 2010] [error] [client 135.250.32.106] ld.so.1: perl: > fatal: relocation error: file > /usr/local/lib/perl5/5.8.8/sun4-solaris//auto/Encode/Encode.so: symbol > Perl_call_pv: referenced symbol not found If you do a search with "ld.so.1: perl: fatal: relocation error: file /usr/local/lib/perl5/5.8.8/sun4-solaris" on google - you can see other hits. It some specific problem with Perl, and the C compiler you used when installing some cpan modules, in this case Encode. Is this deployed using CGI and not mod_perl? Try CGI first. Another option is to use cpan and upgrade the Encode module. Either way, its some perl problem more than Codestriker. Cheers, David |
|
From: David S. <dav...@gm...> - 2010-05-13 11:06:28
|
What if you use specify $Codestriker::tmpdir as ''. Does it make any
difference?
Also - what if you move the tempdir call outside the eval block. Do
you see a more sensible error message?
On Thu, May 13, 2010 at 8:11 PM, Nicolae Badiu <nic...@te...> wrote:
> I could try that, but still, what about the first error? As I said, it does not even get to the point of running system(...). It stops here:
>
> $command_tmpdir = tempdir(DIR => $Codestriker::tmpdir);
>
> The tempdir(...) invocation seems to work ok. Any assignment to this variable fails.
>
> -----Original Message-----
> From: David Sitsky [mailto:dav...@gm...]
> Sent: Thursday, May 13, 2010 1:10 PM
> To: Nicolae Badiu
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>
> Strange. Being windows, and mod_perl, you might have to explicitly
> set the PATH in your apache config to get around this, so that certain
> executables can run?
>
> On Thu, May 13, 2010 at 7:52 PM, Nicolae Badiu <nic...@te...> wrote:
>> Hi David,
>>
>> I am using ActivePerl 5.8.9 build 827 and Apache 1.3.33.
>>
>> There were two errors I noticed. In the Codestriker.pm execute_command subroutine (see relevant excerpt below):
>> 1) any assignment to the $command_tmpdir variable within the eval block would result in an error (was not able to tell which though)
>> 2) after commenting out the assignments, the system(...) subroutine returned $! as "No such file or directory". I played around with the parameters and tried it against simple commands such as "dir" or "C:\svn.exe" (which existed). The permissions were there a.s.o. I assume the error message actually refers to some missing library, some .so file.
>>
>> Thanks,
>> Nick
>>
>> my $command_tmpdir;
>> eval {
>> if (exists $ENV{'MOD_PERL'} ||
>> (defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTWARE'} =~ /IIS/)) {
>> # The open3() call doesn't work under mod_perl/apache2,
>> # so create a command which stores the stdout and stderr
>> # into temporary files. It also seems flacky under IIS.
>> if (defined $Codestriker::tmpdir && $Codestriker::tmpdir ne "") {
>> $command_tmpdir = tempdir(DIR => $Codestriker::tmpdir);
>> } else {
>> $command_tmpdir = tempdir();
>> }
>>
>> # Build up the command string with naive quoting.
>> my $command_line = "\"$command\"";
>> foreach my $arg (@args) {
>> $command_line .= " \"$arg\"";
>> }
>>
>> my $stdout_filename = "$command_tmpdir/stdout.txt";
>> my $stderr_filename = "$command_tmpdir/stderr.txt";
>>
>> # Thankfully this works under Windows.
>> my $system_line =
>> "$command_line > \"$stdout_filename\" 2> \"$stderr_filename\"";
>> system($system_line) == 0 ||
>> croak "Failed to execute $system_line: $!\n";
>>
>>
>>
>>
>> -----Original Message-----
>> From: David Sitsky [mailto:dav...@gm...]
>> Sent: Thursday, May 13, 2010 12:43 PM
>> To: Nicolae Badiu
>> Cc: cod...@li...
>> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>>
>> You are probably right. I don't like ruling it out completely, as I
>> have had windows + mod_perl work in the past, but it seems very
>> temperamental, and its hard to know what combination causes it. Which
>> version of perl and distro are you using?
>>
>> So no useful error messages in apache's error log files?
>>
>> From memory, a lot of it had to do with how they changed the rules
>> with executing processes (like svn and the highlight program) in a
>> mod_perl environment.
>>
>> That said - it all works fine on Unix boxes.
>>
>> On Thu, May 13, 2010 at 3:41 PM, Nicolae Badiu <nic...@te...> wrote:
>>> Thanks David,
>>>
>>> Maybe it is worth calling these issues out in the documentation. Could save someone else's time.
>>>
>>> Thanks,
>>> Nick
>>>
>>> -----Original Message-----
>>> From: David Sitsky [mailto:dav...@gm...]
>>> Sent: Thursday, May 13, 2010 8:18 AM
>>> To: Nicolae Badiu
>>> Cc: cod...@li...
>>> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>>>
>>> Hi Nicolae,
>>>
>>> I have always found from experience Windows + mod_perl simply don't
>>> mix well. Maybe apache2 is better (and is worth trying), but I always
>>> had problems with it.
>>>
>>> I usually use Linux as my back-end box. Mod_perl is a bit of
>>> black-magic, so I am not surprised it doesn't work well under Windows.
>>>
>>> Cheers,
>>> David
>>>
>>
>
|
|
From: Nicolae B. <nic...@te...> - 2010-05-13 10:14:22
|
I could try that, but still, what about the first error? As I said, it does not even get to the point of running system(...). It stops here:
$command_tmpdir = tempdir(DIR => $Codestriker::tmpdir);
The tempdir(...) invocation seems to work ok. Any assignment to this variable fails.
-----Original Message-----
From: David Sitsky [mailto:dav...@gm...]
Sent: Thursday, May 13, 2010 1:10 PM
To: Nicolae Badiu
Cc: cod...@li...
Subject: Re: [Codestriker-user] mod_perl issues under Windows
Strange. Being windows, and mod_perl, you might have to explicitly
set the PATH in your apache config to get around this, so that certain
executables can run?
On Thu, May 13, 2010 at 7:52 PM, Nicolae Badiu <nic...@te...> wrote:
> Hi David,
>
> I am using ActivePerl 5.8.9 build 827 and Apache 1.3.33.
>
> There were two errors I noticed. In the Codestriker.pm execute_command subroutine (see relevant excerpt below):
> 1) any assignment to the $command_tmpdir variable within the eval block would result in an error (was not able to tell which though)
> 2) after commenting out the assignments, the system(...) subroutine returned $! as "No such file or directory". I played around with the parameters and tried it against simple commands such as "dir" or "C:\svn.exe" (which existed). The permissions were there a.s.o. I assume the error message actually refers to some missing library, some .so file.
>
> Thanks,
> Nick
>
> my $command_tmpdir;
> eval {
> if (exists $ENV{'MOD_PERL'} ||
> (defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTWARE'} =~ /IIS/)) {
> # The open3() call doesn't work under mod_perl/apache2,
> # so create a command which stores the stdout and stderr
> # into temporary files. It also seems flacky under IIS.
> if (defined $Codestriker::tmpdir && $Codestriker::tmpdir ne "") {
> $command_tmpdir = tempdir(DIR => $Codestriker::tmpdir);
> } else {
> $command_tmpdir = tempdir();
> }
>
> # Build up the command string with naive quoting.
> my $command_line = "\"$command\"";
> foreach my $arg (@args) {
> $command_line .= " \"$arg\"";
> }
>
> my $stdout_filename = "$command_tmpdir/stdout.txt";
> my $stderr_filename = "$command_tmpdir/stderr.txt";
>
> # Thankfully this works under Windows.
> my $system_line =
> "$command_line > \"$stdout_filename\" 2> \"$stderr_filename\"";
> system($system_line) == 0 ||
> croak "Failed to execute $system_line: $!\n";
>
>
>
>
> -----Original Message-----
> From: David Sitsky [mailto:dav...@gm...]
> Sent: Thursday, May 13, 2010 12:43 PM
> To: Nicolae Badiu
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>
> You are probably right. I don't like ruling it out completely, as I
> have had windows + mod_perl work in the past, but it seems very
> temperamental, and its hard to know what combination causes it. Which
> version of perl and distro are you using?
>
> So no useful error messages in apache's error log files?
>
> From memory, a lot of it had to do with how they changed the rules
> with executing processes (like svn and the highlight program) in a
> mod_perl environment.
>
> That said - it all works fine on Unix boxes.
>
> On Thu, May 13, 2010 at 3:41 PM, Nicolae Badiu <nic...@te...> wrote:
>> Thanks David,
>>
>> Maybe it is worth calling these issues out in the documentation. Could save someone else's time.
>>
>> Thanks,
>> Nick
>>
>> -----Original Message-----
>> From: David Sitsky [mailto:dav...@gm...]
>> Sent: Thursday, May 13, 2010 8:18 AM
>> To: Nicolae Badiu
>> Cc: cod...@li...
>> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>>
>> Hi Nicolae,
>>
>> I have always found from experience Windows + mod_perl simply don't
>> mix well. Maybe apache2 is better (and is worth trying), but I always
>> had problems with it.
>>
>> I usually use Linux as my back-end box. Mod_perl is a bit of
>> black-magic, so I am not surprised it doesn't work well under Windows.
>>
>> Cheers,
>> David
>>
>
|
|
From: David S. <dav...@gm...> - 2010-05-13 10:09:56
|
Strange. Being windows, and mod_perl, you might have to explicitly
set the PATH in your apache config to get around this, so that certain
executables can run?
On Thu, May 13, 2010 at 7:52 PM, Nicolae Badiu <nic...@te...> wrote:
> Hi David,
>
> I am using ActivePerl 5.8.9 build 827 and Apache 1.3.33.
>
> There were two errors I noticed. In the Codestriker.pm execute_command subroutine (see relevant excerpt below):
> 1) any assignment to the $command_tmpdir variable within the eval block would result in an error (was not able to tell which though)
> 2) after commenting out the assignments, the system(...) subroutine returned $! as "No such file or directory". I played around with the parameters and tried it against simple commands such as "dir" or "C:\svn.exe" (which existed). The permissions were there a.s.o. I assume the error message actually refers to some missing library, some .so file.
>
> Thanks,
> Nick
>
> my $command_tmpdir;
> eval {
> if (exists $ENV{'MOD_PERL'} ||
> (defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTWARE'} =~ /IIS/)) {
> # The open3() call doesn't work under mod_perl/apache2,
> # so create a command which stores the stdout and stderr
> # into temporary files. It also seems flacky under IIS.
> if (defined $Codestriker::tmpdir && $Codestriker::tmpdir ne "") {
> $command_tmpdir = tempdir(DIR => $Codestriker::tmpdir);
> } else {
> $command_tmpdir = tempdir();
> }
>
> # Build up the command string with naive quoting.
> my $command_line = "\"$command\"";
> foreach my $arg (@args) {
> $command_line .= " \"$arg\"";
> }
>
> my $stdout_filename = "$command_tmpdir/stdout.txt";
> my $stderr_filename = "$command_tmpdir/stderr.txt";
>
> # Thankfully this works under Windows.
> my $system_line =
> "$command_line > \"$stdout_filename\" 2> \"$stderr_filename\"";
> system($system_line) == 0 ||
> croak "Failed to execute $system_line: $!\n";
>
>
>
>
> -----Original Message-----
> From: David Sitsky [mailto:dav...@gm...]
> Sent: Thursday, May 13, 2010 12:43 PM
> To: Nicolae Badiu
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>
> You are probably right. I don't like ruling it out completely, as I
> have had windows + mod_perl work in the past, but it seems very
> temperamental, and its hard to know what combination causes it. Which
> version of perl and distro are you using?
>
> So no useful error messages in apache's error log files?
>
> From memory, a lot of it had to do with how they changed the rules
> with executing processes (like svn and the highlight program) in a
> mod_perl environment.
>
> That said - it all works fine on Unix boxes.
>
> On Thu, May 13, 2010 at 3:41 PM, Nicolae Badiu <nic...@te...> wrote:
>> Thanks David,
>>
>> Maybe it is worth calling these issues out in the documentation. Could save someone else's time.
>>
>> Thanks,
>> Nick
>>
>> -----Original Message-----
>> From: David Sitsky [mailto:dav...@gm...]
>> Sent: Thursday, May 13, 2010 8:18 AM
>> To: Nicolae Badiu
>> Cc: cod...@li...
>> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>>
>> Hi Nicolae,
>>
>> I have always found from experience Windows + mod_perl simply don't
>> mix well. Maybe apache2 is better (and is worth trying), but I always
>> had problems with it.
>>
>> I usually use Linux as my back-end box. Mod_perl is a bit of
>> black-magic, so I am not surprised it doesn't work well under Windows.
>>
>> Cheers,
>> David
>>
>
|
|
From: Nicolae B. <nic...@te...> - 2010-05-13 09:52:35
|
Hi David,
I am using ActivePerl 5.8.9 build 827 and Apache 1.3.33.
There were two errors I noticed. In the Codestriker.pm execute_command subroutine (see relevant excerpt below):
1) any assignment to the $command_tmpdir variable within the eval block would result in an error (was not able to tell which though)
2) after commenting out the assignments, the system(...) subroutine returned $! as "No such file or directory". I played around with the parameters and tried it against simple commands such as "dir" or "C:\svn.exe" (which existed). The permissions were there a.s.o. I assume the error message actually refers to some missing library, some .so file.
Thanks,
Nick
my $command_tmpdir;
eval {
if (exists $ENV{'MOD_PERL'} ||
(defined($ENV{'SERVER_SOFTWARE'}) && $ENV{'SERVER_SOFTWARE'} =~ /IIS/)) {
# The open3() call doesn't work under mod_perl/apache2,
# so create a command which stores the stdout and stderr
# into temporary files. It also seems flacky under IIS.
if (defined $Codestriker::tmpdir && $Codestriker::tmpdir ne "") {
$command_tmpdir = tempdir(DIR => $Codestriker::tmpdir);
} else {
$command_tmpdir = tempdir();
}
# Build up the command string with naive quoting.
my $command_line = "\"$command\"";
foreach my $arg (@args) {
$command_line .= " \"$arg\"";
}
my $stdout_filename = "$command_tmpdir/stdout.txt";
my $stderr_filename = "$command_tmpdir/stderr.txt";
# Thankfully this works under Windows.
my $system_line =
"$command_line > \"$stdout_filename\" 2> \"$stderr_filename\"";
system($system_line) == 0 ||
croak "Failed to execute $system_line: $!\n";
-----Original Message-----
From: David Sitsky [mailto:dav...@gm...]
Sent: Thursday, May 13, 2010 12:43 PM
To: Nicolae Badiu
Cc: cod...@li...
Subject: Re: [Codestriker-user] mod_perl issues under Windows
You are probably right. I don't like ruling it out completely, as I
have had windows + mod_perl work in the past, but it seems very
temperamental, and its hard to know what combination causes it. Which
version of perl and distro are you using?
So no useful error messages in apache's error log files?
>From memory, a lot of it had to do with how they changed the rules
with executing processes (like svn and the highlight program) in a
mod_perl environment.
That said - it all works fine on Unix boxes.
On Thu, May 13, 2010 at 3:41 PM, Nicolae Badiu <nic...@te...> wrote:
> Thanks David,
>
> Maybe it is worth calling these issues out in the documentation. Could save someone else's time.
>
> Thanks,
> Nick
>
> -----Original Message-----
> From: David Sitsky [mailto:dav...@gm...]
> Sent: Thursday, May 13, 2010 8:18 AM
> To: Nicolae Badiu
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] mod_perl issues under Windows
>
> Hi Nicolae,
>
> I have always found from experience Windows + mod_perl simply don't
> mix well. Maybe apache2 is better (and is worth trying), but I always
> had problems with it.
>
> I usually use Linux as my back-end box. Mod_perl is a bit of
> black-magic, so I am not surprised it doesn't work well under Windows.
>
> Cheers,
> David
>
|
|
From: David S. <dav...@gm...> - 2010-05-13 09:43:15
|
You are probably right. I don't like ruling it out completely, as I have had windows + mod_perl work in the past, but it seems very temperamental, and its hard to know what combination causes it. Which version of perl and distro are you using? So no useful error messages in apache's error log files? >From memory, a lot of it had to do with how they changed the rules with executing processes (like svn and the highlight program) in a mod_perl environment. That said - it all works fine on Unix boxes. On Thu, May 13, 2010 at 3:41 PM, Nicolae Badiu <nic...@te...> wrote: > Thanks David, > > Maybe it is worth calling these issues out in the documentation. Could save someone else's time. > > Thanks, > Nick > > -----Original Message----- > From: David Sitsky [mailto:dav...@gm...] > Sent: Thursday, May 13, 2010 8:18 AM > To: Nicolae Badiu > Cc: cod...@li... > Subject: Re: [Codestriker-user] mod_perl issues under Windows > > Hi Nicolae, > > I have always found from experience Windows + mod_perl simply don't > mix well. Maybe apache2 is better (and is worth trying), but I always > had problems with it. > > I usually use Linux as my back-end box. Mod_perl is a bit of > black-magic, so I am not surprised it doesn't work well under Windows. > > Cheers, > David > |
|
From: Nicolae B. <nic...@te...> - 2010-05-13 05:41:25
|
Thanks David, Maybe it is worth calling these issues out in the documentation. Could save someone else's time. Thanks, Nick -----Original Message----- From: David Sitsky [mailto:dav...@gm...] Sent: Thursday, May 13, 2010 8:18 AM To: Nicolae Badiu Cc: cod...@li... Subject: Re: [Codestriker-user] mod_perl issues under Windows Hi Nicolae, I have always found from experience Windows + mod_perl simply don't mix well. Maybe apache2 is better (and is worth trying), but I always had problems with it. I usually use Linux as my back-end box. Mod_perl is a bit of black-magic, so I am not surprised it doesn't work well under Windows. Cheers, David |
|
From: David S. <dav...@gm...> - 2010-05-13 05:18:00
|
Hi Nicolae, I have always found from experience Windows + mod_perl simply don't mix well. Maybe apache2 is better (and is worth trying), but I always had problems with it. I usually use Linux as my back-end box. Mod_perl is a bit of black-magic, so I am not surprised it doesn't work well under Windows. Cheers, David |