codestriker-user Mailing List for Codestriker: collaborative code reviewer (Page 26)
Brought to you by:
sits
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(12) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
|
Mar
(1) |
Apr
(6) |
May
(3) |
Jun
(1) |
Jul
|
Aug
(9) |
Sep
(2) |
Oct
(2) |
Nov
(8) |
Dec
(6) |
| 2004 |
Jan
(12) |
Feb
(19) |
Mar
(2) |
Apr
(2) |
May
(4) |
Jun
(11) |
Jul
|
Aug
(14) |
Sep
(4) |
Oct
(27) |
Nov
(4) |
Dec
(22) |
| 2005 |
Jan
(14) |
Feb
(2) |
Mar
(11) |
Apr
(3) |
May
(14) |
Jun
(60) |
Jul
(58) |
Aug
(76) |
Sep
(72) |
Oct
(59) |
Nov
|
Dec
(4) |
| 2006 |
Jan
(1) |
Feb
(5) |
Mar
(13) |
Apr
(11) |
May
(30) |
Jun
(17) |
Jul
(18) |
Aug
(39) |
Sep
|
Oct
|
Nov
|
Dec
(17) |
| 2007 |
Jan
(18) |
Feb
(5) |
Mar
(20) |
Apr
(2) |
May
(3) |
Jun
(13) |
Jul
(11) |
Aug
(4) |
Sep
(6) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
(10) |
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
(9) |
Jul
(10) |
Aug
(10) |
Sep
(13) |
Oct
(34) |
Nov
(12) |
Dec
(8) |
| 2009 |
Jan
(4) |
Feb
(11) |
Mar
(12) |
Apr
(3) |
May
(36) |
Jun
(4) |
Jul
(11) |
Aug
(12) |
Sep
(25) |
Oct
(13) |
Nov
(9) |
Dec
|
| 2010 |
Jan
|
Feb
(12) |
Mar
(6) |
Apr
(10) |
May
(12) |
Jun
|
Jul
(4) |
Aug
(9) |
Sep
(12) |
Oct
(3) |
Nov
(6) |
Dec
(3) |
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(3) |
Jun
(8) |
Jul
|
Aug
(14) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2012 |
Jan
(2) |
Feb
(10) |
Mar
(4) |
Apr
(3) |
May
(2) |
Jun
(5) |
Jul
|
Aug
(3) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(2) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Jack P. <j-p...@ta...> - 2006-04-18 15:40:32
|
Howdy David,
Thanks. You are correct, sir!
$ rpm -q httpd mod_perl
httpd-2.0.51-1.10.legacy
mod_perl-1.99_12-2
Switching to CGI and tossing the "export CVS_RSH"
from the server startup script works as originally
advertised/coded (i.e. $ENV{} in Cvs.pm works).
It is also remarkably faster in retrieving the full text
using CGI than using mod_perl. CGI takes about 3 seconds
here to retrieve a 220 line file via SSH. mod_perl takes
about 40!
Perhaps I should just stick with running in CGI mode for now.
I went with mod_perl given the:
"Using mod_perl provides performance benefits for Perl-based
web applications."
blurb in the instructions. In my limited testing,
I'm not seeing any "benefits". :)
I agree... damn shame that "hysterically" CVS has never provided
a command-line option for CVS_RSH (and therefore probably never will).
jack
j-p...@ta...
On Tue, 2006-04-18 at 02:35, David Sitsky wrote:
> Hi Jack,
>
> > [...]
> > So, for now, my workaround is to put:
> >
> > export CVS_RSH /usr/bin/ssh
> >
> > in /etc/sysconfig/httpd unless someone can
> > suggest a better solution as to why either
> > the original code didn't work.
>
> This sounds to me like you have setup Codestriker with apache2 and
> mod_perl? Most people I know are using CVS with pserver, or direct
> access, which is why this isn't an issue reported on very often.
>
> If you deploy Codestriker in plain old CGI mode, I suspect the existing
> code in Cvs.pm which export CVS_RSH will actually work. Under mod_perl
> however, this probably gets suppressed, particularly under apache2.
>
> Can you try with CGI to see if this works?
>
> > the perl script it is in UNLESS (for some reason)
> > it was from the environment of the server when
> > it started. So, using "SetEnv CVS_RSH /usr/bin/ssh"
> > in httpd.conf and using "$ENV{'CVS_RSH'}='/usr/bin/ssh';'
> > in the scripts will affect the running environment
> > but not the one the open runs in.
>
> I think this caveat is right with apache2/mod_perl. Its a damn shame
> cvs doesn't have a command-line option for specifying what rsh program
> to use, like rsync, rather than using an environment variable.
>
> Cheers,
> David
>
|
|
From: David S. <si...@us...> - 2006-04-18 07:37:13
|
Hi Jack, > [...] > I'd suggest another database table called "states" (or something) > with the following attributes/fields: > > state_id - short int > state_name - short string (char 10 or so) > state_desc - long string > state_readonly - bool > > and then loading them up. I think that will be > much more robust in the long term since it means > we don't have to keep the code aligned with the DB > schema and it also kinda nails down the definition > of the states. > > Of course, we'll need a little "state edit" screen > like what is available for projects. > > Anyway... just a thought. Sounds good to me. The reason why it is the way it is is because of "hysterical" reasons - the days before Codestriker even used a database for persistence. Having said that, there is no reason why we couldn't migrate to the above schema. I'm pretty busy these days, so I don't know when I'd work on this. I've added it to the task list though so it is not forgotten. Cheers, David |
|
From: David S. <si...@us...> - 2006-04-18 07:33:00
|
Hi Jack,
> [...]
> So, for now, my workaround is to put:
>
> export CVS_RSH /usr/bin/ssh
>
> in /etc/sysconfig/httpd unless someone can
> suggest a better solution as to why either
> the original code didn't work.
This sounds to me like you have setup Codestriker with apache2 and
mod_perl? Most people I know are using CVS with pserver, or direct
access, which is why this isn't an issue reported on very often.
If you deploy Codestriker in plain old CGI mode, I suspect the existing
code in Cvs.pm which export CVS_RSH will actually work. Under mod_perl
however, this probably gets suppressed, particularly under apache2.
Can you try with CGI to see if this works?
> the perl script it is in UNLESS (for some reason)
> it was from the environment of the server when
> it started. So, using "SetEnv CVS_RSH /usr/bin/ssh"
> in httpd.conf and using "$ENV{'CVS_RSH'}='/usr/bin/ssh';'
> in the scripts will affect the running environment
> but not the one the open runs in.
I think this caveat is right with apache2/mod_perl. Its a damn shame
cvs doesn't have a command-line option for specifying what rsh program
to use, like rsync, rather than using an environment variable.
Cheers,
David
|
|
From: Jack P. <j-p...@ta...> - 2006-04-17 02:25:08
|
Howdy all,
Yesterday I found a tool which is exactly the kind
of thing I've been looking for (have desperately needed)
for coordinating software development in/with our group.
Yes, I found codestriker.
My motivations are pretty much the same as David's
original ones... sick of pointless meetings, sick
of redundant and contradictory feedback on proposed
patches, and having a tree full of changes that are
going to get lost because the damn code review process
is such as hassle (most here have resorted to only
doing face to face meeting which drives me absolutely
bonkers in this day and age and therefore none of
my code gets approved).
I'm really looking forward to watching this develop
and will be glad to pitch in (provided my sales
pitch to my group on "why we should use this" works
out).
Anyway... thought I'd share a) something I've learned,
and, b) something I'd suggest given my brief time
with 1.9.2-alpha-3
What I learned is that line 62 of lib/Codestriker/Repository/Cvs.pm
doesn't seem to export CVS_RSH properly so that it is
used by the open/cvs in line 63.
If you want to see what I mean:
a) change line 63 to use '-t' instead of '-q' to make cvs verbose
and try to retieve a diff's full text ("Parallel" view).
Look in apache's error_log and you'll see that instead of
trying to using ssh, it is instead hung on:
Starting server: rsh -l myaccount myhost.mydomain cvs server
To understand why, it is using rsh...
b) change line 47 of the top codeswitch.conf from '/usr/bin/cvs'
to '/tmp/cvs'
c) create /tmp/cvs with 755 with the following 2 lines
#!/bin/bash
echo CVS_RSH is $CVS_RSH
d) restart apache (just for grins)
Now when you go to retrieve the full text of a diff from CVS via
ext: and SSH, instead of hanging, it should show something like
the following for line 1:
CVS_RSH is
So, using ENV there in Cvs.pm isn't getting to
the child's environment.
My first solution was to just set CVS_RSH before starting apache
(e.g. adding the "export" to /etc/sysconfig/httpd on Redhat systems),
but that seemed to be overkill.
What looked to be a more proper solution was to add
the following to httpd.conf:
SetEnv CVS_RSH /usr/bin/ssh
But, that doesn't seem to be working. (???)
That way apache's startup environment isn't polluted,
just its children's are (if it worked).
So, for now, my workaround is to put:
export CVS_RSH /usr/bin/ssh
in /etc/sysconfig/httpd unless someone can
suggest a better solution as to why either
the original code didn't work.
I've attached the current nastiness that is
my present Cvs.pm's retrieve() function if anyone
wants to explore it more. Basically I've come to
the conclusion that the environment perl uses for
"open()" does not get the complete environment of
the perl script it is in UNLESS (for some reason)
it was from the environment of the server when
it started. So, using "SetEnv CVS_RSH /usr/bin/ssh"
in httpd.conf and using "$ENV{'CVS_RSH'}='/usr/bin/ssh';'
in the scripts will affect the running environment
but not the one the open runs in.
Sorry if that's too long and confusing... I'm just
trying to clarify my confusion/problems/solutions.
I don't know perl for squat... (though it looks
kinda like sh and C).
If I shouldn't HAVE to set this before starting apache
someone please help me out.
As for my suggestion... I think the "state of states"
needs to be redone. ;)
When I see notes like:
<quote>
# List of valid topic states. Note these values are mapped to the
database
# depending on their position in the list. ie, Open -> 0, Closed -> 1,
etc.
# There is no problem added new states dynamically, or changing the
textual
# names.
</quote>
I get scared.
I'd suggest another database table called "states" (or something)
with the following attributes/fields:
state_id - short int
state_name - short string (char 10 or so)
state_desc - long string
state_readonly - bool
and then loading them up. I think that will be
much more robust in the long term since it means
we don't have to keep the code aligned with the DB
schema and it also kinda nails down the definition
of the states.
Of course, we'll need a little "state edit" screen
like what is available for projects.
Anyway... just a thought.
I'm also worried about user authentication but for now
I think I'm going to try to get away with just using SSL and
.htaccess.
Finally... my last word of advice for any one new who finds
this note in the future...
If you are on Linux and your kernel supports/has 'selinux'...
turn it off while trying to get it working!!! You can turn
it back on later after you've got your repo access working
and mail going to all the right places... before then,
it will cause you no end of grief.
Anyway, great tool... looking forward to seeing it develop.
jack
j-p...@ta...
http://parasol.tamu.edu/people/jkp2866/
p.s. more debug would good... e.g the option to use '-t' instead
of '-q' for cvs (without changing code), etc.
# Retrieve the data corresponding to $filename and $revision. Store
each line
# into $content_array_ref.
sub retrieve {
my ($self, $filename, $revision, $content_array_ref) = @_;
# Open a pipe to the CVS repository.
print STDERR "from httpd.conf ".$ENV{'CVS_RSH'}."\n";
$ENV{'CVS_RSH'} = $Codestriker::ssh if defined $Codestriker::ssh;
print STDERR "from codestriker.conf ".$ENV{'CVS_RSH'}."\n";
open(FOO, '/bin/echo PATH is $PATH - CVS_RSH is $CVS_RSH |')
|| die "Can't open FOO: $!";
while( <FOO> ) { print STDERR $_."\n"; }
close FOO;
open(FOO, '/bin/env |')
|| die "Can't open FOO: $!";
while( <FOO> ) { print STDERR $_; }
close FOO;
#open(CVS, "\"$Codestriker::cvs\" -q -d \"" . $self->{url} .
open(CVS, "\"$Codestriker::cvs\" -t -d \"" . $self->{url} .
"\" co -p -r $revision \"$filename\" |")
|| die "Can't open connection to pserver CVS repository: $!";
# Read the data.
for (my $i = 1; <CVS>; $i++) {
chop;
$$content_array_ref[$i] = $_;
}
close CVS;
}
|
|
From: <wa...@ne...> - 2006-03-28 01:31:13
|
SGkgRGF2aWQsDQoNClRoYW5rIHlvdSBmb3IgeW91ciBoZWxwISBpdCB3b3JrcyBub3cuDQoNCmFm dGVyIHRyYWNraW5nIHRoZSBhcGFjaGUgZXJyb3IgbG9nIGZpbGUsIGkgZm91bmQgQXV0aGVuL1NB U0wgbW9kdWxlIGlzIG1pc3NpbmcgaW4gbXkgc3lzdGVtLCBzbyBpIGRvd25sb2FkZWQgYW5kIGlu c3RhbGxlZCBBdXRoZW4vU0FTTCBtb2R1bGUgZnJvbSBjcGFuLm9yZy4NCg0KYW5kIHRoZW4gbW9k aWZlZCBlbWFpbC5wbQ0KYWRkZWQgdGhlIGZvbGxvd2luZyBsaW5lcw0KDQoxOCAgIHVzZSBNSU1F OjpCYXNlNjQ7DQoxOSAgIEF1dGhlbjo6U0FTTDsNCg0KNDQ0ICBzbXRwLT5hdXRoKG15YWNjb3Vu dCwgbXlwc3dkKTsNCg0KaXQgd29ya3MgZmluZSwgdGhhbmsgeW91IQ0KDQp3aXRoIGtpbmQgcmVn YXJkcywNCg0KSGVydHogV2FuZyANCg0KLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLSANCkZy b206ICJEYXZpZCBTaXRza3kiIDxzaXRzQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4NClRvOiAiSGVy dHogV2FuZyDN9buz1r4iIDx3YW5naHpAbmV1c29mdC5jb20+DQpDYzogPGNvZGVzdHJpa2VyLXVz ZXJAbGlzdHMuc291cmNlZm9yZ2UubmV0Pg0KU2VudDogRnJpZGF5LCBNYXJjaCAyNCwgMjAwNiA3 OjQ1IEFNDQpTdWJqZWN0OiBSZTogW0NvZGVzdHJpa2VyLXVzZXJdIEhlbHAgLS0gbWFpbCBjb25m aWd1cmF0aW9uDQoNCg0KT24gbGluZSA0Mzkgb2YgRW1haWwucG0sIHRyeSBtb2RpZnlpbmcgaXQg dG8gYmU6DQoNCm15ICRzbXRwID0gTmV0OjpTTVRQLT5uZXcoJENvZGVzdHJpa2VyOjptYWlsaG9z dCk7DQoNCnRvDQoNCm15ICRzbXRwID0gTmV0OjpTTVRQLT5uZXcoJENvZGVzdHJpa2VyOjptYWls aG9zdCwgRGVidWcgPT4gMSk7DQoNCkFsc28gLSBjaGVjayB0aGUgc3RkZXJyIGZyb20gYXBhY2hl J3MgZXJyb3IgbG9nIGZpbGUgLSB0aGVyZSBtaWdodCBiZQ0Kc29tZSB1c2VmdWwgaW5mb3JtYXRp b24gdGhlcmUgdG9vLg0KDQpDaGVlcnMsDQpEYXZpZA0KDQpIZXJ0eiBXYW5nIM31u7PWviB3cm90 ZToNCj4gSSBnb3QgdGhlIHNhbWUgbWVzc2FnZSBhZnRlciB0aGUgY2hhbmdlDQo+IA0KPiAiQ291 bGRuJ3Qgc2V0IHNlbmRlciB0byB3YW5naHpAbmV1c29mdC5jb20sIDUuNy4wIE5vIEFVVEggY29t bWFuZCBoYXMgYmVlbiBnaXZlbi4iDQo+IA0KPiBJIGNoZWNrIHRoZSBlbWFpbC5wbSBmaWxlIGFn YWluLCBpIHJlYWxseSBhZGQgJHNtdHAtPmF1dGgoJ3dhbmdoeicsICdoZXJ0enBzd2QnKSBiZWZv cmUgDQo+IGFuZCBpIGFkZCAidGhlIHN5c3RlbSIgYmVmb3JlICJDb3VsZG4ndCIsIGFuZCB0aGVu IGFkZCBhIGNvbW1lbnQgaW4gY29kZXN0cmlrZXIsIGENCj4gInRoZSBzeXN0ZW0gQ291bGRuJ3Qg c2V0IHNlbmRlciB0byB3YW5naHpAbmV1c29mdC5jb20sIDUuNy4wIE5vIEFVVEggY29tbWFuZCBo YXMgYmVlbiBnaXZlbi4iDQo+IG1lc3NhZ2Ugd2FzIGdpdmVuLCBzbyB0aGUgY2hhbmdlcyB0YWtl IGVmZmVjdC4gaSBhbSBzdXJlIHRoZSB1c2VybmFtZSBhbmQgcGFzc3dvcmQgaXMgY29ycmVjdC4N Cj4gDQo+IA0KPiAtLS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tIA0KPiBGcm9tOiAiSGVydHog V2FuZyDN9buz1r4iIDx3YW5naHpAbmV1c29mdC5jb20+DQo+IFRvOiAiRGF2aWQgU2l0c2t5IiA8 c2l0c0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQo+IENjOiA8Y29kZXN0cmlrZXItdXNlckBsaXN0 cy5zb3VyY2Vmb3JnZS5uZXQ+DQo+IFNlbnQ6IFRodXJzZGF5LCBNYXJjaCAyMywgMjAwNiA3OjMy IFBNDQo+IFN1YmplY3Q6IFJlOiBbQ29kZXN0cmlrZXItdXNlcl0gSGVscCAtLSBtYWlsIGNvbmZp Z3VyYXRpb24NCj4gDQo+IA0KPj4gSGkgRGF2aWQsDQo+Pg0KPj4gVGhhbmsgeW91IGZvciB5b3Vy IHJlcGx5LCBJIHJlcGxhY2UgDQo+PiAkc210cC0+bWFpbCgkZnJvbSk7DQo+PiB3aXRoDQo+PiAk c210cC0+YXV0aCgnd2FuZ2h6JywgJ2hlcnR6cHN3ZCcpOw0KPj4gJHNtdHAtPm1haWwoJGZyb20p Ow0KPj4NCj4+IGl0IGRvZXNuJ3Qgd29yaywgJ2hlcnR6cHN3ZCcgaXMgbXkgcmVhbCBwYXNzd29y ZChvZiBjb3Vyc2UsIGkgY2hhbmdlZCBpdCBub3cgOikgKQ0KPj4NCj4+IGFuZCB0aGVuIGkgcmVs cGFjZSAkZnJvbSB3aXRoIG15IGVtYWlsDQo+PiAkc210cC0+bWFpbCgnd2FuZ2h6QG5ldXNvZnQu Y29tJyk7DQo+Pg0KPj4gaXQgZG9lc24ndCBoZWxwIGVpdGhlci4NCj4+DQo+Pg0KPj4NCj4+IEhl cnR6IFdhbmcgDQo+PiAtLS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tIA0KPj4gRnJvbTogIkRh dmlkIFNpdHNreSIgPHNpdHNAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPj4gVG86ICJIZXJ0eiBX YW5nIM31u7PWviIgPHdhbmdoekBuZXVzb2Z0LmNvbT4NCj4+IENjOiA8Y29kZXN0cmlrZXItdXNl ckBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQ+DQo+PiBTZW50OiBUaHVyc2RheSwgTWFyY2ggMjMsIDIw MDYgNjozNSBBTQ0KPj4gU3ViamVjdDogUmU6IFtDb2Rlc3RyaWtlci11c2VyXSBIZWxwIC0tIG1h aWwgY29uZmlndXJhdGlvbg0KPj4NCj4+DQo+Pj4gSGVydHogV2FuZyDN9buz1r4gd3JvdGU6DQo+ Pj4+IEhpIEFsbCwNCj4+Pj4gIA0KPj4+PiBJIG1ldCBhbm90aGVyIHByb2JsZW0gd2hlbiB0cnkg dG8gdXNlIGNvZGVzdHJpa2VyIDEuOS4yIEFscGhhMi4NCj4+Pj4gIA0KPj4+PiBXaGVuIEkgY3Jl YXRlIGEgbmV3IHRvcGljIG9yIGFkZCBzb21lIGNvbW1lbnRzLCB0aGUgbWFpbCBub3RpZmljYXRp b24gDQo+Pj4+IGRvZXNuJ3Qgd29yay4gdGhpcyBpcyB0aGUgbWVzc2FnZSBJIGdvdCwNCj4+Pj4g IA0KPj4+PiAiNS43LjAgTm8gQVVUSCBjb21tYW5kIGhhcyBiZWVuIGdpdmVuLiINCj4+Pj4gIA0K Pj4+PiBNeSBjb25maWdyYXRpb24gaW4gY29kZXN0cmlrZXIuY29uZjoNCj4+Pj4gJG1haWxob3N0 ID0gJ3BubXNtYWlsLm5ldXNvZnQuY29tJzsNCj4+Pj4gIA0KPj4+PiBteSBtYWlsIHNlcnZlciBu ZWVkIGF1dGhvcml6YXRpb24sIGhvdyBjYW4gSSBzb2x2ZSB0aGlzIHByb2JsZW0/DQo+Pj4gT3Bl biB1cCB0aGUgZmlsZTogbGliL0NvZGVzdHJpa2VyL1RvcGljTGlzdGVuZXJzL0VtYWlsLnBtIGFu ZCBnbyB0byBsaW5lDQo+Pj4gNDQyLCB3aGVyZSB5b3Ugc2hvdWxkIHNlZToNCj4+Pg0KPj4+ICRz bXRwLT5tYWlsKCRmcm9tKTsNCj4+Pg0KPj4+IE1vZGlmeSB0aGlzIGNvZGUgdG8gcmVhZCAoc3Vi c3RpdHV0ZSB0aGUgc3RyaW5ncyB3aXRoIHlvdXIgYWN0dWFsDQo+Pj4gdXNlcm5hbWUvcGFzc3dv cmQgdmFsdWVzKS4NCj4+Pg0KPj4+ICRzbXRwLT5hdXRoKCdteXVzZXJuYW1lJywgJ215cGFzc3dv cmQnKTsNCj4+PiAkc210cC0+bWFpbCgkZnJvbSk7DQo+Pj4NCj4+PiBMZXQgbWUga25vdyBpZiB0 aGF0IHdvcmsgb3Igbm90LiAgSWYgaXQgZG9lcywgSSdsbCBtb2RpZnkNCj4+PiBjb2Rlc3RyaWtl ci5jb25mIHNvIHRoYXQgdGhpcyBleHRyYSBtYWlsIGNvbmZpZyBjYW4gYmUgc3BlY2lmaWVkIHRo ZXJlLg0KPj4+DQo+Pj4gQ2hlZXJzLA0KPj4+IERhdmlkDQo+Pj4NCj4+ID4NCg0KDQoNCg0KLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KVGhp cyBTRi5OZXQgZW1haWwgaXMgc3BvbnNvcmVkIGJ5IHhQTUwsIGEgZ3JvdW5kYnJlYWtpbmcgc2Ny aXB0aW5nIGxhbmd1YWdlDQp0aGF0IGV4dGVuZHMgYXBwbGljYXRpb25zIGludG8gd2ViIGFuZCBt b2JpbGUgbWVkaWEuIEF0dGVuZCB0aGUgbGl2ZSB3ZWJjYXN0DQphbmQgam9pbiB0aGUgcHJpbWUg ZGV2ZWxvcGVyIGdyb3VwIGJyZWFraW5nIGludG8gdGhpcyBuZXcgY29kaW5nIHRlcnJpdG9yeSEN Cmh0dHA6Ly9zZWwuYXMtdXMuZmFsa2FnLm5ldC9zZWw/Y21kPWsma2lkETA5NDQmYmlkJDE3MjAm ZGF0EjE2NDINCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f DQpDb2Rlc3RyaWtlci11c2VyIG1haWxpbmcgbGlzdA0KQ29kZXN0cmlrZXItdXNlckBsaXN0cy5z b3VyY2Vmb3JnZS5uZXQNCmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3Rp bmZvL2NvZGVzdHJpa2VyLXVzZXI= |
|
From: David S. <si...@us...> - 2006-03-23 23:49:25
|
On line 439 of Email.pm, try modifying it to be:
my $smtp =3D Net::SMTP->new($Codestriker::mailhost);
to
my $smtp =3D Net::SMTP->new($Codestriker::mailhost, Debug =3D> 1);
Also - check the stderr from apache's error log file - there might be
some useful information there too.
Cheers,
David
Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
> I got the same message after the change
>=20
> "Couldn't set sender to wa...@ne..., 5.7.0 No AUTH command has b=
een given."
>=20
> I check the email.pm file again, i really add $smtp->auth('wanghz', 'he=
rtzpswd') before=20
> and i add "the system" before "Couldn't", and then add a comment in cod=
estriker, a
> "the system Couldn't set sender to wa...@ne..., 5.7.0 No AUTH co=
mmand has been given."
> message was given, so the changes take effect. i am sure the username a=
nd password is correct.
>=20
>=20
> ----- Original Message -----=20
> From: "Hertz Wang =CD=F5=BB=B3=D6=BE" <wa...@ne...>
> To: "David Sitsky" <si...@us...>
> Cc: <cod...@li...>
> Sent: Thursday, March 23, 2006 7:32 PM
> Subject: Re: [Codestriker-user] Help -- mail configuration
>=20
>=20
>> Hi David,
>>
>> Thank you for your reply, I replace=20
>> $smtp->mail($from);
>> with
>> $smtp->auth('wanghz', 'hertzpswd');
>> $smtp->mail($from);
>>
>> it doesn't work, 'hertzpswd' is my real password(of course, i changed =
it now :) )
>>
>> and then i relpace $from with my email
>> $smtp->mail('wa...@ne...');
>>
>> it doesn't help either.
>>
>>
>>
>> Hertz Wang=20
>> ----- Original Message -----=20
>> From: "David Sitsky" <si...@us...>
>> To: "Hertz Wang =CD=F5=BB=B3=D6=BE" <wa...@ne...>
>> Cc: <cod...@li...>
>> Sent: Thursday, March 23, 2006 6:35 AM
>> Subject: Re: [Codestriker-user] Help -- mail configuration
>>
>>
>>> Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
>>>> Hi All,
>>>> =20
>>>> I met another problem when try to use codestriker 1.9.2 Alpha2.
>>>> =20
>>>> When I create a new topic or add some comments, the mail notificatio=
n=20
>>>> doesn't work. this is the message I got,
>>>> =20
>>>> "5.7.0 No AUTH command has been given."
>>>> =20
>>>> My configration in codestriker.conf:
>>>> $mailhost =3D 'pnmsmail.neusoft.com';
>>>> =20
>>>> my mail server need authorization, how can I solve this problem?
>>> Open up the file: lib/Codestriker/TopicListeners/Email.pm and go to l=
ine
>>> 442, where you should see:
>>>
>>> $smtp->mail($from);
>>>
>>> Modify this code to read (substitute the strings with your actual
>>> username/password values).
>>>
>>> $smtp->auth('myusername', 'mypassword');
>>> $smtp->mail($from);
>>>
>>> Let me know if that work or not. If it does, I'll modify
>>> codestriker.conf so that this extra mail config can be specified ther=
e.
>>>
>>> Cheers,
>>> David
>>>
>> >
|
|
From: <wa...@ne...> - 2006-03-23 11:40:06
|
SSBnb3QgdGhlIHNhbWUgbWVzc2FnZSBhZnRlciB0aGUgY2hhbmdlDQoNCiJDb3VsZG4ndCBzZXQg c2VuZGVyIHRvIHdhbmdoekBuZXVzb2Z0LmNvbSwgNS43LjAgTm8gQVVUSCBjb21tYW5kIGhhcyBi ZWVuIGdpdmVuLiINCg0KSSBjaGVjayB0aGUgZW1haWwucG0gZmlsZSBhZ2FpbiwgaSByZWFsbHkg YWRkICRzbXRwLT5hdXRoKCd3YW5naHonLCAnaGVydHpwc3dkJykgYmVmb3JlIA0KYW5kIGkgYWRk ICJ0aGUgc3lzdGVtIiBiZWZvcmUgIkNvdWxkbid0IiwgYW5kIHRoZW4gYWRkIGEgY29tbWVudCBp biBjb2Rlc3RyaWtlciwgYQ0KInRoZSBzeXN0ZW0gQ291bGRuJ3Qgc2V0IHNlbmRlciB0byB3YW5n aHpAbmV1c29mdC5jb20sIDUuNy4wIE5vIEFVVEggY29tbWFuZCBoYXMgYmVlbiBnaXZlbi4iDQpt ZXNzYWdlIHdhcyBnaXZlbiwgc28gdGhlIGNoYW5nZXMgdGFrZSBlZmZlY3QuIGkgYW0gc3VyZSB0 aGUgdXNlcm5hbWUgYW5kIHBhc3N3b3JkIGlzIGNvcnJlY3QuDQoNCg0KLS0tLS0gT3JpZ2luYWwg TWVzc2FnZSAtLS0tLSANCkZyb206ICJIZXJ0eiBXYW5nIM31u7PWviIgPHdhbmdoekBuZXVzb2Z0 LmNvbT4NClRvOiAiRGF2aWQgU2l0c2t5IiA8c2l0c0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQpD YzogPGNvZGVzdHJpa2VyLXVzZXJAbGlzdHMuc291cmNlZm9yZ2UubmV0Pg0KU2VudDogVGh1cnNk YXksIE1hcmNoIDIzLCAyMDA2IDc6MzIgUE0NClN1YmplY3Q6IFJlOiBbQ29kZXN0cmlrZXItdXNl cl0gSGVscCAtLSBtYWlsIGNvbmZpZ3VyYXRpb24NCg0KDQo+IEhpIERhdmlkLA0KPiANCj4gVGhh bmsgeW91IGZvciB5b3VyIHJlcGx5LCBJIHJlcGxhY2UgDQo+ICRzbXRwLT5tYWlsKCRmcm9tKTsN Cj4gd2l0aA0KPiAkc210cC0+YXV0aCgnd2FuZ2h6JywgJ2hlcnR6cHN3ZCcpOw0KPiAkc210cC0+ bWFpbCgkZnJvbSk7DQo+IA0KPiBpdCBkb2Vzbid0IHdvcmssICdoZXJ0enBzd2QnIGlzIG15IHJl YWwgcGFzc3dvcmQob2YgY291cnNlLCBpIGNoYW5nZWQgaXQgbm93IDopICkNCj4gDQo+IGFuZCB0 aGVuIGkgcmVscGFjZSAkZnJvbSB3aXRoIG15IGVtYWlsDQo+ICRzbXRwLT5tYWlsKCd3YW5naHpA bmV1c29mdC5jb20nKTsNCj4gDQo+IGl0IGRvZXNuJ3QgaGVscCBlaXRoZXIuDQo+IA0KPiANCj4g DQo+IEhlcnR6IFdhbmcgDQo+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0gDQo+IEZyb206 ICJEYXZpZCBTaXRza3kiIDxzaXRzQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4NCj4gVG86ICJIZXJ0 eiBXYW5nIM31u7PWviIgPHdhbmdoekBuZXVzb2Z0LmNvbT4NCj4gQ2M6IDxjb2Rlc3RyaWtlci11 c2VyQGxpc3RzLnNvdXJjZWZvcmdlLm5ldD4NCj4gU2VudDogVGh1cnNkYXksIE1hcmNoIDIzLCAy MDA2IDY6MzUgQU0NCj4gU3ViamVjdDogUmU6IFtDb2Rlc3RyaWtlci11c2VyXSBIZWxwIC0tIG1h aWwgY29uZmlndXJhdGlvbg0KPiANCj4gDQo+PiBIZXJ0eiBXYW5nIM31u7PWviB3cm90ZToNCj4+ PiBIaSBBbGwsDQo+Pj4gIA0KPj4+IEkgbWV0IGFub3RoZXIgcHJvYmxlbSB3aGVuIHRyeSB0byB1 c2UgY29kZXN0cmlrZXIgMS45LjIgQWxwaGEyLg0KPj4+ICANCj4+PiBXaGVuIEkgY3JlYXRlIGEg bmV3IHRvcGljIG9yIGFkZCBzb21lIGNvbW1lbnRzLCB0aGUgbWFpbCBub3RpZmljYXRpb24gDQo+ Pj4gZG9lc24ndCB3b3JrLiB0aGlzIGlzIHRoZSBtZXNzYWdlIEkgZ290LA0KPj4+ICANCj4+PiAi NS43LjAgTm8gQVVUSCBjb21tYW5kIGhhcyBiZWVuIGdpdmVuLiINCj4+PiAgDQo+Pj4gTXkgY29u ZmlncmF0aW9uIGluIGNvZGVzdHJpa2VyLmNvbmY6DQo+Pj4gJG1haWxob3N0ID0gJ3BubXNtYWls Lm5ldXNvZnQuY29tJzsNCj4+PiAgDQo+Pj4gbXkgbWFpbCBzZXJ2ZXIgbmVlZCBhdXRob3JpemF0 aW9uLCBob3cgY2FuIEkgc29sdmUgdGhpcyBwcm9ibGVtPw0KPj4gDQo+PiBPcGVuIHVwIHRoZSBm aWxlOiBsaWIvQ29kZXN0cmlrZXIvVG9waWNMaXN0ZW5lcnMvRW1haWwucG0gYW5kIGdvIHRvIGxp bmUNCj4+IDQ0Miwgd2hlcmUgeW91IHNob3VsZCBzZWU6DQo+PiANCj4+ICRzbXRwLT5tYWlsKCRm cm9tKTsNCj4+IA0KPj4gTW9kaWZ5IHRoaXMgY29kZSB0byByZWFkIChzdWJzdGl0dXRlIHRoZSBz dHJpbmdzIHdpdGggeW91ciBhY3R1YWwNCj4+IHVzZXJuYW1lL3Bhc3N3b3JkIHZhbHVlcykuDQo+ PiANCj4+ICRzbXRwLT5hdXRoKCdteXVzZXJuYW1lJywgJ215cGFzc3dvcmQnKTsNCj4+ICRzbXRw LT5tYWlsKCRmcm9tKTsNCj4+IA0KPj4gTGV0IG1lIGtub3cgaWYgdGhhdCB3b3JrIG9yIG5vdC4g IElmIGl0IGRvZXMsIEknbGwgbW9kaWZ5DQo+PiBjb2Rlc3RyaWtlci5jb25mIHNvIHRoYXQgdGhp cyBleHRyYSBtYWlsIGNvbmZpZyBjYW4gYmUgc3BlY2lmaWVkIHRoZXJlLg0KPj4gDQo+PiBDaGVl cnMsDQo+PiBEYXZpZA0KPj4gDQo+Pg== |
|
From: <wa...@ne...> - 2006-03-23 11:30:49
|
SGkgRGF2aWQsDQoNClRoYW5rIHlvdSBmb3IgeW91ciByZXBseSwgSSByZXBsYWNlIA0KJHNtdHAt Pm1haWwoJGZyb20pOw0Kd2l0aA0KJHNtdHAtPmF1dGgoJ3dhbmdoeicsICdoZXJ0enBzd2QnKTsN CiRzbXRwLT5tYWlsKCRmcm9tKTsNCg0KaXQgZG9lc24ndCB3b3JrLCAnaGVydHpwc3dkJyBpcyBt eSByZWFsIHBhc3N3b3JkKG9mIGNvdXJzZSwgaSBjaGFuZ2VkIGl0IG5vdyA6KSApDQoNCmFuZCB0 aGVuIGkgcmVscGFjZSAkZnJvbSB3aXRoIG15IGVtYWlsDQokc210cC0+bWFpbCgnd2FuZ2h6QG5l dXNvZnQuY29tJyk7DQoNCml0IGRvZXNuJ3QgaGVscCBlaXRoZXIuDQoNCiANCg0KSGVydHogV2Fu ZyANCi0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0gDQpGcm9tOiAiRGF2aWQgU2l0c2t5IiA8 c2l0c0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQpUbzogIkhlcnR6IFdhbmcgzfW7s9a+IiA8d2Fu Z2h6QG5ldXNvZnQuY29tPg0KQ2M6IDxjb2Rlc3RyaWtlci11c2VyQGxpc3RzLnNvdXJjZWZvcmdl Lm5ldD4NClNlbnQ6IFRodXJzZGF5LCBNYXJjaCAyMywgMjAwNiA2OjM1IEFNDQpTdWJqZWN0OiBS ZTogW0NvZGVzdHJpa2VyLXVzZXJdIEhlbHAgLS0gbWFpbCBjb25maWd1cmF0aW9uDQoNCg0KPiBI ZXJ0eiBXYW5nIM31u7PWviB3cm90ZToNCj4+IEhpIEFsbCwNCj4+ICANCj4+IEkgbWV0IGFub3Ro ZXIgcHJvYmxlbSB3aGVuIHRyeSB0byB1c2UgY29kZXN0cmlrZXIgMS45LjIgQWxwaGEyLg0KPj4g IA0KPj4gV2hlbiBJIGNyZWF0ZSBhIG5ldyB0b3BpYyBvciBhZGQgc29tZSBjb21tZW50cywgdGhl IG1haWwgbm90aWZpY2F0aW9uIA0KPj4gZG9lc24ndCB3b3JrLiB0aGlzIGlzIHRoZSBtZXNzYWdl IEkgZ290LA0KPj4gIA0KPj4gIjUuNy4wIE5vIEFVVEggY29tbWFuZCBoYXMgYmVlbiBnaXZlbi4i DQo+PiAgDQo+PiBNeSBjb25maWdyYXRpb24gaW4gY29kZXN0cmlrZXIuY29uZjoNCj4+ICRtYWls aG9zdCA9ICdwbm1zbWFpbC5uZXVzb2Z0LmNvbSc7DQo+PiAgDQo+PiBteSBtYWlsIHNlcnZlciBu ZWVkIGF1dGhvcml6YXRpb24sIGhvdyBjYW4gSSBzb2x2ZSB0aGlzIHByb2JsZW0/DQo+IA0KPiBP cGVuIHVwIHRoZSBmaWxlOiBsaWIvQ29kZXN0cmlrZXIvVG9waWNMaXN0ZW5lcnMvRW1haWwucG0g YW5kIGdvIHRvIGxpbmUNCj4gNDQyLCB3aGVyZSB5b3Ugc2hvdWxkIHNlZToNCj4gDQo+ICRzbXRw LT5tYWlsKCRmcm9tKTsNCj4gDQo+IE1vZGlmeSB0aGlzIGNvZGUgdG8gcmVhZCAoc3Vic3RpdHV0 ZSB0aGUgc3RyaW5ncyB3aXRoIHlvdXIgYWN0dWFsDQo+IHVzZXJuYW1lL3Bhc3N3b3JkIHZhbHVl cykuDQo+IA0KPiAkc210cC0+YXV0aCgnbXl1c2VybmFtZScsICdteXBhc3N3b3JkJyk7DQo+ICRz bXRwLT5tYWlsKCRmcm9tKTsNCj4gDQo+IExldCBtZSBrbm93IGlmIHRoYXQgd29yayBvciBub3Qu ICBJZiBpdCBkb2VzLCBJJ2xsIG1vZGlmeQ0KPiBjb2Rlc3RyaWtlci5jb25mIHNvIHRoYXQgdGhp cyBleHRyYSBtYWlsIGNvbmZpZyBjYW4gYmUgc3BlY2lmaWVkIHRoZXJlLg0KPiANCj4gQ2hlZXJz LA0KPiBEYXZpZA0KPiANCj4= |
|
From: David S. <si...@us...> - 2006-03-22 22:33:52
|
Hertz Wang =CD=F5=BB=B3=D6=BE wrote: > Hi All, > =20 > I met another problem when try to use codestriker 1.9.2 Alpha2. > =20 > When I create a new topic or add some comments, the mail notification=20 > doesn't work. this is the message I got, > =20 > "5.7.0 No AUTH command has been given." > =20 > My configration in codestriker.conf: > $mailhost =3D 'pnmsmail.neusoft.com'; > =20 > my mail server need authorization, how can I solve this problem? Open up the file: lib/Codestriker/TopicListeners/Email.pm and go to line 442, where you should see: $smtp->mail($from); Modify this code to read (substitute the strings with your actual username/password values). $smtp->auth('myusername', 'mypassword'); $smtp->mail($from); Let me know if that work or not. If it does, I'll modify codestriker.conf so that this extra mail config can be specified there. Cheers, David |
|
From: David S. <si...@us...> - 2006-03-22 22:29:19
|
Hi Hertz, I have to admit, this is something we haven't explicitly supported yet. I'd be keen to see some i18n support in there though. Can you email me the html you are receiving from the topic view screen? I'll have a look at it. Cheers, David Hertz Wang =CD=F5=BB=B3=D6=BE wrote: > Hi > =20 > I'd installed codestriker system, but all the chinese characters cannot= =20 > be displayed correctly, what should I do to support chinese characters? > =20 > Here is my configuration: > Windows 2000 Pro(Simplified Chinese Edition) > Apache 2.0.49 > PHP 4.3.5 > MySQL 4.0.18 > CodeStriker 1.9.2-alpha-2 > ActivePerl 5.8.7 > =20 > Thank you and best regards, > =20 > =20 > Hertz Wang =20 > =20 > =20 |
|
From: <wa...@ne...> - 2006-03-22 05:59:15
|
Hi All, I met another problem when try to use codestriker 1.9.2 Alpha2. When I create a new topic or add some comments, the mail notification doesn't work. this is the message I got, "5.7.0 No AUTH command has been given." My configration in codestriker.conf: $mailhost = 'pnmsmail.neusoft.com'; my mail server need authorization, how can I solve this problem? Thank you very much! Hertz Wang |
|
From: <wa...@ne...> - 2006-03-22 01:38:33
|
Hi I'd installed codestriker system, but all the chinese characters cannot be displayed correctly, what should I do to support chinese characters? Here is my configuration: Windows 2000 Pro(Simplified Chinese Edition) Apache 2.0.49 PHP 4.3.5 MySQL 4.0.18 CodeStriker 1.9.2-alpha-2 ActivePerl 5.8.7 Thank you and best regards, Hertz Wang |
|
From: Ananda T. <Ana...@Re...> - 2006-03-16 18:51:26
|
|
From: David S. <si...@us...> - 2006-03-15 22:58:26
|
Hi Chitra, > Can you point to oneclear doc that we ca use, we hv installed mysql,perl I know Codestriker is not the easiest thing in the world to install, however I know quite a few people have it up and running under Windows with IIS. Please read through the manual, in particular the "IIS configuration" section - http://codestriker.sourceforge.net/x289.html. I take it you have been able to run the install.pl script successfully? If you have any more specific questions, I am happy to help. Cheers, David |
|
From: Jason R. <jre...@ya...> - 2006-03-07 19:56:36
|
Hi, I believe that the code in question is in lib/codestriker/html/Render.pm. Because of the complexity of the diff rendering it is not controlled by a template. It should be easy to deal with this. If you make it generic, please consider sending David a patch. Thanks Jason. --- Jay Dickon Glanville <dic...@gm...> wrote: > Hello all. > > We're testing out CodeStriker and finding it useful. However, there > are one or two minor UI issues that we'd like to modify. The major > one is how the tables are laid out when viewing a topic. > > You see, the problem is that our file path names can be rather long > (over 120 characters). As the filename is part of the HTML table > showing the diffs in the topics, these long names can cause the table > to get completely out of proportion. Have a look at the table below: > > +--------------------------------------+---------+ > | /really/really/really/long/file/name | top | > +--+--------------------------------+--+---------+ > |09| code code code |09| mod code| > |10| code code code |10| mod code| > |11| code code code |11| mod code| > +--+--------------------------------+--+---------+ > > (I don't know if this will look right on your email reader, but if you > view it in mono-spaced font, it should be alright). > > What's happening is that the diffs table is split into 4 columns: > source line number and text, target line number and text. The > filename is told to span the first three columns. This causes the > third and forth columns to be pushed off the screen. > > If I could find the place in CodeStriker that generates the HTML for > the diff tables, then I'd like to make some minor modifications: > either push the filename outside of the table (on top, probably), or > to have the filename span 4 columns. > > Which module is responsible for generating the diff tables? Is there > a particular method I should be looking at? > > Thanks > > JDG > > > -- > Jay Dickon Glanville > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live webcast > and join the prime developer group breaking into this new coding territory! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com |
|
From: Jay D. G. <dic...@gm...> - 2006-03-07 18:54:39
|
Hello all. We're testing out CodeStriker and finding it useful. However, there are one or two minor UI issues that we'd like to modify. The major one is how the tables are laid out when viewing a topic. You see, the problem is that our file path names can be rather long (over 120 characters). As the filename is part of the HTML table showing the diffs in the topics, these long names can cause the table to get completely out of proportion. Have a look at the table below: +--------------------------------------+---------+ | /really/really/really/long/file/name | top | +--+--------------------------------+--+---------+ |09| code code code |09| mod code| |10| code code code |10| mod code| |11| code code code |11| mod code| +--+--------------------------------+--+---------+ (I don't know if this will look right on your email reader, but if you view it in mono-spaced font, it should be alright). What's happening is that the diffs table is split into 4 columns: source line number and text, target line number and text. The filename is told to span the first three columns. This causes the third and forth columns to be pushed off the screen. If I could find the place in CodeStriker that generates the HTML for the diff tables, then I'd like to make some minor modifications: either push the filename outside of the table (on top, probably), or to have the filename span 4 columns. Which module is responsible for generating the diff tables? Is there a particular method I should be looking at? Thanks JDG -- Jay Dickon Glanville |
|
From: Jason R. <jre...@ya...> - 2006-03-01 02:13:31
|
Hi, This is easy, just upload the entire file. It will see that it is not a diff and do the right thing. Thanks Jason --- Zodiac Seven <zod...@gm...> wrote: > I've been playing with CS and I want to use it in my organization for > tracking code reviews, the problem is that it insists on creating a > diff while creating a new topic, what I mean is that if you're just > starting off with implementing code reviews in your organization you > would want to code review an entire file and you would want to start > with the HEAD version. I noticed that I could see the entire file if I > clicked on the parallel view link but it would not let me put comments > on any lines not covered by the diff, any idea how I can get over > this? I'm using SubVersion. > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live webcast > and join the prime developer group breaking into this new coding territory! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com |
|
From: Zodiac S. <zod...@gm...> - 2006-02-28 18:25:59
|
I've been playing with CS and I want to use it in my organization for tracking code reviews, the problem is that it insists on creating a diff while creating a new topic, what I mean is that if you're just starting off with implementing code reviews in your organization you would want to code review an entire file and you would want to start with the HEAD version. I noticed that I could see the entire file if I clicked on the parallel view link but it would not let me put comments on any lines not covered by the diff, any idea how I can get over this? I'm using SubVersion. |
|
From: David S. <si...@us...> - 2006-02-08 02:31:38
|
Hi Frank, I don't understand what you are saying. When you obsolete topics from the topic list page, it takes you to the create topic page as you are obsoleting those selecting topics with the new one about to be created. When the new topic is created, that is when the nominated obsoleted topics will be marked as obsolete. Cheers, David Slicer, Frank W (Frank) wrote: > Does anyone understand why this would be happening? > > > > > When you go to the codestriker web page: > http: //someserver.cb.lucent.com/codestriker/codestriker.pl > > and click on the "Obsolete Topic(s)" button, it takes you to the "create new topic" page at the link > > http: //someserver.cb.lucent.com/codestriker/codestriker.pl?action=create&obsoletes= > > I went to http: //someserver.cb.lucent.com/codestriker/codestriker.pl?action=obsoletes > > and got what I was expecting. > > Thanks, > > Frank Slicer |
|
From: Slicer, F. W (Frank) <sl...@lu...> - 2006-02-06 19:41:13
|
Does anyone understand why this would be happening? When you go to the codestriker web page: http: //someserver.cb.lucent.com/codestriker/codestriker.pl and click on the "Obsolete Topic(s)" button, it takes you to the "create new topic" page at the link http: //someserver.cb.lucent.com/codestriker/codestriker.pl?action=create&obsoletes= I went to http: //someserver.cb.lucent.com/codestriker/codestriker.pl?action=obsoletes and got what I was expecting. Thanks, Frank Slicer |
|
From: David S. <si...@us...> - 2006-02-02 04:03:04
|
Hi Stephen, This sounds good to me - nobody has specifically talked about this before, but I can see why it would be useful occasionally. We should be able to achieve most of this hopefully through CSS. Cheers, David Stephen Morton wrote: > Has there been any discussion about producing diffs in a printable format? > > A few people around work have been asking me for the ability to > occasionally print diffs from codestriker. Of course the simple answer > is that you can using your browser's built in print function. It even > looks pretty good. But there are a few things that would make it more > "printer friendly". > I think this could be done without adding a whole printing module, > just adding a hyperlink to pages called something a bit shorter than > "printer friendly version". People could select this from a > multiple-file diff view or a single file diff view. It would simply > redisplay the current page with the following modifications: > > * Make the background pure white. (Diffs don't look much good with > all shading turned off, but it wastes a lot of toner to have > everything shaded in 10% grey. > * Removing excessive header and trailer information. > > I was going to work on this myself (because people here at work want it > anyway) and then submit proposed changes back to codestriker, but I > thought I'd check first to find out if this had been discussed before > and if there were strong philosophical views about this being a The > Wrong Thing To Do, or something. > > Let me know what you think, > > Stephen > |
|
From: Stephen M. <che...@gm...> - 2006-02-01 21:24:18
|
Has there been any discussion about producing diffs in a printable format?
A few people around work have been asking me for the ability to occasionall=
y
print diffs from codestriker. Of course the simple answer is that you can
using your browser's built in print function. It even looks pretty good. Bu=
t
there are a few things that would make it more "printer friendly".
I think this could be done without adding a whole printing module, just
adding a hyperlink to pages called something a bit shorter than "printer
friendly version". People could select this from a multiple-file diff view
or a single file diff view. It would simply redisplay the current page with
the following modifications:
- Make the background pure white. (Diffs don't look much good with all
shading turned off, but it wastes a lot of toner to have everything shad=
ed
in 10% grey.
- Removing excessive header and trailer information.
I was going to work on this myself (because people here at work want it
anyway) and then submit proposed changes back to codestriker, but I thought
I'd check first to find out if this had been discussed before and if there
were strong philosophical views about this being a The Wrong Thing To Do, o=
r
something.
Let me know what you think,
Stephen
|
|
From: Slicer, F. W (Frank) <sl...@lu...> - 2006-01-11 19:37:08
|
Codestriker users,
I have setup codestriker 1.9.1 ("out-of-the-box") on RH ES 3 Linux.
However, when I went back to "tweek" Codestriker.pm to change the metrics and reran the "./install.pl" the changes were not picked up.
Any suggestions?
Thanks,
Frank Slicer
Lucent Technologies
|
|
From: Jason R. <jre...@ya...> - 2005-12-19 04:12:24
|
Hi, --- "Bouwens, Jeroen" <jer...@at...> wrote: > Hello, > > >By default Codestriker topic will show not show the entire file unless you ask for you. > > Yes, but in the screenshots on the website the topic does show some part of the code surrounding > a change. In my case, all I get to see are the lines that actually changed, and that's it. When you make a topic from cvs, or a plain text file you can specify how much "context" is in the diff file. That context is shown in the topic. You may be able to find the same kind of option in clearcase. > > > I assume you are opening up the topic, and pressing the "parallel" button. > > Yes, that is correct. When I press "parallel", a new window opens which shows the line-numbering > of a sizable part of the file under review. Only the changed lines are shown, even though there > is line-numbering for the surrounding code (In my example, the change is 7 lines, and I see > line-numbers for lines 1-233) > > > Are you sure the retrieve function is not being called? > > Who knows. I placed a "print STDERR some message" at the top of the > ClearCaseSnapshot::retrieve() function, and the message never shows up in the apache log. Other > similar messages I sprinkled around the code do show up in the log. > Well, it sounds like it does not know you are using a clearcase repository. How is the repository configured, and how are you making the topic? > >The function makes an effort to collect any error message and dump it into the window. > > Nothing shows up in the error log. > > Would it help if I provide some screenshots? Create topic screen shot, and the repository part of your config file please. Thanks Jason. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com |
|
From: Bouwens, J. <jer...@at...> - 2005-12-15 11:29:42
|
Hello, =20 >By default Codestriker topic will show not show the entire file unless = you ask for you. =20 Yes, but in the screenshots on the website the topic does show some part = of the code surrounding a change. In my case, all I get to see are the = lines that actually changed, and that's it. =20 > I assume you are opening up the topic, and pressing the "parallel" = button. =20 Yes, that is correct. When I press "parallel", a new window opens which = shows the line-numbering of a sizable part of the file under review. = Only the changed lines are shown, even though there is line-numbering = for the surrounding code (In my example, the change is 7 lines, and I = see line-numbers for lines 1-233) =20 > Are you sure the retrieve function is not being called? =20 Who knows. I placed a "print STDERR some message" at the top of the = ClearCaseSnapshot::retrieve() function, and the message never shows up = in the apache log. Other similar messages I sprinkled around the code do = show up in the log. =20 >The function makes an effort to collect any error message and dump it = into the window. =20 Nothing shows up in the error log. Would it help if I provide some screenshots? =20 Thanks for your help! =20 Jeroen =20 =20 -----Original Message----- From: Jason Remillard [mailto:jre...@ya...] Sent: donderdag 15 december 2005 2:12 To: Bouwens, Jeroen; cod...@li... Subject: Re: [Codestriker-user] ClearCase Hi, Hi, Lets start off with the easy stuff.. By default Codestriker topic will show not show the entire file unless = you ask for you. I assume you are opening up the topic, and pressing the = "parallel" button. Are you sure the retrieve function is not being = called? The function makes an effort to collect any error message and = dump it into the window. Lastly, did you check your web server error = logs? Codestriker will often dump its error messages into the logs. Thanks Jason. "Bouwens, Jeroen" <jer...@at...> wrote:=20 Hello, I'm trying to get codestriker to work with ClearCase, and while it more = or less works, the review topics only show what's in the diff. As it = says in the Codestriker manual: "if a ClearCase repository has been specified in the Codestriker = configuration, it is important that the above commands are run from the = top-level directory of the view, so that the full vob pathname = information is available within the diff files. This allows Codestriker = to retrieve the full contents of files from the vob, so that a reviewer = can see the changes applied to an entire file, rather than a small = segment." I have specified a repository in the config file, and verified manually = that all versions are available to "cleartool get", yet all I get is = this "small segment" the manual mentions. I tried checking what the code = does, and it seems that ClearCaseSnapshot::retrieve is never called.=20 I'd be happy with any ideas of what to try to get this working, since = the context of a change in a file is necessary to make a review doable = at all. Thanks in advance, Jeroen Bouwens Software Engineer Atos Origin Technical Automation Veldhoven De Run 1121, 5503 LB Veldhoven Building HVO, room 4.01, The Netherlands email: jer...@at... phone: +31 (40) 258 60 10 fax: +31 (40) 253 73 13 ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log = files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick _______________________________________________ Codestriker-user mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codestriker-user _____ =20 Yahoo! Shopping Find Great Deals on Holiday Gifts at Yahoo! = <http://us.rd.yahoo.com/mail_us/footer/shopping/*http://shopping.yahoo.co= m/;_ylc=3DX3oDMTE2bzVzaHJtBF9TAzk1OTQ5NjM2BHNlYwNtYWlsdGFnBHNsawNob2xpZGF= 5LTA1> Shopping=20 |