codestriker-user — Discussion of any issue to do with Codestriker

[Codestriker-user] Attaching documentation to a topic

[<tom...@pr...>]

Hello,

Please forgive me if I missed this somewhere.

Is it possible to attach documents MS Word (or any other document type)
to a topic to show the specifications for the functions being reviewed?

We have specification documents written in MS Word format, I would like
to attach the specification document to the topic so that the reviewer
has the specification and code right there to review.

Is there another solution?

Thank you,

Tom.
----
Thomas J. Boyda
tom...@pr...
Consultant
Proxicom, Inc.
276-739-2314 (Desk)
www.proxicom.com

Re: [Codestriker-user] question on the general review workflow

[David S. <si...@us...>]

Moisei Rabinovich wrote:
> Hello dear all,
> I've setup the subversion hook to create a new topic in codestriker on 
> every commit and it works just fine.
> Now, I am looking for a god way to "link" the commits done based on the 
> review to the original topic.
> Is there some recommended way?
> 
> The scenario is like:
> developer commit some code [new topic created]
> the reviewer mention the problem in file X1 line Y1 and file X2 line Y2 
> [mails sent]
> the developer fixes the X1,Y1 and commits [new topic is created.... not 
> so good... it still relates to the origibal topic... should the original 
> one be obsoleted byt he new one?]

Yes, we need to somehow obsolete the original topic with the new topic. 
  This is easy to do if the topics are created "by hand", but via the 
SCM commit hook, we need to handle this in a different way.

I can see a couple of options here, which Jason has already eluded to:

* In the topic description, we could perhaps introduce another magical 
auto-link text, so that if you type in Topic 73514332, this would 
automatically hyperlink to that topic.  We actually do this with Bug 
XXXX text if a bug tracker has been enabled.

That way, the developer can add the Topic XXXXXXX text to their commit 
message, as a way of linking topics together.

They can actually do this today, just by adding a full hyperlink to the 
topic they are obsoleting, as Codestriker will render hyperlinks 
automatically.

* Another option would be to have a new field in the topic properties 
tab, something like "Superseeds Topics: XXXXXX", as a way of creating an 
obsolete link directly.  The onus would be on somebody to then update 
this field to maintain your links.

Does anyone else have any other ideas?

Cheers,
David

Re: [Codestriker-user] Subversion auto-topic creation hook

[David S. <si...@us...>]

Hi Moisei,

Would you mind sharing your script/instructions as to what you had to do 
to get topics created automatically with Subversion?

I'll add this to the manual and/or distribution.  I have done this 
already with CVS, as you are aware, but don't use Subversion yet, so I'd 
like to document this for the upcoming 1.9.2 release.  I'm sure lots of 
people would find this useful.

Cheers,
David

Moisei Rabinovich wrote:
> Hello dear all,
> I've setup the subversion hook to create a new topic in codestriker on 
> every commit and it works just fine.
> Now, I am looking for a god way to "link" the commits done based on the 
> review to the original topic.
> Is there some recommended way?
> 
> The scenario is like:
> developer commit some code [new topic created]
> the reviewer mention the problem in file X1 line Y1 and file X2 line Y2 
> [mails sent]
> the developer fixes the X1,Y1 and commits [new topic is created.... not 
> so good... it still relates to the origibal topic... should the original 
> one be obsoleted byt he new one?]
> 
> Please advise,
> -- 
> Best Regards,
> Moisei
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user

Re: [Codestriker-user] question on the general review workflow

[Jason R. <jre...@ya...>]

Hi,

The obsoleted feature is for this kind of thing. Really it depends on what you are using
codestriker for. It can be used to just keep an eye on things with an occasional comment added, to
a full blown inspection system with metrics and tracked resolutions for each comment. The fact
that you are creating topics with a hook suggests you are near the "keep an eye on things" side of
the spectrum, in which case it may not be worth the extra work to put the relationship between the
topics. We don't have a way of obsoleting topics automatically (though this could be added with
some changes to codestrker and check in comment discipline). Unless you are going to spend a lot
of time doing inspections and tracking comment resolutions it is probably not worth the worth to
obsoleting older topics.

However, it would help to have some more context on what you expect to get from codestriker. 

Thanks
Jason.

--- Moisei Rabinovich <mo...@gm...> wrote:

> Hello dear all,
> I've setup the subversion hook to create a new topic in codestriker on every
> commit and it works just fine.
> Now, I am looking for a god way to "link" the commits done based on the
> review to the original topic.
> Is there some recommended way?
> 
> The scenario is like:
> developer commit some code [new topic created]
> the reviewer mention the problem in file X1 line Y1 and file X2 line Y2
> [mails sent]
> the developer fixes the X1,Y1 and commits [new topic is created.... not so
> good... it still relates to the origibal topic... should the original one be
> obsoleted byt he new one?]
> 
> Please advise,
> -- 
> Best Regards,
> Moisei
> > > _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

[Codestriker-user] question on the general review workflow

[Moisei R. <mo...@gm...>]

Hello dear all,
I've setup the subversion hook to create a new topic in codestriker on every
commit and it works just fine.
Now, I am looking for a god way to "link" the commits done based on the
review to the original topic.
Is there some recommended way?

The scenario is like:
developer commit some code [new topic created]
the reviewer mention the problem in file X1 line Y1 and file X2 line Y2
[mails sent]
the developer fixes the X1,Y1 and commits [new topic is created.... not so
good... it still relates to the origibal topic... should the original one be
obsoleted byt he new one?]

Please advise,
-- 
Best Regards,
Moisei

Re: [Codestriker-user] maximum length of reviewers list

[David S. <si...@us...>]

Hi Giuseppe,

We might as well make this a very big number, such as 1024, so we don't 
ever hit this limit in practice.  The database schema is certainly not a 
limiting factor here, and the UI won't change in appearance either.

I'll commit your change into CVS, with a value of 1024.  Thanks for the 
report.  I'll also update the create topic page as well.

Cheers,
David

Giuseppe Scelsi wrote:
> Hi all,
> 
> One of my reviewers lists has hit the maximum length accepted in CS
> 1.9.2 alpha 5.  Both the "add topic" "add comment" dialogs don't allow
> more than 150 characters and that fits roughly 5 email addresses.  It
> was easy enough to work around this limitation by modifying two files as
> per attached patch, however this might be something that could warrant
> the use of a configuration variable rather than being controlled by
> hardcoded magic number.
> 
> Cheers,
> 
> Giuseppe
> 
> 
> 
> ------------------------------------------------------------------------
> 
> --- ./html/codestriker.js_ORIG	2006-06-15 15:18:09.970165824 +1000
> +++ ./html/codestriker.js	2006-06-15 15:18:20.274599312 +1000
> @@ -217,7 +217,7 @@
>              '(add other reviewers)</a></font> </td>' +
>              '<td>' +
>  	    '<input type="text" name="comment_cc" size="25" ' +
> -                    'maxlength="150"></td>\n' +
> +                    'maxlength="300"></td>\n' +
>              '<td><input type="submit" name="submit" value="Submit"></td>' +
>              '</tr></table></form></body></html>\n';
> 
> --- ./template/en/default/viewtopicproperties.html.tmpl_ORIG	2006-06-15 15:42:55.703300056 +1000
> +++ ./template/en/default/viewtopicproperties.html.tmpl	2006-06-15 15:26:17.001125864 +1000
> @@ -95,7 +95,7 @@
>    <td>Reviewers:</td>
>    <td>
>      <input type="text" name="reviewers" value="[% reviewers | html_entity %]"
> -           size="50" maxlength="150"
> +           size="50" maxlength="300"
>    	   [%# Check to see if the topic is open or not #%]
>  	   [% IF antispam_email || topic_readonly != 0 %]readonly[% END %] />
>    </td>
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user

Re: [Codestriker-user] Updating the set of comment state metrics

[Mark K. <Mar...@mo...>]

I'm interested in what you added, Vlad.  I'd also like the fix you did, 
David :).  I have a request from a user to add Major, Minor, and Trivial 
states to comments a la Fagan Process.

David Sitsky wrote:
> Hi Vlad,
> 
> Yes, this was a bug.  With 1.9.1, new topics would be able to use your 
> new comment_state_metrics definitions, but not existings ones.
> 
> I have just committed the fix into CVS.  It was a minor change in 
> Comment.pm, which I'll email to you.  In general, with changing 
> comment_state_metrics, there is no need to re-run install.pl, it should 
> all just work automatically.
> 
> Cheers,
> David
> 
> Vysotsky, Vladimir wrote:
>> After using Codesrtiker for a while, I've decided to edit 
>> codestriker.conf and add
>> one new entry in $comment_state_metrics. The UI picked the change right
>> away, but wouldn't let me change the value of the new new metric for any 
>> comment.
>> The Topic Information page showed zeroes for all categories of the new 
>> metric.
>>  
>> Running install.pl didn't help. After some poking around in the the code I
>> was able to fix the problem by running the following statement in MySQL:
>>  
>> insert into commentstatemetric
>> select distinct id, <new metric name>, <new metric default value> from 
>> commentstatemetric;
>>  
>> Is there a better way to update the set of comment state metrics once
>> the database has been initialized? (I'm using 1.9.1) Would it make sense
>> to put this logic in install.pl?
>>  
>> -- Vlad
> 
> 
> 
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user

-- 
Mark Keisler
Motorola Open Source Technologies
480-732-2495

Re: [Codestriker-user] Updating the set of comment state metrics

[David S. <si...@us...>]

Hi Vlad,

Yes, this was a bug.  With 1.9.1, new topics would be able to use your 
new comment_state_metrics definitions, but not existings ones.

I have just committed the fix into CVS.  It was a minor change in 
Comment.pm, which I'll email to you.  In general, with changing 
comment_state_metrics, there is no need to re-run install.pl, it should 
all just work automatically.

Cheers,
David

Vysotsky, Vladimir wrote:
> After using Codesrtiker for a while, I've decided to edit 
> codestriker.conf and add
> one new entry in $comment_state_metrics. The UI picked the change right
> away, but wouldn't let me change the value of the new new metric for any 
> comment.
> The Topic Information page showed zeroes for all categories of the new 
> metric.
>  
> Running install.pl didn't help. After some poking around in the the code I
> was able to fix the problem by running the following statement in MySQL:
>  
> insert into commentstatemetric
> select distinct id, <new metric name>, <new metric default value> from 
> commentstatemetric;
>  
> Is there a better way to update the set of comment state metrics once
> the database has been initialized? (I'm using 1.9.1) Would it make sense
> to put this logic in install.pl?
>  
> -- Vlad

[Codestriker-user] Updating the set of comment state metrics

[Vysotsky, V. <vvy...@av...>]

After using Codesrtiker for a while, I've decided to edit
codestriker.conf and add
one new entry in $comment_state_metrics. The UI picked the change right
away, but wouldn't let me change the value of the new new metric for any
comment.
The Topic Information page showed zeroes for all categories of the new
metric.
=20
Running install.pl didn't help. After some poking around in the the code
I
was able to fix the problem by running the following statement in MySQL:
=20
insert into commentstatemetric
select distinct id, <new metric name>, <new metric default value> from
commentstatemetric;
=20
Is there a better way to update the set of comment state metrics once
the database has been initialized? (I'm using 1.9.1) Would it make sense
to put this logic in install.pl?
=20
-- Vlad
=20

Re: [Codestriker-user] forcing reviewers in the cc list

[David S. <si...@us...>]

Hi Giuseppe,

> When a new comment is added to a line, the current behaviour is to
> notify only people who have already submitted a comment for the same
> line, or that have been manually added to the cc list in the "add
> comment" dialog.  As far as I can tell, reviewers are only automatically
> notified of topic state changes, not of added messages.
> 
> Unless there is already a way of doing this that I have missed, it would
> be helpful to have a global configuration option, or maybe a topic-level
> option, to force notifications to always go to all people registered as
> reviewers.  Any comments?

I can imagine why that would be useful in some situations.  I'm sure you 
have seen the $email_send_options parameter in codestriker.conf.  It 
shouldn't be too difficult to add a comments_sent_to_reviewers 
sub-parameter here, defaulted to 0.

It shouldn't be too difficult to add this in, I'll add it to my list, 
unless you want a crack at implementing it?  You'd need to modify 
lib/Codestriker/TopicListeners/Email::comment_create().

Cheers,
David

Re: [Codestriker-user] Creating CVS Diff Topics Automatically

[David S. <si...@us...>]

Hi Fred,

Fred Moye wrote:
> I'm running Codestriker 1.9.1, CVSNT, Bugzilla and Apache on Windows XP and I'm having problems getting Codestriker to automatically create Diff Topics.  I've followed the instructions in the manual but no luck.  I don't see any errors messages in the Apache log or Windows event viewer.  When I check in a file everything works fine with CVS and Bugzilla but it seems nothing happens at all with Codestriker.  If anyone has been able to get the automatic topic generation working on Windows XP can you let me know how you did it?  Or if anyone else has some suggestions.  Thanks.

I haven't tried using this part of the system on a Windows box.  The 
log_accum.pl and commit_prep.pl scripts were originally derived from 
CVS's contrib module, and on quick inspection, they are very UNIX 
specific (they call sendmail directly, rather than using the preferred 
platform independent Net::SMTP module, and reference /tmp for temporary 
files rather than using tempfile(), etc etc).

We'd ideally need to find an updated version of these scripts that are 
windows (platform independent) friendly, or perhaps hack these scripts 
yourself to make them work.

If you can find more updated versions of these files that run on 
windows, I can modify them with the Codestriker-specific parts to them. 
  Hopefully somebody out there has done this work already.

I'll add a note to the manual in the meantime to indicate that automatic 
topic creation of CVS commits is only supported on UNIX machines.

Cheers,
David

[Codestriker-user] Creating CVS Diff Topics Automatically

[Fred M. <mo...@mi...>]

I'm running Codestriker 1.9.1, CVSNT, Bugzilla and Apache on Windows XP =
and I'm having problems getting Codestriker to automatically create Diff =
Topics.  I've followed the instructions in the manual but no luck.  I =
don't see any errors messages in the Apache log or Windows event viewer.  =
When I check in a file everything works fine with CVS and Bugzilla but it =
seems nothing happens at all with Codestriker.  If anyone has been able to =
get the automatic topic generation working on Windows XP can you let me =
know how you did it?  Or if anyone else has some suggestions.  Thanks.

Fred Moye
Department of Information Technology
Michigan State Police
517-336-6412

"Fermentation and civilization are inseparable." - John Ciardi, Poet

[Codestriker-user] forcing reviewers in the cc list

[Giuseppe S. <giu...@an...>]

Hi all,

I am using 1.9.2-alpha-5 and was wandering if anyone else has the need
to force notifications for all added comments to be emailed to
reviewers.

When a new comment is added to a line, the current behaviour is to
notify only people who have already submitted a comment for the same
line, or that have been manually added to the cc list in the "add
comment" dialog.  As far as I can tell, reviewers are only automatically
notified of topic state changes, not of added messages.

Unless there is already a way of doing this that I have missed, it would
be helpful to have a global configuration option, or maybe a topic-level
option, to force notifications to always go to all people registered as
reviewers.  Any comments?

Giuseppe

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[<wa...@ne...>]

Hi David,

Thank you for you help!

I had changed the codestrikerdb database/table/field charset to utf8, =
ascii
and gb2312, the results were same. The Chinese characters are supported =
when
uploading topic file, but not supported when comparing 2 different
revisions. I checked database content, there is no different when I =
switch
different charset.

I guess there might be something wrong while inserting the comparison =
result
to topic or delta table, it's not database charset problem.

I attached 2 cvs diff result, hope it helpful for you.

Have a nice trip! Hope you can come to China, I will host you with open
arms.=20

Hertz


-----Original Message-----
From: David Sitsky [mailto:si...@us...]=20
Sent: 2006=C4=EA5=D4=C231=C8=D5 7:22
To: Hertz Wang =CD=F5=BB=B3=D6=BE
Cc: cod...@li...
Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version

> Thank you for your so quick improvement! I downloaded and tried it=20
> again, it works fine when I upload topic text, all the Chinese=20
> characters are rendered correctly, but it doesn't work when I compare=20
> 2 different cvs version, all the Chinese characters are still not =
right.

This is an interesting question actually - when you do a CVS diff, what
encoding is the text output as?  Is it gb2312 or is it utf8?  Perhaps if =
you
can email me an example diff, that would be helpful.

Cheers,
David

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[<wa...@ne...>]

Hi David

Some information for you,

I changed the :utf8 to :gb2312 in SubmitNewTopic.pm file(line 191, 192)

191  	binmode $temp_topic_fh, ':gb2312';
192  	binmode $temp_error_fh, ':gb2312';

Now the cvs diff can be displayed correctly.

it's a hard-coded solution, maybe you can think how to change this in =
your
code.

Ps. Adding Chinese comments are still not supported, always stop on
"receiving response..." step, and the comments cannot be put into the
database.

Hertz


-----Original Message-----
From: David Sitsky [mailto:si...@us...]=20
Sent: 2006=C4=EA5=D4=C231=C8=D5 7:22
To: Hertz Wang =CD=F5=BB=B3=D6=BE
Cc: cod...@li...
Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version

> Thank you for your so quick improvement! I downloaded and tried it=20
> again, it works fine when I upload topic text, all the Chinese=20
> characters are rendered correctly, but it doesn't work when I compare=20
> 2 different cvs version, all the Chinese characters are still not =
right.

This is an interesting question actually - when you do a CVS diff, what
encoding is the text output as?  Is it gb2312 or is it utf8?  Perhaps if =
you
can email me an example diff, that would be helpful.

Cheers,
David

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[David S. <si...@us...>]

> Thank you for your so quick improvement! I downloaded and tried it again, it
> works fine when I upload topic text, all the Chinese characters are rendered
> correctly, but it doesn't work when I compare 2 different cvs version, all
> the Chinese characters are still not right.

This is an interesting question actually - when you do a CVS diff, what
encoding is the text output as?  Is it gb2312 or is it utf8?  Perhaps if
you can email me an example diff, that would be helpful.

Cheers,
David

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[David S. <si...@us...>]

I need to still update the user documentation on the creation of
databases.  For mysql, your create database statement needs to be
something like:

CREATE DATABASE codestrikerdb CHARACTER SET utf8

All the text fields in the database should be stored as utf8 text, not
gb2312, otherwise we will run into problems.

I'd suggest deleting your database, and creating it again with the above
setting, and try again.

I will be away for a week from tomorrow, but back again next Wednesday.

Cheers,
David

Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
> Hi David,
>=20
> Thank you for your so quick improvement! I downloaded and tried it agai=
n, it
> works fine when I upload topic text, all the Chinese characters are ren=
dered
> correctly, but it doesn't work when I compare 2 different cvs version, =
all
> the Chinese characters are still not right.
>=20
> Here is my configuration,
> Apache 2.0
> ActivePerl 5.8.8.817
> MySQL 5.0.12
> Version control system - CVS
> CodeStriker 1.9.2 alpha7(change the $topic_text_encoding to gb2312, cha=
nge
> email.pm to support email authorization)
>=20
> I went through the database and found the content in the document field=
 in
> the topic table is not correct(for displaying Chinese character), I am =
not
> sure it is mysql bug or my setting error. I set the charset for each te=
xt
> field to gb2312, I'll change to some other charset see what happened.
>=20
> it still doesn't work when email comments(stop receiving response, same=
 as
> before).=20
>=20
> Best regards,
>=20
> Hertz
>=20
> -----Original Message-----
> From: David Sitsky [mailto:si...@us...]=20
> Sent: 2006=C4=EA5=D4=C230=C8=D5 15:24
> To: Hertz Wang =CD=F5=BB=B3=D6=BE
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version
>=20
> Hi Hertz,
>=20
> Try downloading codestriker-1.9.2-alpha-7 now.  There is a new configur=
ation
> variable $topic_text_encoding (which defaults to utf8 if it is not set)=
,
> which in your case, you should set to 'gb2312'.  Once I did that, the s=
ource
> files you sent me were rendered correctly, and the emailed comments wer=
e
> also rendered right.
>=20
> Please download it and let me know how you go.
>=20
> Cheers,
> David
>=20
> Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
>> Hi David,
>>
>> In China, we use GB2312 to encode text(simplified Chinese), for=20
>> Traditional Chinese, I think it's BIG5, I'll check it again and tell y=
ou
> later.
>> Hertz
>>
>> -----Original Message-----
>> From: cod...@li...
>> [mailto:cod...@li...] On Behalf Of=20
>> David Sitsky
>> Sent: 2006=C4=EA5=D4=C230=C8=D5 7:23
>> To: Hertz Wang =CD=F5=BB=B3=D6=BE
>> Cc: cod...@li...
>> Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version
>>
>> Hi Hertz,
>>
>> Thanks for your email.  Yes, one of the last issues to handle is the=20
>> actual topic text itself, when it is not ISO-8859-1.  I am working on=20
>> these issues now, this also explains why adding the comment is not=20
>> working, as the email contains non ISO-8859-1 text when displaying the
> source code lines.
>> I'm working on these issues next.
>>
>> Just out of interest, what character encoding are your source code fil=
es
> in?
>> Cheers,
>> David
>>
>> Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
>>> Hi David,
>>>
>>> =20
>>>
>>> I tried Unicode version and found it's great ^_^, I can now input=20
>>> Chinese characters in the topics and comments, it's very convenient=20
>>> for us. And I also found the following issues in the Unicode version,
>>>
>>> =20
>>>
>>> 1. the comments in the code doesn't support Chinese, they are=20
>>> replaced by question marks. =A1=B0?=A1=B1
>>>
>>> =20
>>>
>>> 2. email notification doesn't work when adding a comment, but it=20
>>> works fine when creating a topic.
>>>
>>> =20
>>>
>>> It always stops here. When I run it in the server, it prompt the=20
>>> object is null, the code is in the line 412 in=20
>>> codestrikerhtml\codestriker.cs file, the response is null.
>>>
>>> =20
>>>
>>> Thank you and best regards,
>>>
>>> =20
>>>
>>> Hertz
>>>
>>> =20
>>>
>>> =20
>>>
>>
>>
>>
>>
>=20
>=20
>=20
>=20
>=20
> -----------------------------------------------------------------------=
-
>=20
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[<wa...@ne...>]

Hi David,

Thank you for your so quick improvement! I downloaded and tried it =
again, it
works fine when I upload topic text, all the Chinese characters are =
rendered
correctly, but it doesn't work when I compare 2 different cvs version, =
all
the Chinese characters are still not right.

Here is my configuration,
Apache 2.0
ActivePerl 5.8.8.817
MySQL 5.0.12
Version control system - CVS
CodeStriker 1.9.2 alpha7(change the $topic_text_encoding to gb2312, =
change
email.pm to support email authorization)

I went through the database and found the content in the document field =
in
the topic table is not correct(for displaying Chinese character), I am =
not
sure it is mysql bug or my setting error. I set the charset for each =
text
field to gb2312, I'll change to some other charset see what happened.

it still doesn't work when email comments(stop receiving response, same =
as
before).=20

Best regards,

Hertz

-----Original Message-----
From: David Sitsky [mailto:si...@us...]=20
Sent: 2006=C4=EA5=D4=C230=C8=D5 15:24
To: Hertz Wang =CD=F5=BB=B3=D6=BE
Cc: cod...@li...
Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version

Hi Hertz,

Try downloading codestriker-1.9.2-alpha-7 now.  There is a new =
configuration
variable $topic_text_encoding (which defaults to utf8 if it is not set),
which in your case, you should set to 'gb2312'.  Once I did that, the =
source
files you sent me were rendered correctly, and the emailed comments were
also rendered right.

Please download it and let me know how you go.

Cheers,
David

Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
> Hi David,
>=20
> In China, we use GB2312 to encode text(simplified Chinese), for=20
> Traditional Chinese, I think it's BIG5, I'll check it again and tell =
you
later.
>=20
> Hertz
>=20
> -----Original Message-----
> From: cod...@li...
> [mailto:cod...@li...] On Behalf Of=20
> David Sitsky
> Sent: 2006=C4=EA5=D4=C230=C8=D5 7:23
> To: Hertz Wang =CD=F5=BB=B3=D6=BE
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version
>=20
> Hi Hertz,
>=20
> Thanks for your email.  Yes, one of the last issues to handle is the=20
> actual topic text itself, when it is not ISO-8859-1.  I am working on=20
> these issues now, this also explains why adding the comment is not=20
> working, as the email contains non ISO-8859-1 text when displaying the
source code lines.
>=20
> I'm working on these issues next.
>=20
> Just out of interest, what character encoding are your source code =
files
in?
>=20
> Cheers,
> David
>=20
> Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
>> Hi David,
>>
>> =20
>>
>> I tried Unicode version and found it's great ^_^, I can now input=20
>> Chinese characters in the topics and comments, it's very convenient=20
>> for us. And I also found the following issues in the Unicode version,
>>
>> =20
>>
>> 1. the comments in the code doesn't support Chinese, they are=20
>> replaced by question marks. =A1=B0?=A1=B1
>>
>> =20
>>
>> 2. email notification doesn't work when adding a comment, but it=20
>> works fine when creating a topic.
>>
>> =20
>>
>> It always stops here. When I run it in the server, it prompt the=20
>> object is null, the code is in the line 412 in=20
>> codestrikerhtml\codestriker.cs file, the response is null.
>>
>> =20
>>
>> Thank you and best regards,
>>
>> =20
>>
>> Hertz
>>
>> =20
>>
>> =20
>>
>=20
>=20
>=20
>=20
>=20

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[David S. <si...@us...>]

Hi Hertz,

Try downloading codestriker-1.9.2-alpha-7 now.  There is a new
configuration variable $topic_text_encoding (which defaults to utf8 if
it is not set), which in your case, you should set to 'gb2312'.  Once I
did that, the source files you sent me were rendered correctly, and the
emailed comments were also rendered right.

Please download it and let me know how you go.

Cheers,
David

Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
> Hi David,
>=20
> In China, we use GB2312 to encode text(simplified Chinese), for Traditi=
onal
> Chinese, I think it's BIG5, I'll check it again and tell you later.
>=20
> Hertz
>=20
> -----Original Message-----
> From: cod...@li...
> [mailto:cod...@li...] On Behalf Of Da=
vid
> Sitsky
> Sent: 2006=C4=EA5=D4=C230=C8=D5 7:23
> To: Hertz Wang =CD=F5=BB=B3=D6=BE
> Cc: cod...@li...
> Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version
>=20
> Hi Hertz,
>=20
> Thanks for your email.  Yes, one of the last issues to handle is the ac=
tual
> topic text itself, when it is not ISO-8859-1.  I am working on these is=
sues
> now, this also explains why adding the comment is not working, as the e=
mail
> contains non ISO-8859-1 text when displaying the source code lines.
>=20
> I'm working on these issues next.
>=20
> Just out of interest, what character encoding are your source code file=
s in?
>=20
> Cheers,
> David
>=20
> Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
>> Hi David,
>>
>> =20
>>
>> I tried Unicode version and found it's great ^_^, I can now input=20
>> Chinese characters in the topics and comments, it's very convenient=20
>> for us. And I also found the following issues in the Unicode version,
>>
>> =20
>>
>> 1. the comments in the code doesn't support Chinese, they are replaced=
=20
>> by question marks. =A1=B0?=A1=B1
>>
>> =20
>>
>> 2. email notification doesn't work when adding a comment, but it works=
=20
>> fine when creating a topic.
>>
>> =20
>>
>> It always stops here. When I run it in the server, it prompt the=20
>> object is null, the code is in the line 412 in=20
>> codestrikerhtml\codestriker.cs file, the response is null.
>>
>> =20
>>
>> Thank you and best regards,
>>
>> =20
>>
>> Hertz
>>
>> =20
>>
>> =20
>>
>=20
>=20
>=20
>=20
>=20

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[<wa...@ne...>]

Hi David,

In China, we use GB2312 to encode text(simplified Chinese), for =
Traditional
Chinese, I think it's BIG5, I'll check it again and tell you later.

Hertz

-----Original Message-----
From: cod...@li...
[mailto:cod...@li...] On Behalf Of =
David
Sitsky
Sent: 2006=C4=EA5=D4=C230=C8=D5 7:23
To: Hertz Wang =CD=F5=BB=B3=D6=BE
Cc: cod...@li...
Subject: Re: [Codestriker-user] Issues in the 1.9.2 unicode version

Hi Hertz,

Thanks for your email.  Yes, one of the last issues to handle is the =
actual
topic text itself, when it is not ISO-8859-1.  I am working on these =
issues
now, this also explains why adding the comment is not working, as the =
email
contains non ISO-8859-1 text when displaying the source code lines.

I'm working on these issues next.

Just out of interest, what character encoding are your source code files =
in?

Cheers,
David

Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
> Hi David,
>=20
> =20
>=20
> I tried Unicode version and found it's great ^_^, I can now input=20
> Chinese characters in the topics and comments, it's very convenient=20
> for us. And I also found the following issues in the Unicode version,
>=20
> =20
>=20
> 1. the comments in the code doesn't support Chinese, they are replaced =

> by question marks. =A1=B0?=A1=B1
>=20
> =20
>=20
> 2. email notification doesn't work when adding a comment, but it works =

> fine when creating a topic.
>=20
> =20
>=20
> It always stops here. When I run it in the server, it prompt the=20
> object is null, the code is in the line 412 in=20
> codestrikerhtml\codestriker.cs file, the response is null.
>=20
> =20
>=20
> Thank you and best regards,
>=20
> =20
>=20
> Hertz
>=20
> =20
>=20
> =20
>=20

Re: [Codestriker-user] Issues in the 1.9.2 unicode version

[David S. <si...@us...>]

Hi Hertz,

Thanks for your email.  Yes, one of the last issues to handle is the
actual topic text itself, when it is not ISO-8859-1.  I am working on
these issues now, this also explains why adding the comment is not
working, as the email contains non ISO-8859-1 text when displaying the
source code lines.

I'm working on these issues next.

Just out of interest, what character encoding are your source code files =
in?

Cheers,
David

Hertz Wang =CD=F5=BB=B3=D6=BE wrote:
> Hi David,
>=20
> =20
>=20
> I tried Unicode version and found it's great ^_^, I can now input=20
> Chinese characters in the topics and comments, it's very convenient for=
=20
> us. And I also found the following issues in the Unicode version,
>=20
> =20
>=20
> 1. the comments in the code doesn't support Chinese, they are replaced=20
> by question marks. =A1=B0?=A1=B1
>=20
> =20
>=20
> 2. email notification doesn't work when adding a comment, but it works=20
> fine when creating a topic.
>=20
> =20
>=20
> It always stops here. When I run it in the server, it prompt the object=
=20
> is null, the code is in the line 412 in codestrikerhtml\codestriker.cs=20
> file, the response is null.
>=20
> =20
>=20
> Thank you and best regards,
>=20
> =20
>=20
> Hertz
>=20
> =20
>=20
> =20
>=20

Re: [Codestriker-user] Sorted list of files in a topic.

[David S. <si...@us...>]

Sure.. my only concern was the use case where somebody might assemble 
the topic text "by hand" in a specific order, which we would then override.

But perhaps this is a pretty obscure use case (I've never done it).  Its 
actually interesting Subversion doesn't produce the files in sorted 
order, as I believe CVS diffs are.

Ok - if nobody has an objections, I'll commit Vlad's code in.

Cheers,
David

Jason Remillard wrote:
> Hi,
> 
> How about it just sorts it all of the time given that the order that svn returns the files really
> does not have any meaning.
> 
> Thanks
> Jason
> 
> --- David Sitsky <si...@us...> wrote:
> 
>> Hi Vlad,
>>
>>> I'm creating topics directly from Subversion. One problem I've noticed
>>> immediately
>>> is that file list in a topic is not sorted by filename. Instead, files
>>> are listed in some
>>> semi-sorted order defined by Subversion. I couldn't find any
>>> configuration options
>>> that would trigger file sorting. Did I miss something?
>> The order the files are presented is the same as that in the text 
>> uploaded into Codestriker, or the order obtained from the SCM, in your 
>> case, Subversion.  So no, you didn't miss anything.
>>
>>> Patching the code to sort by filename was rather trivial: in
>>> lib\Codestriker\FileParser\Parser.pm,
>>> insert just before the first return:
>>>
>>>     # Sort the diff chunks by filename, then old linenumber
>>>     @diffs = sort { $a->{filename} cmp $b->{filename} ||
>>> $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
>>>  
>>> Would it make sense to make this a configurable feature?
>> I can imagine this could be useful for large reviews.  Rather than 
>> making this a configurable feature (codestriker.conf is also quite large 
>> and complex), it might be useful to have a link instead on the view 
>> topic page above the list of files, for example:
>>
>> Download topic text | ... | Tab width ... | Sort by filename
>>
>> Clicking on the sort by filename link will set a CGI parameter, which 
>> will then execute code similar to what you have, but this would be in 
>> ViewTopic.pm over the list of delta objects.  That way, a reviewer can 
>> choose at runtime which way they'd prefer to see the list of files 
>> presented.
>>
>> What do you think?
>>
>> Cheers,
>> David
>>
>>
>>
>> -------------------------------------------------------
>> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
>> Fully trained technicians. The highest number of Red Hat certifications in
>> the hosting industry. Fanatical Support. Click to learn more
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
>> _______________________________________________
>> Codestriker-user mailing list
>> Cod...@li...
>> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>>
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around 
> http://mail.yahoo.com 
> 
> 
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
> 

RE: [Codestriker-user] Sorted list of files in a topic.

[Vysotsky, V. <vvy...@av...>]

File list could get sorted:

- through a link/CGI option in ViewTopic.pm (as suggested by David)
- unconditionally on import (as suggested by Jason), or
- conditionally on import, by providing a checkbox "Sort files by name"
in CreateTopic/SubmitNewTopic.

-- Vlad

PS. I actually tried three ways to sort the list:

1) Sort the files in the UI - I couldn't find an easy way to do this.
But for me,
this would be a perfectly acceptable option.

2) Sort the files when retrieving them from the database (in
Codestriker/Model/File.pm, get_filetable
change the SQL statement to "... ORDER BY filename, sequence".) This
didn't quite work, because
the UI expects the file list to be sorted by sequence and fails to
generate the page correctly
otherwise. Is this a bug?

3) Sort the files when importing the diff, as described in my previous
email. This worked for me.


-----Original Message-----
From: Jason Remillard [mailto:jre...@ya...]=20
Sent: Thursday, May 25, 2006 7:56 AM
To: David Sitsky; Vysotsky, Vladimir
Cc: cod...@li...
Subject: Re: [Codestriker-user] Sorted list of files in a topic.

Hi,

How about it just sorts it all of the time given that the order that svn
returns the files really does not have any meaning.

Thanks
Jason

--- David Sitsky <si...@us...> wrote:

> Hi Vlad,
>=20
> > I'm creating topics directly from Subversion. One problem I've=20
> > noticed immediately is that file list in a topic is not sorted by=20
> > filename. Instead, files are listed in some semi-sorted order=20
> > defined by Subversion. I couldn't find any configuration options=20
> > that would trigger file sorting. Did I miss something?
>=20
> The order the files are presented is the same as that in the text=20
> uploaded into Codestriker, or the order obtained from the SCM, in your

> case, Subversion.  So no, you didn't miss anything.
>=20
> > Patching the code to sort by filename was rather trivial: in=20
> > lib\Codestriker\FileParser\Parser.pm,
> > insert just before the first return:
> >=20
> >     # Sort the diff chunks by filename, then old linenumber
> >     @diffs =3D sort { $a->{filename} cmp $b->{filename} ||=20
> > $a->{old_linenumber} <=3D> $b->{old_linenumber} } @diffs;
> > =20
> > Would it make sense to make this a configurable feature?
>=20
> I can imagine this could be useful for large reviews.  Rather than=20
> making this a configurable feature (codestriker.conf is also quite=20
> large and complex), it might be useful to have a link instead on the=20
> view topic page above the list of files, for example:
>=20
> Download topic text | ... | Tab width ... | Sort by filename
>=20
> Clicking on the sort by filename link will set a CGI parameter, which=20
> will then execute code similar to what you have, but this would be in=20
> ViewTopic.pm over the list of delta objects.  That way, a reviewer can

> choose at runtime which way they'd prefer to see the list of files=20
> presented.
>=20
> What do you think?
>=20
> Cheers,
> David
>=20
>=20
>=20
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and
Risk!
> Fully trained technicians. The highest number of Red Hat=20
> certifications in the hosting industry. Fanatical Support. Click to=20
> learn more
> =
http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D107521&bid=3D248729&dat=3D=
1216
> 42 _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>=20


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around
http://mail.yahoo.com=20

Re: [Codestriker-user] Sorted list of files in a topic.

[Jason R. <jre...@ya...>]

Hi,

How about it just sorts it all of the time given that the order that svn returns the files really
does not have any meaning.

Thanks
Jason

--- David Sitsky <si...@us...> wrote:

> Hi Vlad,
> 
> > I'm creating topics directly from Subversion. One problem I've noticed
> > immediately
> > is that file list in a topic is not sorted by filename. Instead, files
> > are listed in some
> > semi-sorted order defined by Subversion. I couldn't find any
> > configuration options
> > that would trigger file sorting. Did I miss something?
> 
> The order the files are presented is the same as that in the text 
> uploaded into Codestriker, or the order obtained from the SCM, in your 
> case, Subversion.  So no, you didn't miss anything.
> 
> > Patching the code to sort by filename was rather trivial: in
> > lib\Codestriker\FileParser\Parser.pm,
> > insert just before the first return:
> > 
> >     # Sort the diff chunks by filename, then old linenumber
> >     @diffs = sort { $a->{filename} cmp $b->{filename} ||
> > $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
> >  
> > Would it make sense to make this a configurable feature?
> 
> I can imagine this could be useful for large reviews.  Rather than 
> making this a configurable feature (codestriker.conf is also quite large 
> and complex), it might be useful to have a link instead on the view 
> topic page above the list of files, for example:
> 
> Download topic text | ... | Tab width ... | Sort by filename
> 
> Clicking on the sort by filename link will set a CGI parameter, which 
> will then execute code similar to what you have, but this would be in 
> ViewTopic.pm over the list of delta objects.  That way, a reviewer can 
> choose at runtime which way they'd prefer to see the list of files 
> presented.
> 
> What do you think?
> 
> Cheers,
> David
> 
> 
> 
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: [Codestriker-user] Sorted list of files in a topic.

[David S. <si...@us...>]

Hi Vlad,

> I'm creating topics directly from Subversion. One problem I've noticed
> immediately
> is that file list in a topic is not sorted by filename. Instead, files
> are listed in some
> semi-sorted order defined by Subversion. I couldn't find any
> configuration options
> that would trigger file sorting. Did I miss something?

The order the files are presented is the same as that in the text 
uploaded into Codestriker, or the order obtained from the SCM, in your 
case, Subversion.  So no, you didn't miss anything.

> Patching the code to sort by filename was rather trivial: in
> lib\Codestriker\FileParser\Parser.pm,
> insert just before the first return:
> 
>     # Sort the diff chunks by filename, then old linenumber
>     @diffs = sort { $a->{filename} cmp $b->{filename} ||
> $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
>  
> Would it make sense to make this a configurable feature?

I can imagine this could be useful for large reviews.  Rather than 
making this a configurable feature (codestriker.conf is also quite large 
and complex), it might be useful to have a link instead on the view 
topic page above the list of files, for example:

Download topic text | ... | Tab width ... | Sort by filename

Clicking on the sort by filename link will set a CGI parameter, which 
will then execute code similar to what you have, but this would be in 
ViewTopic.pm over the list of delta objects.  That way, a reviewer can 
choose at runtime which way they'd prefer to see the list of files 
presented.

What do you think?

Cheers,
David