codestriker-user Mailing List for Codestriker: collaborative code reviewer (Page 21)
Brought to you by:
sits
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(12) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
|
Mar
(1) |
Apr
(6) |
May
(3) |
Jun
(1) |
Jul
|
Aug
(9) |
Sep
(2) |
Oct
(2) |
Nov
(8) |
Dec
(6) |
| 2004 |
Jan
(12) |
Feb
(19) |
Mar
(2) |
Apr
(2) |
May
(4) |
Jun
(11) |
Jul
|
Aug
(14) |
Sep
(4) |
Oct
(27) |
Nov
(4) |
Dec
(22) |
| 2005 |
Jan
(14) |
Feb
(2) |
Mar
(11) |
Apr
(3) |
May
(14) |
Jun
(60) |
Jul
(58) |
Aug
(76) |
Sep
(72) |
Oct
(59) |
Nov
|
Dec
(4) |
| 2006 |
Jan
(1) |
Feb
(5) |
Mar
(13) |
Apr
(11) |
May
(30) |
Jun
(17) |
Jul
(18) |
Aug
(39) |
Sep
|
Oct
|
Nov
|
Dec
(17) |
| 2007 |
Jan
(18) |
Feb
(5) |
Mar
(20) |
Apr
(2) |
May
(3) |
Jun
(13) |
Jul
(11) |
Aug
(4) |
Sep
(6) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
(10) |
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
(9) |
Jul
(10) |
Aug
(10) |
Sep
(13) |
Oct
(34) |
Nov
(12) |
Dec
(8) |
| 2009 |
Jan
(4) |
Feb
(11) |
Mar
(12) |
Apr
(3) |
May
(36) |
Jun
(4) |
Jul
(11) |
Aug
(12) |
Sep
(25) |
Oct
(13) |
Nov
(9) |
Dec
|
| 2010 |
Jan
|
Feb
(12) |
Mar
(6) |
Apr
(10) |
May
(12) |
Jun
|
Jul
(4) |
Aug
(9) |
Sep
(12) |
Oct
(3) |
Nov
(6) |
Dec
(3) |
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(3) |
Jun
(8) |
Jul
|
Aug
(14) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2012 |
Jan
(2) |
Feb
(10) |
Mar
(4) |
Apr
(3) |
May
(2) |
Jun
(5) |
Jul
|
Aug
(3) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(2) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: David C. <dcc...@gm...> - 2006-12-20 16:00:33
|
Is there any way to overwrite (or even simply add to) the topic text, once it has been uploaded? I could not see any way, except perhaps to obsolete the topic itself. This seems like something that would be very useful, so I'd like to suggest it for future releases. If I do my diff the wrong way or from the wrong place, upload it, realize my mistake, I'd like to be able to overwrite the text I uploaded. Thanks for the tool. Looking forward to getting better acquainted with it. David |
|
From: David C. <dcc...@gm...> - 2006-12-20 15:46:47
|
We are thinking of adopting Codestriker as the standard way of doing
reviews. However, we would like developers to use the topicid in
their CVS commits, as a way of verifying that the review has occurred.
Since the topicid is not particularly visible (it is in the e-mails,
but only buried in the URL), I modified the Email.pm file to make it
easier to do cut-n-paste of the id. Here are my changes:
--- Email.orig.pm 2005-12-06 12:48:04.000000000 -0800
+++ Email.pm 2006-12-19 07:24:06.000000000 -0800
@@ -418,8 +418,9 @@
"", "", "",
$query->url(), 0);
- my $subject = "[REVIEW] Topic $event_name \"" . $topic->{title} . "\" \n";
+ my $subject = "[REVIEW:$topic->{topicid}] Topic $event_name \"" .
$topic->{title} . "\" \n";
my $body =
+ "Topic ID: $topic->{topicid}\n" .
"Topic \"$topic->{title}\"\n" .
"Author: $topic->{author}\n" .
(($topic->{bug_ids} ne "") ? "Bug IDs: $topic->{bug_ids}\n" : "") .
|
|
From: David S. <si...@us...> - 2006-12-17 22:40:20
|
> our IT manager changed some rules on our SMTP server and Codestriker > (version 1.9.2 on a Gentoo Linux box) can no longer send mail. Every > time I take some action that should generate an email I see the > following message: > > Couldn't send email to "di...@da..." , <localhost.localdomain>: > Helo command rejected: Host not found Set your $mailhost in your codestriker.conf to the fully qualified name of the SMTP server you need to connect to. At the moment, it looks like it is set to localhost. > The guy said that the SMTP message should either be authenticated or > come from a known host. According to him, the host contained in the > message is "localhost.localdomain", wich is not a valid host. Since I > dont want to use authenticated messages, I would like Codestriker to put > the correct hostname and domain into the messages. Has anybody faced > this problem before? What is the best solution to this? I've never seen this issue... but it sounds to me that you will need to use SMTP authentication if the above doesn't make a difference. Why don't you want to do this? Quite a few people have set this up without issue. Cheers, David |
|
From: DATACOM - D. <di...@da...> - 2006-12-15 19:30:53
|
> What value do you have for $mailhost in your codstriker.conf? It shoul= d be the name of your mail server. Yes, $mailhost is pointing to the correct SMTP server. $mailuser and $mailpasswd are commented out (no authentication). It was sending (lots of) emails correctly until last week. --=20 DIEGO Moreira da Rosa DATACOM Av Fran=E7a, 735 - Porto Alegre, RS - 90230-220 DDR: +55 51 3358 0141 Fax: +55 51 3358 0101 site: www.datacom.ind.br e-mail: di...@da... |
|
From: Mark L. <ml...@ub...> - 2006-12-15 19:04:34
|
What value do you have for $mailhost in your codstriker.conf? It should be= the name of your mail server. Later Mark -----Original Message----- From: cod...@li... [mailto:codestriker-us= er-...@li...] On Behalf Of DATACOM - Diego Sent: December 15, 2006 1:58 PM To: cod...@li... Subject: Re: [Codestriker-user] Email sending failure: 'Helo command reject= ed: Host not found' > Do you have /etc/conf.d/hostname set? I am also guessing that you have= =20 yes, /etc/conf.d/hostname is set to the correct name of the host. > a line > 127.0.0.1 localhost.localdomain > in your /etc/hosts. Remove the localdomain part and optionally add the= =20 > hostname to that entry. actually there was a line: 127.0.0.1 localhost We tried changing it to: 127.0.0.1 <name_of_host> localhost and to: 127.0.0.1 <name_of_host> The problem persisted and error message was the same. Ping to "localhost.localdomain" does not resolve. Any other guess? >> Hi all, >> >> our IT manager changed some rules on our SMTP server and Codestriker=20 >> (version 1.9.2 on a Gentoo Linux box) can no longer send mail. Every=20 >> time I take some action that should generate an email I see the=20 >> following message: >> >> Couldn't send email to "di...@da..." ,=20 >> <localhost.localdomain>: Helo command rejected: Host not found >> >> The guy said that the SMTP message should either be authenticated or=20 >> come from a known host. According to him, the host contained in the=20 >> message is "localhost.localdomain", wich is not a valid host. Since I=20 >> dont want to use authenticated messages, I would like Codestriker to=20 >> put the correct hostname and domain into the messages. Has anybody=20 >> faced this problem before? What is the best solution to this? >> >> Thanks in advance, >> >>=20=20=20 >=20 >=20 >=20 > ------------------------------------------------------------------------ >=20 > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share y= our > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D= DEVDEV >=20 >=20 > ------------------------------------------------------------------------ >=20 > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user --=20 DIEGO Moreira da Rosa DATACOM Av Fran=E7a, 735 - Porto Alegre, RS - 90230-220 DDR: +55 51 3358 0141 Fax: +55 51 3358 0101 site: www.datacom.ind.br e-mail: di...@da... ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3DDE= VDEV _______________________________________________ Codestriker-user mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codestriker-user Information contained in this e-mail and any attachments are intended for t= he use of the addressee only, and may contain confidential information of U= biquity Software Corporation. All unauthorized use, disclosure or distribu= tion is strictly prohibited. If you are not the addressee, please notify t= he sender immediately and destroy all copies of this email. Unless otherwi= se expressly agreed in writing signed by an officer of Ubiquity Software Co= rporation, nothing in this communication shall be deemed to be legally bind= ing. Thank you. |
|
From: DATACOM - D. <di...@da...> - 2006-12-15 18:58:24
|
> Do you have /etc/conf.d/hostname set? I am also guessing that you have= =20 yes, /etc/conf.d/hostname is set to the correct name of the host. > a line > 127.0.0.1 localhost.localdomain > in your /etc/hosts. Remove the localdomain part and optionally add the= =20 > hostname to that entry. actually there was a line: 127.0.0.1 localhost We tried changing it to: 127.0.0.1 <name_of_host> localhost and to: 127.0.0.1 <name_of_host> The problem persisted and error message was the same. Ping to "localhost.localdomain" does not resolve. Any other guess? >> Hi all, >> >> our IT manager changed some rules on our SMTP server and Codestriker=20 >> (version 1.9.2 on a Gentoo Linux box) can no longer send mail. Every=20 >> time I take some action that should generate an email I see the=20 >> following message: >> >> Couldn't send email to "di...@da..." ,=20 >> <localhost.localdomain>: Helo command rejected: Host not found >> >> The guy said that the SMTP message should either be authenticated or=20 >> come from a known host. According to him, the host contained in the=20 >> message is "localhost.localdomain", wich is not a valid host. Since I=20 >> dont want to use authenticated messages, I would like Codestriker to=20 >> put the correct hostname and domain into the messages. Has anybody=20 >> faced this problem before? What is the best solution to this? >> >> Thanks in advance, >> >> =20 >=20 >=20 >=20 > -----------------------------------------------------------------------= - >=20 > -----------------------------------------------------------------------= -- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share= your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D= DEVDEV >=20 >=20 > -----------------------------------------------------------------------= - >=20 > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user --=20 DIEGO Moreira da Rosa DATACOM Av Fran=E7a, 735 - Porto Alegre, RS - 90230-220 DDR: +55 51 3358 0141 Fax: +55 51 3358 0101 site: www.datacom.ind.br e-mail: di...@da... |
|
From: Mark K. <Mar...@mo...> - 2006-12-15 18:21:30
|
Do you have /etc/conf.d/hostname set? I am also guessing that you have a line 127.0.0.1 localhost.localdomain in your /etc/hosts. Remove the localdomain part and optionally add the hostname to that entry. DATACOM - Diego wrote: > Hi all, > > our IT manager changed some rules on our SMTP server and Codestriker > (version 1.9.2 on a Gentoo Linux box) can no longer send mail. Every > time I take some action that should generate an email I see the > following message: > > Couldn't send email to "di...@da..." , <localhost.localdomain>: > Helo command rejected: Host not found > > The guy said that the SMTP message should either be authenticated or > come from a known host. According to him, the host contained in the > message is "localhost.localdomain", wich is not a valid host. Since I > dont want to use authenticated messages, I would like Codestriker to put > the correct hostname and domain into the messages. Has anybody faced > this problem before? What is the best solution to this? > > Thanks in advance, > > -- Mark Keisler Motorola Open Source Technologies 480-732-2495 |
|
From: DATACOM - D. <di...@da...> - 2006-12-15 18:00:54
|
Hi all, our IT manager changed some rules on our SMTP server and Codestriker=20 (version 1.9.2 on a Gentoo Linux box) can no longer send mail. Every=20 time I take some action that should generate an email I see the=20 following message: Couldn't send email to "di...@da..." , <localhost.localdomain>:=20 Helo command rejected: Host not found The guy said that the SMTP message should either be authenticated or=20 come from a known host. According to him, the host contained in the=20 message is "localhost.localdomain", wich is not a valid host. Since I=20 dont want to use authenticated messages, I would like Codestriker to put=20 the correct hostname and domain into the messages. Has anybody faced=20 this problem before? What is the best solution to this? Thanks in advance, --=20 DIEGO Moreira da Rosa DATACOM Av Fran=E7a, 735 - Porto Alegre, RS - 90230-220 DDR: +55 51 3358 0141 Fax: +55 51 3358 0101 site: www.datacom.ind.br e-mail: di...@da... |
|
From: David S. <si...@us...> - 2006-12-14 22:03:21
|
Tim Casada wrote: > David, > > Thanks for the information on this. FYI I am on Subversion 1.4.2, and > with the new white space command argument available in 1.4 and higher I Great to see they finally made this easier. I remember with earlier versions, it was a pretty impressive command line to achieve this! Cheers, David |
|
From: Tim C. <tim...@sh...> - 2006-12-14 20:23:53
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<font size="-1"><font face="Arial">David,<br>
<br>
Thanks for the information on this. FYI I am on Subversion 1.4.2, and
with the new white space command argument available in 1.4 and higher I
was able to use it successfully with Codestriker. Of course I would
have achieved this much quicker if I had remembered to update the Perl
bindings on my development system earlier than I did in my testing! I
edited, per your instructions the
/lib/Codestriker/Repository/Subversion.pm to add the following in both
the svn diff args commands as shown below. I hope someone else finds
this information useful.<br>
<br>
@args = ();<br>
push @args, 'diff';<br>
push @args, '--non-interactive';<br>
push @args, '--no-auth-cache';<br>
<i><b>push @args, '-x -w -b';</b></i><br>
push @args, @{ $self->{userCmdLine} };<br>
push @args, '-r';<br>
push @args, $start_tag . ':' . $end_tag;<br>
push @args, '--old';<br>
push @args, $self->{repository_url};<br>
push @args, $module_name;<br>
<br>
</font></font>
<pre class="moz-signature" cols="72">Tim Casada
</pre>
David Sitsky wrote:
<blockquote cite="mid:457...@us..."
type="cite">
<blockquote type="cite">Is there any way to change the configuration
on codestriker to tweak the diff parameters for diff topics directly on
top of source control systems? We often format our code with a
formatter and this sometimes causes lines to be marked as changed when
they are really not. I have no problem doing manual unified diff's but
we really like the ease of doing reviews right on top of the version
control systems.
<br>
</blockquote>
<br>
At the moment, you'll need to modify the getDiff() method for your
associated repository object and add in the appropriate command line
switch. The repository objects live in lib/Codestriker/Repository.
<br>
<br>
Cheers,
<br>
David
<br>
</blockquote>
</body>
</html>
|
|
From: Mark L. <ml...@ub...> - 2006-12-13 14:16:57
|
NP. Good to know that only the .pm is required. As for team discipline... I suggest a large stick... and a carrot of course. :-) Later Mark -----Original Message----- From: Shimon Bollinger [mailto:Shi...@Ka...]=20 Sent: December 13, 2006 1:56 AM To: Mark Lee Subject: RE: [Codestriker-user] Configuring the log_accum.pl file to create CVSdiff topics automatically Mark, Thanks again for your help. It seems that only CodestrikerClient.pm needs to be installed on the cvs server. I have set $CODESTRIKER_URL and $CODESTRIKER_REPOSITORY as you suggested. Happily, Codestriker is working as expected with cvs! Now if I can only discipline my team to use it effectively... Shimon > -----Original Message----- > From: Mark Lee [mailto:ml...@ub...]=20 > Sent: Tuesday, December 12, 2006 9:47 PM > To: Shimon Bollinger; cod...@li... > Subject: RE: [Codestriker-user] Configuring the log_accum.pl=20 > file to create CVSdiff topics automatically >=20 > Shimon, >=20 > I should mention that I am not actually running this code on=20 > my server as we want the review to happen before the commit=20 > to cvs. However, based on my admittedly incomplete under=20 > standing of the log_accum.pl shipped with codestriker... >=20 > Indeed that is what the code says, you must have codestiker=20 > installed on the cvs server (or at least part of it). =20 > However, you'll note that there is a $CODESTRIKER_URL URL=20 > that can point to any running instance of codestriker. So=20 > log_accum is using some codestriker code probably to format=20 > the data for submission to the codestriker database and then=20 > submit that information to the db. You don't need to=20 > actually run codestriker on the cvs server. >=20 > Based on my reading of the code, I would say that the=20 > $CODESTRIKER_REPOSITORY value should match the repository=20 > value in the codestriker.conf file. It represents the path=20 > to your cvs directory on the cvs server. Again it's used in=20 > the submission of the data to the code striker db. >=20 > Later > Mark >=20 > -----Original Message----- > From: Shimon Bollinger [mailto:Shi...@Ka...] > Sent: December 10, 2006 4:10 AM > To: Mark Lee > Subject: RE: [Codestriker-user] Configuring the log_accum.pl=20 > file to create CVSdiff topics automatically >=20 > Mark, >=20 > Thank you for your quick reply. It seems that at least one=20 > Codestriker module must also be installed on the cvs server=20 > for log_accum.pl to > work: >=20 > use lib '/var/www/codestriker-1.8.4/bin'; > use CodestrikerClient;=20 >=20 > Also, the following variable seems to imply that codestriker=20 > needs a cvs module. The installation instructions don't mention this. >=20 > $CODESTRIKER_REPOSITORY =3D '/var/lib/cvs'; >=20 > Any help you can give is appreciated. >=20 > Shimon >=20 > > -----Original Message----- > > From: Mark Lee [mailto:ml...@ub...] > > Sent: Thursday, December 07, 2006 10:53 PM > > To: Shimon Bollinger > > Subject: RE: [Codestriker-user] Configuring the=20 > log_accum.pl file to=20 > > create CVSdiff topics automatically > >=20 > > Shimon, > >=20 > > =20 > >=20 > > The log_accum.pl is run on the same server as CVS and is=20 > invoked from=20 > > the loginfo file in the CVSROOT directory. Open the=20 > log_accum.pl in=20 > > the bin directory and search for $CVSBIN. > > Everything from there to the Subroutines section can be changed to=20 > > suit your environment > >=20 > > =20 > >=20 > > Don't forget to add the commit_prep.pl to the commitinfo=20 > file in your=20 > > CVSROOT directory. > >=20 > > =20 > >=20 > > Later > >=20 > > Mark > >=20 > > =20 > >=20 > > ________________________________ > >=20 > > From: cod...@li... > > [mailto:cod...@li...] On=20 > Behalf Of=20 > > Shimon Bollinger > > Sent: December 7, 2006 12:23 PM > > To: cod...@li... > > Subject: [Codestriker-user] Configuring the log_accum.pl file to=20 > > create CVSdiff topics automatically > >=20 > > =20 > >=20 > > I'm installing Codestrike 1.9.2 on Linux with CVS, Bugzilla, and=20 > > Apache. I'm having trouble configuring the "Creating CVS=20 > Diff Topics=20 > > Automatically" feature. The documentation says "The=20 > log_accum.pl file=20 > > needs to have some configuration variables set at the start of the=20 > > script to reflect your site." I have two questions: > >=20 > > 1) Does Codestrike have to be running on the same server as=20 > CVS if I=20 > > want to implement this feature? > > 2) Which variables need to be set? > >=20 > > Many thanks, > >=20 > > Shimon Bollinger > > Kayote Networks > > shi...@ka... > >=20 > >=20 > >=20 > >=20 > >=20 > > Information contained in this e-mail and any attachments=20 > are intended=20 > > for the use of the addressee only, and may contain confidential=20 > > information of Ubiquity Software Corporation. > > All unauthorized use, disclosure or distribution is strictly=20 > > prohibited. If you are not the addressee, please notify the sender=20 > > immediately and destroy all copies of this email. > > Unless otherwise expressly agreed in writing signed by an=20 > officer of=20 > > Ubiquity Software Corporation, nothing in this=20 > communication shall be=20 > > deemed to be legally binding. Thank-you > >=20 >=20 >=20 >=20 > Information contained in this e-mail and any attachments are=20 > intended for the use of the addressee only, and may contain=20 > confidential information of Ubiquity Software Corporation. =20 > All unauthorized use, disclosure or distribution is strictly=20 > prohibited. If you are not the addressee, please notify the=20 > sender immediately and destroy all copies of this email. =20 > Unless otherwise expressly agreed in writing signed by an=20 > officer of Ubiquity Software Corporation, nothing in this=20 > communication shall be deemed to be legally binding. Thank you. >=20 >=20 |
|
From: David S. <si...@us...> - 2006-12-12 23:43:26
|
> Is there any way to change the configuration on codestriker to tweak the > diff parameters for diff topics directly on top of source control > systems? We often format our code with a formatter and this sometimes > causes lines to be marked as changed when they are really not. I have > no problem doing manual unified diff's but we really like the ease of > doing reviews right on top of the version control systems. At the moment, you'll need to modify the getDiff() method for your associated repository object and add in the appropriate command line switch. The repository objects live in lib/Codestriker/Repository. Cheers, David |
|
From: Mark L. <ml...@ub...> - 2006-12-12 19:47:47
|
Shimon, I should mention that I am not actually running this code on my server as we want the review to happen before the commit to cvs. However, based on my admittedly incomplete under standing of the log_accum.pl shipped with codestriker... Indeed that is what the code says, you must have codestiker installed on the cvs server (or at least part of it). However, you'll note that there is a $CODESTRIKER_URL URL that can point to any running instance of codestriker. So log_accum is using some codestriker code probably to format the data for submission to the codestriker database and then submit that information to the db. You don't need to actually run codestriker on the cvs server. Based on my reading of the code, I would say that the $CODESTRIKER_REPOSITORY value should match the repository value in the codestriker.conf file. It represents the path to your cvs directory on the cvs server. Again it's used in the submission of the data to the code striker db. Later Mark -----Original Message----- From: Shimon Bollinger [mailto:Shi...@Ka...]=20 Sent: December 10, 2006 4:10 AM To: Mark Lee Subject: RE: [Codestriker-user] Configuring the log_accum.pl file to create CVSdiff topics automatically Mark, Thank you for your quick reply. It seems that at least one Codestriker module must also be installed on the cvs server for log_accum.pl to work: use lib '/var/www/codestriker-1.8.4/bin'; use CodestrikerClient;=20 Also, the following variable seems to imply that codestriker needs a cvs module. The installation instructions don't mention this. $CODESTRIKER_REPOSITORY =3D '/var/lib/cvs'; Any help you can give is appreciated. Shimon > -----Original Message----- > From: Mark Lee [mailto:ml...@ub...]=20 > Sent: Thursday, December 07, 2006 10:53 PM > To: Shimon Bollinger > Subject: RE: [Codestriker-user] Configuring the log_accum.pl=20 > file to create CVSdiff topics automatically >=20 > Shimon, >=20 >=20=20 >=20 > The log_accum.pl is run on the same server as CVS and is=20 > invoked from the loginfo file in the CVSROOT directory. Open=20 > the log_accum.pl in the bin directory and search for $CVSBIN.=20 > Everything from there to the Subroutines section can be=20 > changed to suit your environment >=20 >=20=20 >=20 > Don't forget to add the commit_prep.pl to the commitinfo file=20 > in your CVSROOT directory. >=20 >=20=20 >=20 > Later >=20 > Mark >=20 >=20=20 >=20 > ________________________________ >=20 > From: cod...@li...=20 > [mailto:cod...@li...] On=20 > Behalf Of Shimon Bollinger > Sent: December 7, 2006 12:23 PM > To: cod...@li... > Subject: [Codestriker-user] Configuring the log_accum.pl file=20 > to create CVSdiff topics automatically >=20 >=20=20 >=20 > I'm installing Codestrike 1.9.2 on Linux with CVS, Bugzilla,=20 > and Apache. I'm having trouble configuring the "Creating CVS=20 > Diff Topics Automatically" feature. The documentation says=20 > "The log_accum.pl file needs to have some configuration=20 > variables set at the start of the script to reflect your=20 > site." I have two questions: >=20 > 1) Does Codestrike have to be running on the same server as=20 > CVS if I want to implement this feature? > 2) Which variables need to be set? >=20 > Many thanks, >=20 > Shimon Bollinger > Kayote Networks > shi...@ka... >=20 >=20 >=20 >=20 >=20 > Information contained in this e-mail and any attachments are=20 > intended for the use of the addressee only, and may contain=20 > confidential information of Ubiquity Software Corporation.=20 > All unauthorized use, disclosure or distribution is strictly=20 > prohibited. If you are not the addressee, please notify the=20 > sender immediately and destroy all copies of this email.=20=20 > Unless otherwise expressly agreed in writing signed by an=20 > officer of Ubiquity Software Corporation, nothing in this=20 > communication shall be deemed to be legally binding. Thank-you=20 >=20 Information contained in this e-mail and any attachments are intended for t= he use of the addressee only, and may contain confidential information of U= biquity Software Corporation. All unauthorized use, disclosure or distribu= tion is strictly prohibited. If you are not the addressee, please notify t= he sender immediately and destroy all copies of this email. Unless otherwi= se expressly agreed in writing signed by an officer of Ubiquity Software Co= rporation, nothing in this communication shall be deemed to be legally bind= ing. Thank you. |
|
From: Tim C. <tim...@sh...> - 2006-12-12 18:32:21
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> <font size="-1"><font face="Arial">David,<br> <br> Is there any way to change the configuration on codestriker to tweak the diff parameters for diff topics directly on top of source control systems? We often format our code with a formatter and this sometimes causes lines to be marked as changed when they are really not. I have no problem doing manual unified diff's but we really like the ease of doing reviews right on top of the version control systems.<br> <br> Thanks,<br> </font></font> <pre class="moz-signature" cols="72">-- Tim Casada </pre> </body> </html> |
|
From: David S. <si...@us...> - 2006-12-07 22:45:42
|
Shimon Bollinger wrote: > I'm installing Codestrike 1.9.2 on Linux with CVS, Bugzilla, and > Apache. I'm having trouble configuring the "Creating CVS Diff Topics > Automatically" feature. The documentation says "The log_accum.pl file > needs to have some configuration variables set at the start of the > script to reflect your site." I have two questions: > > 1) Does Codestrike have to be running on the same server as CVS if I > want to implement this feature? > 2) Which variables need to be set? They don't have to be on the same server. In fact, if you look at the start of the script (search for codestriker) you'll see all the configuration variables there. What version of CVS are you using? Cheers, David |
|
From: Shimon B. <Shi...@Ka...> - 2006-12-07 17:22:56
|
I'm installing Codestrike 1.9.2 on Linux with CVS, Bugzilla, and Apache. = I'm having trouble configuring the "Creating CVS Diff Topics = Automatically" feature. The documentation says "The log_accum.pl file = needs to have some configuration variables set at the start of the = script to reflect your site." I have two questions: 1) Does Codestrike have to be running on the same server as CVS if I = want to implement this feature? 2) Which variables need to be set? Many thanks, Shimon Bollinger Kayote Networks shi...@ka... |
|
From: David S. <si...@us...> - 2006-08-24 23:48:10
|
Hi Keith,
> $cmd = "\"$Codestriker::svn\" diff --non-interactive --no-auth-cache
> " .
> $self->{userCmdLine} . " -r $start_tag:$end_tag " .
> "--old \"$self->{repository_url}\" --diff-cmd diff -x -uw
> \"$module_name\"";
I'd recommend putting the full path to the diff command, eg:
--diff-cmd /usr/bin/diff -x -uw \"$module_name\""
just to make sure the webserver is picking up the right process.
After this line, try adding:
print STDERR "Command is $cmd\n";
Then check how this line (this will appear in apache's error_log file)
compares to your command line that you have typed out. Hopefully this
will make it clear what the difference might be.
The other thing to try is running your command as the same user as the
web-server.
Please let us know how you go.
Cheers,
David
|
|
From: Keith L. <the...@gm...> - 2006-08-24 18:25:09
|
I have tried to implement the use of gnu diff on my codestriker
installation. I changed the Subversion.pm file from:
$cmd = "\"$Codestriker::svn\" diff --non-interactive --no-auth-cache " .
$self->{userCmdLine} . " -r $start_tag:$end_tag " .
"--old \"$self->{repository_url}\" \"$module_name\"";
to:
$cmd = "\"$Codestriker::svn\" diff --non-interactive --no-auth-cache " .
$self->{userCmdLine} . " -r $start_tag:$end_tag " .
"--old \"$self->{repository_url}\" --diff-cmd diff -x -uw
\"$module_name\"";
In my test, I supplied revisions that would result in a single file being
diffed. The resultant topic had a file called 'unknown.txt' with output:
<javascript:eo('0','1','1')>
Index: devbranches/eckml/CQ14179/grainger/script_root/jsp/profile/accountadmin/accountAdmin_body.jsp
<javascript:eo('0','2','1')>
=================================================================== The
output shows only the name of the file I'd expected to be diffed.
The command runs fine from the command line. I'm wondering if there's some
PERL voodoo I don't know about. I'm far from a PERL expert and could use
some help.
Thanks,
Keith Levy
On 8/8/06, David Sitsky <si...@us...> wrote:
>
> Looks like it is possible, but the command line needs to be modified
> further. Check out:
>
>
> http://www.akatombo.com/index/en/comments/ignore_whitespace_in_a_subversion_diff/
>
> Cheers,
> David
>
> Moisei Rabinovich wrote:
> > Ohh, I assumed everybody knows that I use subversion not a CVS.
> > Thanks for the tip anyway, I think, know where to go now.
> > Even svn diff is missing this option natively, there is a way to use
> > 3-rd party diff that knows to ignore the white spaces.
> >
> > On 8/8/06, *David Sitsky* <si...@us...
> > <mailto:si...@us...>> wrote:
> >
> > Moisei Rabinovich wrote:
> > > well, I probably miss some important point.
> > > codestriker generates a diff for me by itself, i only fill
> start-tag,
> > > end-tag and module.
> > > where should i set the "-b" option?
> >
> > If you always want to ignore whitespace changes, you can do this by
> > modifying lib/Codestriker/Repository/Cvs.pm, line 124. Add the '-b'
> > option so that the code that used to be:
> >
> > my $pid = open3($write_stdin_fh, $read_stdout_fh,
> $read_stderr_fh,
> > $Codestriker::cvs, '-q', '-d', $self->{url},
> > 'rdiff', $extra_options, '-u',
> > '-r', $start_tag, '-r', $end_tag, $module_name);
> >
> > Looks like:
> >
> > my $pid = open3($write_stdin_fh, $read_stdout_fh,
> $read_stderr_fh,
> > $Codestriker::cvs, '-q', '-d', $self->{url},
> > 'rdiff', $extra_options, '-u', '-b',
> > '-r', $start_tag, '-r', $end_tag, $module_name);
> >
> > ie - the -b option has been added.
> >
> > > also I am not sure @exclude_file_types is taken into account in
> > this case
> >
> > It should be. The same filtering code is run, regardless of whether
> or
> > not Codestriker generated the diff text, or it was supplied by the
> > user.
> >
> > Cheers,
> > David
> >
> >
> >
> >
> > --
> > Best Regards,
> > Moisei
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
|
|
From: David S. <si...@us...> - 2006-08-23 04:39:30
|
Vladimir Sizikov wrote: > Hi David, > > On 8/22/06, David Sitsky <si...@us...> wrote: >>> I can confirm the same thing, Codestriker with mod_perl config doesn't >>> work, and produces these confusing errors. >> This is really due to the black magic of mod_perl... > > Seems so. > >> Just curious - are you running with Apache 1 or 2? > > Both Fedora Core 4 and Fedora Core 5 come with Apache 2. I haven't used apache2 in anger, but it is possible to configure it to use the same process model as apache1, that is a separate process per request. I believe if you configure your apache server to use the prefork MPM, then this may make codestriker work correctly under mod_perl2. http://httpd.apache.org/docs/2.0/mod/prefork.html Please let me know how you go. I don't have access to an apache2 machine at present. Cheers, David |
|
From: Vladimir S. <vsi...@gm...> - 2006-08-22 07:26:21
|
Hi David, On 8/22/06, David Sitsky <si...@us...> wrote: > > I can confirm the same thing, Codestriker with mod_perl config doesn't > > work, and produces these confusing errors. > This is really due to the black magic of mod_perl... Seems so. > Just curious - are you running with Apache 1 or 2? Both Fedora Core 4 and Fedora Core 5 come with Apache 2. Thanks, --Vladimir |
|
From: David S. <si...@us...> - 2006-08-22 07:11:05
|
> I can confirm the same thing, Codestriker with mod_perl config doesn't > work, and produces these confusing errors. Even more, the errors are > not 100%, sometimes I can submit the topic if I click Refresh many, > many times. :) > > Everything started working just fine as soon as I switched to CGI config. > > I used Fedora Core 4 and Fedora Core 5. This is really due to the black magic of mod_perl... Just curious - are you running with Apache 1 or 2? This might be partly due to the constraints apache 2 has when forking new processes. Since apache 2 is now I believe multi-threaded as well as multi-processed, launching external executables may not be supported 100%. I'll need to do more reading on this. I do know though that under apache1, since it is not multi-threaded, all works fine I believe with mod_perl. Cheers, David |
|
From: Vladimir S. <vsi...@gm...> - 2006-08-21 14:48:20
|
Hi Tim, folks,
I can confirm the same thing, Codestriker with mod_perl config doesn't
work, and produces these confusing errors. Even more, the errors are
not 100%, sometimes I can submit the topic if I click Refresh many,
many times. :)
Everything started working just fine as soon as I switched to CGI config.
I used Fedora Core 4 and Fedora Core 5.
Thanks,
--Vladimir
On 8/21/06, Tim Casada <tim...@sh...> wrote:
>
> Jason,
>
> Thanks for the tips. I tried the additional error message code change, but
> I did not get anything in the apache log for this error still. I was able
> to successfully run the svn diff using the command from getDiff. When I
> turned off mod_perl and switched to CGI everything starting working fine.
>
> We recently switched to Red Hat from a test box on FC4, so I'm guessing the
> mod_perl version differences account for my error. Thank you very much for
> pointing me in the right direction!
> Tim Casada
>
>
> Jason Remillard wrote:
> Hi,
>
> Just in case it matters. What version of apache are you using, and if you
> are using mod_perl what
> version is that as well.
>
> If you look at the lib/Codestriker/Repository/Subversion.pm
> module you will see the getDiff
> function. Su to your web server user (I think apache on redhat) and issue
> the same "svn diff"
> command that getDiff is issuing and see if it works. If you are using
> mod_perl, try turning it
> off.
>
> Also, Codestriker will not show the repository if you only have one setup.
> Why show a combo box
> that only will have once choice.
>
> Lastly, I just looked over the code in it looks like there are some
> situations that errors would
> not be logged to the apache error log. Towards the end of the getDiff
> function, you will see a
> loop that looks like this.
>
> my $buf;
> while (read($read_stderr_fh,$bug,16384)) {
> print $stderr_fh $buf;
> }
>
> Right after this loop add this line of code in, to get more information in
> your apache log.
>
> print STDERR $buf;
>
> Thanks
> Jason.
>
> --- Tim Casada <tim...@sh...> wrote:
>
>
> ---------------------------------
> David & Jason,
>
> On my recent fresh install of 1.9.2 on RHEL ES 4 I am getting thefollowing
> error when trying to
> submit the topic and giving start andend tags with a module (single file) to
> subversion:
>
> Problem generating topic text:
>
> svn: Can't write to stream: Broken pipe
>
> Can someone lead me in the right direction? I donot see anything in the
> Apache logs.
>
> Thanks,
>
> -- Tim Casada
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>
>
> _______________________________________________
>
>
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam? Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>
>
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
>
>
|
|
From: Tim C. <tim...@sh...> - 2006-08-21 13:41:53
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<font size="-1"><font face="Arial">Jason,<br>
<br>
Thanks for the tips. I tried the additional error message code change,
but I did not get anything in the apache log for this error still. I
was able to successfully run the svn diff using the command from
getDiff. When I turned off mod_perl and switched to CGI everything
starting working fine.<br>
<br>
We recently switched to Red Hat from a test box on FC4, so I'm guessing
the mod_perl version differences account for my error. Thank you very
much for pointing me in the right direction!<br>
</font></font>
<pre class="moz-signature" cols="72">Tim Casada</pre>
<br>
<br>
Jason Remillard wrote:
<blockquote
cite="mid...@we..."
type="cite">
<pre wrap="">Hi,
Just in case it matters. What version of apache are you using, and if you are using mod_perl what
version is that as well.
If you look at the lib/Codestriker/Repository/Subversion.pm module you will see the getDiff
function. Su to your web server user (I think apache on redhat) and issue the same "svn diff"
command that getDiff is issuing and see if it works. If you are using mod_perl, try turning it
off.
Also, Codestriker will not show the repository if you only have one setup. Why show a combo box
that only will have once choice.
Lastly, I just looked over the code in it looks like there are some situations that errors would
not be logged to the apache error log. Towards the end of the getDiff function, you will see a
loop that looks like this.
my $buf;
while (read($read_stderr_fh,$bug,16384)) {
print $stderr_fh $buf;
}
Right after this loop add this line of code in, to get more information in your apache log.
print STDERR $buf;
Thanks
Jason.
--- Tim Casada <a class="moz-txt-link-rfc2396E" href="mailto:tim...@sh..."><tim...@sh...></a> wrote:
---------------------------------
David & Jason,
On my recent fresh install of 1.9.2 on RHEL ES 4 I am getting thefollowing error when trying to
submit the topic and giving start andend tags with a module (single file) to subversion:
Problem generating topic text:
svn: Can't write to stream: Broken pipe
Can someone lead me in the right direction? I donot see anything in the Apache logs.
Thanks,
-- Tim Casada
</pre>
<blockquote type="cite">
<pre wrap="">-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
<a class="moz-txt-link-freetext" href="http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642">http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642</a>>
</pre>
</blockquote>
<pre wrap=""><!---->_______________________________________________
</pre>
<blockquote type="cite">
<pre wrap="">Codestriker-user mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Cod...@li...">Cod...@li...</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/codestriker-user">https://lists.sourceforge.net/lists/listinfo/codestriker-user</a>
</pre>
</blockquote>
<pre wrap=""><!---->
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
<a class="moz-txt-link-freetext" href="http://mail.yahoo.com">http://mail.yahoo.com</a>
</pre>
</blockquote>
</body>
</html>
|
|
From: Jason R. <jre...@ya...> - 2006-08-21 02:28:21
|
Hi,
Just in case it matters. What version of apache are you using, and if you are using mod_perl what
version is that as well.
If you look at the lib/Codestriker/Repository/Subversion.pm module you will see the getDiff
function. Su to your web server user (I think apache on redhat) and issue the same "svn diff"
command that getDiff is issuing and see if it works. If you are using mod_perl, try turning it
off.
Also, Codestriker will not show the repository if you only have one setup. Why show a combo box
that only will have once choice.
Lastly, I just looked over the code in it looks like there are some situations that errors would
not be logged to the apache error log. Towards the end of the getDiff function, you will see a
loop that looks like this.
my $buf;
while (read($read_stderr_fh,$bug,16384)) {
print $stderr_fh $buf;
}
Right after this loop add this line of code in, to get more information in your apache log.
print STDERR $buf;
Thanks
Jason.
--- Tim Casada <tim...@sh...> wrote:
---------------------------------
David & Jason,
On my recent fresh install of 1.9.2 on RHEL ES 4 I am getting thefollowing error when trying to
submit the topic and giving start andend tags with a module (single file) to subversion:
Problem generating topic text:
svn: Can't write to stream: Broken pipe
Can someone lead me in the right direction? I donot see anything in the Apache logs.
Thanks,
-- Tim Casada
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>
_______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
|
|
From: Tim C. <tim...@sh...> - 2006-08-18 19:50:04
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> Some updates on this topic. I noticed that none of the repositories are showing up on the Create Topic screen at all. I had missed this because I traditionally run with only a single repository. I tried editing the codestriker.conf by replacing my customized one with the standard one and just changing the database user name and password entry. I was still not able to see the repositories. I then removed the entire aliasing section and was able to see the repositories.<br> <br> I think there is a bug whereas if you have only 1 repository listed in the @valid-repositories that the Repository drop down will not show at all in the create topic screen. When I simply uncomment the default first repository in the file '/home/sits/cvs' and add mine above it works fine, even with the aliasing.<br> <br> I am however still gettting the same error message <font color="red"> svn: Can't write to stream: Broken pipe<font color="#000000"> on submission of the review.</font><br> </font> <pre class="moz-signature" cols="72">Tim Casada </pre> <br> <br> Tim Casada wrote: <blockquote cite="mid...@sh..." type="cite">David & Jason,<br> <br> On my recent fresh install of 1.9.2 on RHEL ES 4 I am getting the following error when trying to submit the topic and giving start and end tags with a module (single file) to subversion:<br> <br> <font color="red">Problem generating topic text:<br> <br> svn: Can't write to stream: Broken pipe<br> <br> <font color="#000000">Can someone lead me in the right direction? I do not see anything in the Apache logs.<br> <br> Thanks,<br> </font></font> <pre class="moz-signature" cols="72">-- Tim Casada </pre> <pre wrap=""> <hr size="4" width="90%"> ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo <a class="moz-txt-link-freetext" href="http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642">http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642</a></pre> <pre wrap=""> <hr size="4" width="90%"> _______________________________________________ Codestriker-user mailing list <a class="moz-txt-link-abbreviated" href="mailto:Cod...@li...">Cod...@li...</a> <a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/codestriker-user">https://lists.sourceforge.net/lists/listinfo/codestriker-user</a> </pre> </blockquote> </body> </html> |