codenarc-developer — CodeNarc Developers

Re: [Codenarc-developer] My views on making it easier for people to contribute

[Hamlet D. <ham...@ca...>]

How does Subversion prevent Netflix employees from contributing rules back? 
Have you written custom rules that you haven't submitted back, and just don't want to see the hassle of messing with Subversion? 

Full disclosure: I'm the guy that doesn't see the benefit of Git for CodeNarc. I wrote up the process of pull, code, commit, pull request/patch for both Subversion and GitHub. Both processes had roughly the same number of bullet points and took roughly the same time. From a contributors viewpoint, I don't see any improvement. 

GitHub: 
* Fork 
* Git Pull 
* Write Code
* Commit and Push
* Pull request and type up a nice message

Subversion
* svn co https://sourceforge.subversion.com/codenarc/trunk
* Write Code
* svn diff > my_patch.patch
* Attach patch to ticket or email me the patch

And that assumes the contributor already has a GitHub account and has already navigated the steps to create keys and get an account. 

I *do* see a benefit of GitHub. There is a "social coding" aspect to it where developers can easily get recognition and kudos for the work they do. Much more so than just getting your name in our release notes :)

If anyone feels motivated to do the work and make the switch then I guess we should go for it. It will have some benefit. Based on my analysis, I am personally not motivated to do this work. I feel like the migration would take about 4 hours of my time. Writing 2 new analysis rules would also take about 4 hours. I'm just talking about me personally, but I'm going to spend time on rules for the time being because it offers a better return on investment. 

As for Gradle... I see good benefits, like being able to run the tests against Groovy 1.8 and Groovy 2.0, automating our release more, and rolling the create-rule script into a Gradle task. Plus, the Gradle Wrapper is great. What holds us back is the Site stuff. What I would do in a Gradle conversion is forget about the Site plugin. I'd just take all of our HTML and check it into VCS. The only part that changes is the rule descriptions that get updated with every rule. You could just change the create-rule script to update an HTML page instead of a wiki markup page and be done. 

And finally... thanks for caring about CodeNarc. It's a special project for me and it means a lot to hear some voices from people who care. 

--
Hamlet D'Arcy
ham...@ca...

----- Original Message -----
> +1 on prioritizing the Git/Github move. I know that keeps us from
> doing more with CodeNarc at Netflix. Github is probably the single
> best thing you can do with your project to get more developer use and
> contributions. I don't see a move to Gradle buying you as much, seems
> like a lateral change.
> 
> On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann
> <mar...@pr...> wrote:
> > Chris,
> >
> > I believe migrating to git is more essential when it comes to
> > getting people
> > to contribute more easily to the project but I also understand your
> > reservations towards it and understand that you see it as a big
> > step
> > especially as the project owner you need to be confident about the
> > vcs
> > you're using.
> >
> > Yes, I'm still up to helping out with the gradle migration of
> > course. I will
> > have a go at it during the weekend. I have some questions though.
> > What do we
> > exactly need to port? It's of course building and running the
> > tests,
> > deploying to Codehaus maven repo (we're doing it in geb, so I will
> > probably
> > have a look at how it's done there) and generating (also
> > uploading?) the
> > site. Is there anything else? I'm not a maven specialist so can you
> > please
> > list all of the commands you're using in your workflow to achieve
> > the
> > aforementioned tasks? What version of maven/other setup I need to
> > run all of
> > the tasks?
> >
> > I still haven't received any response from Rene about the site
> > plugin but I
> > will try to use it anyway and get it to a working state if
> > necessary.
> >
> > Thanks,
> > Marcin
> >
> >
> > On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair
> > <chr...@ea...> wrote:
> >>
> >> Marcin,
> >>
> >> I was expecting/hoping that we could treat these as two separate
> >> issues.
> >> I'm
> >> not sure that I am up for trying to tackle both at the same time.
> >> At some
> >> point, I need to do some analysis to figure out the impacts of a
> >> migration
> >> from Sourceforge+SVN to GitHub+Git.
> >>
> >> I am probably more eager to do the Gradle migration, assuming that
> >> it now
> >> supports the features that we need. I am also interested in
> >> getting more
> >> experience with Git, but I expect that will be more disruptive.
> >>
> >> Is doing one without the other (let's say doing Gradle), still
> >> feasible,
> >> and
> >> still something you'd want to help with?
> >>
> >> Thanks.
> >> Chris
> >> -----Original Message-----
> >> From: Marcin Erdmann [mailto:mar...@pr...]
> >> Sent: Saturday, July 21, 2012 11:30 AM
> >> To: Chris Mair
> >> Cc: cod...@li...
> >> Subject: Re: [Codenarc-developer] My views on making it easier for
> >> people
> >> to
> >> contribute
> >>
> >> Chris,
> >>
> >> I'm glad to hear that you like my ideas. Here are the two feature
> >> requests
> >> on Sourceforge tracker:
> >>
> >> https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati
> >> d=1126575
> >>
> >> https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati
> >> d=1126575
> >>
> >> When it comes to the site plugin I'm currently waiting for a
> >> response from
> >> Rene Gröschke on the status of the plugin
> >> (https://github.com/breskeby/GradleSite). After having a quick
> >> peek at it
> >> I
> >> believe it is finished. It's not in central but I could put it
> >> there cause
> >> I
> >> have rights to 'org.gradle.api.plugins' group in Sonatype OSS
> >> repo.
> >>
> >> I can start working on the build migration as soon as we'll put
> >> the code
> >> into github - I will create a fork of it and submit a pull request
> >> when
> >> it's
> >> ready. I can also help in migrating the source to github, I've
> >> migrated
> >> some
> >> repos in the past from svn to github using git-svn and could pull
> >> the
> >> source
> >> into the new repo given that I will get commit access to
> >> CodeNarc's github
> >> repository - I won't mind if you revoke it after the migration is
> >> done.
> >>
> >> Cheers,
> >> Marcin
> >>
> >> On 07/21/2012 02:35 PM, Chris Mair wrote:
> >> > Marcin,
> >> >
> >> > Thank you for the feedback (and the CodeNarc contributions).
> >> >
> >> > I am open to both ideas. Can you please open a feature request
> >> > for
> >> > each suggestion (Git/Github and Gradle):
> >> > https://sourceforge.net/tracker/?group_id=250145&atid=1126575.
> >> >
> >> > Both have been informally suggested before, so it's probably
> >> > worth
> >> > getting them to a place where we can consolidate the discussion
> >> > of the
> >> > merits and trade-offs, and bring Hamlet into the discussion as
> >> > well.
> >> > One of the sticking points with Gradle previously was the lack
> >> > of a
> >> > site plugin, since we currently use Maven to generate the
> >> > CodeNarc web
> >> > site from APT files, and also generate the APT for the Rules
> >> > Index
> >> > page. I have not checked on the status of that lately.
> >> >
> >> > Thanks.
> >> > Chris
> >> >
> >> > -----Original Message-----
> >> > From: Marcin Erdmann [mailto:mar...@pr...]
> >> > Sent: Thursday, July 19, 2012 7:34 PM
> >> > To: cod...@li...
> >> > Subject: [Codenarc-developer] My views on making it easier for
> >> > people
> >> > to contribute
> >> >
> >> > Hi all,
> >> >
> >> > In the past I've contributed several rules and fixes to
> >> > Codenarc.
> >> > Recently we've added Codenarc to our project and we found a
> >> > major bug
> >> > in UnnecessarySemicolonRule and wanted to fix it. After checking
> >> > the
> >> > project state I've found out that it's still quite tedious to
> >> > contribute for two reasons - svn and maven.
> >> >
> >> > If you want to contribute to Codenarc you need to send patches
> >> > in
> >> > email, like I did by sending mails to Hamlet in the past. This
> >> > would
> >> > be much easier if the project was on github enabling people to
> >> > submit
> >> > pull request... I don't know if there is a CI build set up for
> >> > the
> >> > project but by putting it on github and hooking it up with
> >> > buildhive
> >> > you get CI builds for free, also for pull requests. Can you
> >> > please
> >> > explain what are the reasons for such a valuable project to be
> >> > still
> >> > using
> >> svn?
> >> >
> >> > The other thing is getting the project into your IDE. It would
> >> > be so
> >> > much easier if there was a gradle build available for the
> >> > project -
> >> > simply typing gradle idea would generate the project for you
> >> > with all
> >> > the dependencies in place and no additional settings/tweaks
> >> > needed. If
> >> > you're interested I could try to contribute by migrating current
> >> > maven
> >> > build to gradle. I'm already in talks with Rene Gröschke about
> >> > his
> >> > efforts
> >> in the past in that area.
> >> >
> >> > Cheers,
> >> > Marcin Erdmann
> >> >
> >> > ----------------------------------------------------------------------
> >> > ------
> >> > --
> >> > Live Security Virtual Conference
> >> > Exclusive live event will cover all the ways today's security
> >> > and
> >> > threat landscape has changed and how IT managers can respond.
> >> > Discussions will include endpoint security, mobile security and
> >> > the
> >> > latest in malware threats.
> >> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >> > _______________________________________________
> >> > Codenarc-developer mailing list
> >> > Cod...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> >> >
> >> >
> >>
> >
> >
> > ------------------------------------------------------------------------------
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond.
> > Discussions
> > will include endpoint security, mobile security and the latest in
> > malware
> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > Codenarc-developer mailing list
> > Cod...@li...
> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> >
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond.
> Discussions
> will include endpoint security, mobile security and the latest in
> malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> 

Re: [Codenarc-developer] My views on making it easier for people to contribute

[Clay M. <cod...@cl...>]

+1 on prioritizing the Git/Github move. I know that keeps us from
doing more with CodeNarc at Netflix. Github is probably the single
best thing you can do with your project to get more developer use and
contributions. I don't see a move to Gradle buying you as much, seems
like a lateral change.

On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann
<mar...@pr...> wrote:
> Chris,
>
> I believe migrating to git is more essential when it comes to getting people
> to contribute more easily to the project but I also understand your
> reservations towards it and understand that you see it as a big step
> especially as the project owner you need to be confident about the vcs
> you're using.
>
> Yes, I'm still up to helping out with the gradle migration of course. I will
> have a go at it during the weekend. I have some questions though. What do we
> exactly need to port? It's of course building and running the tests,
> deploying to Codehaus maven repo (we're doing it in geb, so I will probably
> have a look at how it's done there) and generating (also uploading?) the
> site. Is there anything else? I'm not a maven specialist so can you please
> list all of the commands you're using in your workflow to achieve the
> aforementioned tasks? What version of maven/other setup I need to run all of
> the tasks?
>
> I still haven't received any response from Rene about the site plugin but I
> will try to use it anyway and get it to a working state if necessary.
>
> Thanks,
> Marcin
>
>
> On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair <chr...@ea...> wrote:
>>
>> Marcin,
>>
>> I was expecting/hoping that we could treat these as two separate issues.
>> I'm
>> not sure that I am up for trying to tackle both at the same time. At some
>> point, I need to do some analysis to figure out the impacts of a migration
>> from Sourceforge+SVN to GitHub+Git.
>>
>> I am probably more eager to do the Gradle migration, assuming that it now
>> supports the features that we need. I am also interested in getting more
>> experience with Git, but I expect that will be more disruptive.
>>
>> Is doing one without the other (let's say doing Gradle), still feasible,
>> and
>> still something you'd want to help with?
>>
>> Thanks.
>> Chris
>> -----Original Message-----
>> From: Marcin Erdmann [mailto:mar...@pr...]
>> Sent: Saturday, July 21, 2012 11:30 AM
>> To: Chris Mair
>> Cc: cod...@li...
>> Subject: Re: [Codenarc-developer] My views on making it easier for people
>> to
>> contribute
>>
>> Chris,
>>
>> I'm glad to hear that you like my ideas. Here are the two feature requests
>> on Sourceforge tracker:
>>
>> https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati
>> d=1126575
>>
>> https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati
>> d=1126575
>>
>> When it comes to the site plugin I'm currently waiting for a response from
>> Rene Gröschke on the status of the plugin
>> (https://github.com/breskeby/GradleSite). After having a quick peek at it
>> I
>> believe it is finished. It's not in central but I could put it there cause
>> I
>> have rights to 'org.gradle.api.plugins' group in Sonatype OSS repo.
>>
>> I can start working on the build migration as soon as we'll put the code
>> into github - I will create a fork of it and submit a pull request when
>> it's
>> ready. I can also help in migrating the source to github, I've migrated
>> some
>> repos in the past from svn to github using git-svn and could pull the
>> source
>> into the new repo given that I will get commit access to CodeNarc's github
>> repository - I won't mind if you revoke it after the migration is done.
>>
>> Cheers,
>> Marcin
>>
>> On 07/21/2012 02:35 PM, Chris Mair wrote:
>> > Marcin,
>> >
>> > Thank you for the feedback (and the CodeNarc contributions).
>> >
>> > I am open to both ideas. Can you please open a feature request for
>> > each suggestion (Git/Github and Gradle):
>> > https://sourceforge.net/tracker/?group_id=250145&atid=1126575.
>> >
>> > Both have been informally suggested before, so it's probably worth
>> > getting them to a place where we can consolidate the discussion of the
>> > merits and trade-offs, and bring Hamlet into the discussion as well.
>> > One of the sticking points with Gradle previously was the lack of a
>> > site plugin, since we currently use Maven to generate the CodeNarc web
>> > site from APT files, and also generate the APT for the Rules Index
>> > page. I have not checked on the status of that lately.
>> >
>> > Thanks.
>> > Chris
>> >
>> > -----Original Message-----
>> > From: Marcin Erdmann [mailto:mar...@pr...]
>> > Sent: Thursday, July 19, 2012 7:34 PM
>> > To: cod...@li...
>> > Subject: [Codenarc-developer] My views on making it easier for people
>> > to contribute
>> >
>> > Hi all,
>> >
>> > In the past I've contributed several rules and fixes to Codenarc.
>> > Recently we've added Codenarc to our project and we found a major bug
>> > in UnnecessarySemicolonRule and wanted to fix it. After checking the
>> > project state I've found out that it's still quite tedious to
>> > contribute for two reasons - svn and maven.
>> >
>> > If you want to contribute to Codenarc you need to send patches in
>> > email, like I did by sending mails to Hamlet in the past. This would
>> > be much easier if the project was on github enabling people to submit
>> > pull request... I don't know if there is a CI build set up for the
>> > project but by putting it on github and hooking it up with buildhive
>> > you get CI builds for free, also for pull requests. Can you please
>> > explain what are the reasons for such a valuable project to be still
>> > using
>> svn?
>> >
>> > The other thing is getting the project into your IDE. It would be so
>> > much easier if there was a gradle build available for the project -
>> > simply typing gradle idea would generate the project for you with all
>> > the dependencies in place and no additional settings/tweaks needed. If
>> > you're interested I could try to contribute by migrating current maven
>> > build to gradle. I'm already in talks with Rene Gröschke about his
>> > efforts
>> in the past in that area.
>> >
>> > Cheers,
>> > Marcin Erdmann
>> >
>> > ----------------------------------------------------------------------
>> > ------
>> > --
>> > Live Security Virtual Conference
>> > Exclusive live event will cover all the ways today's security and
>> > threat landscape has changed and how IT managers can respond.
>> > Discussions will include endpoint security, mobile security and the
>> > latest in malware threats.
>> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> > _______________________________________________
>> > Codenarc-developer mailing list
>> > Cod...@li...
>> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>> >
>> >
>>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>

Re: [Codenarc-developer] My views on making it easier for people to contribute

[Marcin E. <mar...@pr...>]

Chris,

I believe migrating to git is more essential when it comes to getting
people to contribute more easily to the project but I also understand your
reservations towards it and understand that you see it as a big step
especially as the project owner you need to be confident about the vcs
you're using.

Yes, I'm still up to helping out with the gradle migration of course. I
will have a go at it during the weekend. I have some questions though. What
do we exactly need to port? It's of course building and running the tests,
deploying to Codehaus maven repo (we're doing it in geb, so I will probably
have a look at how it's done there) and generating (also uploading?) the
site. Is there anything else? I'm not a maven specialist so can you please
list all of the commands you're using in your workflow to achieve the
aforementioned tasks? What version of maven/other setup I need to run all
of the tasks?

I still haven't received any response from Rene about the site plugin but I
will try to use it anyway and get it to a working state if necessary.

Thanks,
Marcin

On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair <chr...@ea...> wrote:

> Marcin,
>
> I was expecting/hoping that we could treat these as two separate issues.
> I'm
> not sure that I am up for trying to tackle both at the same time. At some
> point, I need to do some analysis to figure out the impacts of a migration
> from Sourceforge+SVN to GitHub+Git.
>
> I am probably more eager to do the Gradle migration, assuming that it now
> supports the features that we need. I am also interested in getting more
> experience with Git, but I expect that will be more disruptive.
>
> Is doing one without the other (let's say doing Gradle), still feasible,
> and
> still something you'd want to help with?
>
> Thanks.
> Chris
> -----Original Message-----
> From: Marcin Erdmann [mailto:mar...@pr...]
> Sent: Saturday, July 21, 2012 11:30 AM
> To: Chris Mair
> Cc: cod...@li...
> Subject: Re: [Codenarc-developer] My views on making it easier for people
> to
> contribute
>
> Chris,
>
> I'm glad to hear that you like my ideas. Here are the two feature requests
> on Sourceforge tracker:
>
> https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati
> d=1126575
>
> https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati
> d=1126575
>
> When it comes to the site plugin I'm currently waiting for a response from
> Rene Gröschke on the status of the plugin
> (https://github.com/breskeby/GradleSite). After having a quick peek at it
> I
> believe it is finished. It's not in central but I could put it there cause
> I
> have rights to 'org.gradle.api.plugins' group in Sonatype OSS repo.
>
> I can start working on the build migration as soon as we'll put the code
> into github - I will create a fork of it and submit a pull request when
> it's
> ready. I can also help in migrating the source to github, I've migrated
> some
> repos in the past from svn to github using git-svn and could pull the
> source
> into the new repo given that I will get commit access to CodeNarc's github
> repository - I won't mind if you revoke it after the migration is done.
>
> Cheers,
> Marcin
>
> On 07/21/2012 02:35 PM, Chris Mair wrote:
> > Marcin,
> >
> > Thank you for the feedback (and the CodeNarc contributions).
> >
> > I am open to both ideas. Can you please open a feature request for
> > each suggestion (Git/Github and Gradle):
> > https://sourceforge.net/tracker/?group_id=250145&atid=1126575.
> >
> > Both have been informally suggested before, so it's probably worth
> > getting them to a place where we can consolidate the discussion of the
> > merits and trade-offs, and bring Hamlet into the discussion as well.
> > One of the sticking points with Gradle previously was the lack of a
> > site plugin, since we currently use Maven to generate the CodeNarc web
> > site from APT files, and also generate the APT for the Rules Index
> > page. I have not checked on the status of that lately.
> >
> > Thanks.
> > Chris
> >
> > -----Original Message-----
> > From: Marcin Erdmann [mailto:mar...@pr...]
> > Sent: Thursday, July 19, 2012 7:34 PM
> > To: cod...@li...
> > Subject: [Codenarc-developer] My views on making it easier for people
> > to contribute
> >
> > Hi all,
> >
> > In the past I've contributed several rules and fixes to Codenarc.
> > Recently we've added Codenarc to our project and we found a major bug
> > in UnnecessarySemicolonRule and wanted to fix it. After checking the
> > project state I've found out that it's still quite tedious to
> > contribute for two reasons - svn and maven.
> >
> > If you want to contribute to Codenarc you need to send patches in
> > email, like I did by sending mails to Hamlet in the past. This would
> > be much easier if the project was on github enabling people to submit
> > pull request... I don't know if there is a CI build set up for the
> > project but by putting it on github and hooking it up with buildhive
> > you get CI builds for free, also for pull requests. Can you please
> > explain what are the reasons for such a valuable project to be still
> using
> svn?
> >
> > The other thing is getting the project into your IDE. It would be so
> > much easier if there was a gradle build available for the project -
> > simply typing gradle idea would generate the project for you with all
> > the dependencies in place and no additional settings/tweaks needed. If
> > you're interested I could try to contribute by migrating current maven
> > build to gradle. I'm already in talks with Rene Gröschke about his
> efforts
> in the past in that area.
> >
> > Cheers,
> > Marcin Erdmann
> >
> > ----------------------------------------------------------------------
> > ------
> > --
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond.
> > Discussions will include endpoint security, mobile security and the
> > latest in malware threats.
> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > Codenarc-developer mailing list
> > Cod...@li...
> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> >
> >
>
>

Re: [Codenarc-developer] My views on making it easier for people to contribute

[Chris M. <chr...@ea...>]

Marcin,

I was expecting/hoping that we could treat these as two separate issues. I'm
not sure that I am up for trying to tackle both at the same time. At some
point, I need to do some analysis to figure out the impacts of a migration
from Sourceforge+SVN to GitHub+Git.

I am probably more eager to do the Gradle migration, assuming that it now
supports the features that we need. I am also interested in getting more
experience with Git, but I expect that will be more disruptive.

Is doing one without the other (let's say doing Gradle), still feasible, and
still something you'd want to help with?

Thanks.
Chris
-----Original Message-----
From: Marcin Erdmann [mailto:mar...@pr...] 
Sent: Saturday, July 21, 2012 11:30 AM
To: Chris Mair
Cc: cod...@li...
Subject: Re: [Codenarc-developer] My views on making it easier for people to
contribute

Chris,

I'm glad to hear that you like my ideas. Here are the two feature requests
on Sourceforge tracker:
https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati
d=1126575
https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati
d=1126575

When it comes to the site plugin I'm currently waiting for a response from
Rene Gröschke on the status of the plugin
(https://github.com/breskeby/GradleSite). After having a quick peek at it I
believe it is finished. It's not in central but I could put it there cause I
have rights to 'org.gradle.api.plugins' group in Sonatype OSS repo.

I can start working on the build migration as soon as we'll put the code
into github - I will create a fork of it and submit a pull request when it's
ready. I can also help in migrating the source to github, I've migrated some
repos in the past from svn to github using git-svn and could pull the source
into the new repo given that I will get commit access to CodeNarc's github
repository - I won't mind if you revoke it after the migration is done.

Cheers,
Marcin

On 07/21/2012 02:35 PM, Chris Mair wrote:
> Marcin,
>
> Thank you for the feedback (and the CodeNarc contributions).
>
> I am open to both ideas. Can you please open a feature request for 
> each suggestion (Git/Github and Gradle):
> https://sourceforge.net/tracker/?group_id=250145&atid=1126575.
>
> Both have been informally suggested before, so it's probably worth 
> getting them to a place where we can consolidate the discussion of the 
> merits and trade-offs, and bring Hamlet into the discussion as well. 
> One of the sticking points with Gradle previously was the lack of a 
> site plugin, since we currently use Maven to generate the CodeNarc web 
> site from APT files, and also generate the APT for the Rules Index 
> page. I have not checked on the status of that lately.
>
> Thanks.
> Chris
>
> -----Original Message-----
> From: Marcin Erdmann [mailto:mar...@pr...]
> Sent: Thursday, July 19, 2012 7:34 PM
> To: cod...@li...
> Subject: [Codenarc-developer] My views on making it easier for people 
> to contribute
>
> Hi all,
>
> In the past I've contributed several rules and fixes to Codenarc.
> Recently we've added Codenarc to our project and we found a major bug 
> in UnnecessarySemicolonRule and wanted to fix it. After checking the 
> project state I've found out that it's still quite tedious to 
> contribute for two reasons - svn and maven.
>
> If you want to contribute to Codenarc you need to send patches in 
> email, like I did by sending mails to Hamlet in the past. This would 
> be much easier if the project was on github enabling people to submit 
> pull request... I don't know if there is a CI build set up for the 
> project but by putting it on github and hooking it up with buildhive 
> you get CI builds for free, also for pull requests. Can you please 
> explain what are the reasons for such a valuable project to be still using
svn?
>
> The other thing is getting the project into your IDE. It would be so 
> much easier if there was a gradle build available for the project - 
> simply typing gradle idea would generate the project for you with all 
> the dependencies in place and no additional settings/tweaks needed. If 
> you're interested I could try to contribute by migrating current maven 
> build to gradle. I'm already in talks with Rene Gröschke about his efforts
in the past in that area.
>
> Cheers,
> Marcin Erdmann
>
> ----------------------------------------------------------------------
> ------
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. 
> Discussions will include endpoint security, mobile security and the 
> latest in malware threats. 
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
>

Re: [Codenarc-developer] My views on making it easier for people to contribute

[Marcin E. <mar...@pr...>]

Chris,

I'm glad to hear that you like my ideas. Here are the two feature 
requests on Sourceforge tracker:
https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&atid=1126575
https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&atid=1126575

When it comes to the site plugin I'm currently waiting for a response 
from Rene Gröschke on the status of the plugin 
(https://github.com/breskeby/GradleSite). After having a quick peek at 
it I believe it is finished. It's not in central but I could put it 
there cause I have rights to 'org.gradle.api.plugins' group in Sonatype 
OSS repo.

I can start working on the build migration as soon as we'll put the code 
into github - I will create a fork of it and submit a pull request when 
it's ready. I can also help in migrating the source to github, I've 
migrated some repos in the past from svn to github using git-svn and 
could pull the source into the new repo given that I will get commit 
access to CodeNarc's github repository - I won't mind if you revoke it 
after the migration is done.

Cheers,
Marcin

On 07/21/2012 02:35 PM, Chris Mair wrote:
> Marcin,
>
> Thank you for the feedback (and the CodeNarc contributions).
>
> I am open to both ideas. Can you please open a feature request for each
> suggestion (Git/Github and Gradle):
> https://sourceforge.net/tracker/?group_id=250145&atid=1126575.
>
> Both have been informally suggested before, so it's probably worth getting
> them to a place where we can consolidate the discussion of the merits and
> trade-offs, and bring Hamlet into the discussion as well. One of the
> sticking points with Gradle previously was the lack of a site plugin, since
> we currently use Maven to generate the CodeNarc web site from APT files, and
> also generate the APT for the Rules Index page. I have not checked on the
> status of that lately.
>
> Thanks.
> Chris
>
> -----Original Message-----
> From: Marcin Erdmann [mailto:mar...@pr...]
> Sent: Thursday, July 19, 2012 7:34 PM
> To: cod...@li...
> Subject: [Codenarc-developer] My views on making it easier for people to
> contribute
>
> Hi all,
>
> In the past I've contributed several rules and fixes to Codenarc.
> Recently we've added Codenarc to our project and we found a major bug in
> UnnecessarySemicolonRule and wanted to fix it. After checking the project
> state I've found out that it's still quite tedious to contribute for two
> reasons - svn and maven.
>
> If you want to contribute to Codenarc you need to send patches in email,
> like I did by sending mails to Hamlet in the past. This would be much easier
> if the project was on github enabling people to submit pull request... I
> don't know if there is a CI build set up for the project but by putting it
> on github and hooking it up with buildhive you get CI builds for free, also
> for pull requests. Can you please explain what are the reasons for such a
> valuable project to be still using svn?
>
> The other thing is getting the project into your IDE. It would be so much
> easier if there was a gradle build available for the project - simply typing
> gradle idea would generate the project for you with all the dependencies in
> place and no additional settings/tweaks needed. If you're interested I could
> try to contribute by migrating current maven build to gradle. I'm already in
> talks with Rene Gröschke about his efforts in the past in that area.
>
> Cheers,
> Marcin Erdmann
>
> ----------------------------------------------------------------------------
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
>

Re: [Codenarc-developer] My views on making it easier for people to contribute

[Chris M. <chr...@ea...>]

Marcin,

Thank you for the feedback (and the CodeNarc contributions). 

I am open to both ideas. Can you please open a feature request for each
suggestion (Git/Github and Gradle):
https://sourceforge.net/tracker/?group_id=250145&atid=1126575. 

Both have been informally suggested before, so it's probably worth getting
them to a place where we can consolidate the discussion of the merits and
trade-offs, and bring Hamlet into the discussion as well. One of the
sticking points with Gradle previously was the lack of a site plugin, since
we currently use Maven to generate the CodeNarc web site from APT files, and
also generate the APT for the Rules Index page. I have not checked on the
status of that lately.

Thanks.
Chris

-----Original Message-----
From: Marcin Erdmann [mailto:mar...@pr...] 
Sent: Thursday, July 19, 2012 7:34 PM
To: cod...@li...
Subject: [Codenarc-developer] My views on making it easier for people to
contribute

Hi all,

In the past I've contributed several rules and fixes to Codenarc. 
Recently we've added Codenarc to our project and we found a major bug in
UnnecessarySemicolonRule and wanted to fix it. After checking the project
state I've found out that it's still quite tedious to contribute for two
reasons - svn and maven.

If you want to contribute to Codenarc you need to send patches in email,
like I did by sending mails to Hamlet in the past. This would be much easier
if the project was on github enabling people to submit pull request... I
don't know if there is a CI build set up for the project but by putting it
on github and hooking it up with buildhive you get CI builds for free, also
for pull requests. Can you please explain what are the reasons for such a
valuable project to be still using svn?

The other thing is getting the project into your IDE. It would be so much
easier if there was a gradle build available for the project - simply typing
gradle idea would generate the project for you with all the dependencies in
place and no additional settings/tweaks needed. If you're interested I could
try to contribute by migrating current maven build to gradle. I'm already in
talks with Rene Gröschke about his efforts in the past in that area.

Cheers,
Marcin Erdmann

----------------------------------------------------------------------------
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat
landscape has changed and how IT managers can respond. Discussions will
include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Codenarc-developer mailing list
Cod...@li...
https://lists.sourceforge.net/lists/listinfo/codenarc-developer

[Codenarc-developer] My views on making it easier for people to contribute

[Marcin E. <mar...@pr...>]

Hi all,

In the past I've contributed several rules and fixes to Codenarc. 
Recently we've added Codenarc to our project and we found a major bug in 
UnnecessarySemicolonRule and wanted to fix it. After checking the 
project state I've found out that it's still quite tedious to contribute 
for two reasons - svn and maven.

If you want to contribute to Codenarc you need to send patches in email, 
like I did by sending mails to Hamlet in the past. This would be much 
easier if the project was on github enabling people to submit pull 
request... I don't know if there is a CI build set up for the project 
but by putting it on github and hooking it up with buildhive you get CI 
builds for free, also for pull requests. Can you please explain what are 
the reasons for such a valuable project to be still using svn?

The other thing is getting the project into your IDE. It would be so 
much easier if there was a gradle build available for the project - 
simply typing gradle idea would generate the project for you with all 
the dependencies in place and no additional settings/tweaks needed. If 
you're interested I could try to contribute by migrating current maven 
build to gradle. I'm already in talks with Rene Gröschke about his 
efforts in the past in that area.

Cheers,
Marcin Erdmann

Re: [Codenarc-developer] Release a CodeNarc test-jar please

[Clay M. <cod...@cl...>]

Either way would work for me.  Just having the one jar might be more
convenient if you can ensure that all the needed infrastructure for
writing tests will be visible. I'm mostly interested in what can be
done quickest so that I can ditch my homemade CodeNarc test-jar.
Thanks,
Clay

On Fri, Mar 30, 2012 at 4:51 AM,  <chr...@we...> wrote:
> Yes, thanks for feedback Clay.
>
> So, should we consider the other option as well -- just including the test classes in the regular jar?
>
> Chris
>
> -----Original Message-----
> From: Hamlet DArcy [mailto:ham...@ca...]
> Sent: Friday, March 30, 2012 1:14 AM
> To: Clay McCoy
> Cc: cod...@li...
> Subject: Re: [Codenarc-developer] Release a CodeNarc test-jar please
>
> This is great news Clay!
>
> I'm so happy to see other people writing rules, especially if you can share them with others.
>
> Chris is our Maven Master, so he will have to do the test-jar release.
>
> As for GitHub...
> In the end it is up to Chris. The only thing I am unhappy about with Sourceforge is the issue tracker. I feel like GitHub has a better issue tracker. But other than that, I don't see a move solving any of our active problems.
>
> So what are the state of your rules? I'd love to know even the names of the rules or any details. In the past with community rules, I have just merged them into CodeNarc itself. I'd definitely find time for this if you sent them over.
>
>
> ----- Original Message -----
>> I'm using CodeNarc on a large Grails app at Netflix.  We have created
>> some of our own rules.  Some of these are specific to us, some may be
>> useful to a broader audience and submitted back to CodeNarc.  It is
>> nice to write and run these rules in our own project as a sandbox.
>> Though this is possible, it is not as easy as it could be.  If I am
>> going to write my own rule, I will also write a test for it.  I'd
>> like
>> to use the infrastructure already in CodeNarc for the test (namely
>> AbstractRuleTestCase).  The problem is that it isn't available to me
>> with the regular jar since it is test code.  To overcome this I got
>> the source, modified the pom to release a test-jar, built locally,
>> and
>> released the test-jar to a local repo.
>> There are several easy ways that the CodeNarc project could make this
>> easier.  Perhaps release a test-jar and deploy it to the same repos
>> as
>> the regular CodeNarc jar.  Here are the minor pom modifications that
>> are needed
>> (http://maven.apache.org/guides/mini/guide-attached-tests.html).
>>  Or even simpler is to just move the test building blocks into the
>> main source.
>> BTW, the CodeNarc project might get more visibility and commits if it
>> were on Github.  Are there any plans for this?  If not would there be
>> an issue with a fan of the project maintaining a mirror on Github?
>> Thanks,
>> Clay
>>
>> ------------------------------------------------------------------------------
>> This SF email is sponsosred by:
>> Try Windows Azure free for 90 days Click Here
>> http://p.sf.net/sfu/sfd2d-msazure
>> _______________________________________________
>> Codenarc-developer mailing list
>> Cod...@li...
>> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer

Re: [Codenarc-developer] Release a CodeNarc test-jar please

[<chr...@we...>]

Yes, thanks for feedback Clay.

So, should we consider the other option as well -- just including the test classes in the regular jar?

Chris

-----Original Message-----
From: Hamlet DArcy [mailto:ham...@ca...] 
Sent: Friday, March 30, 2012 1:14 AM
To: Clay McCoy
Cc: cod...@li...
Subject: Re: [Codenarc-developer] Release a CodeNarc test-jar please

This is great news Clay! 

I'm so happy to see other people writing rules, especially if you can share them with others. 

Chris is our Maven Master, so he will have to do the test-jar release. 

As for GitHub... 
In the end it is up to Chris. The only thing I am unhappy about with Sourceforge is the issue tracker. I feel like GitHub has a better issue tracker. But other than that, I don't see a move solving any of our active problems. 

So what are the state of your rules? I'd love to know even the names of the rules or any details. In the past with community rules, I have just merged them into CodeNarc itself. I'd definitely find time for this if you sent them over. 
 

----- Original Message -----
> I'm using CodeNarc on a large Grails app at Netflix.  We have created
> some of our own rules.  Some of these are specific to us, some may be
> useful to a broader audience and submitted back to CodeNarc.  It is
> nice to write and run these rules in our own project as a sandbox.
> Though this is possible, it is not as easy as it could be.  If I am
> going to write my own rule, I will also write a test for it.  I'd
> like
> to use the infrastructure already in CodeNarc for the test (namely
> AbstractRuleTestCase).  The problem is that it isn't available to me
> with the regular jar since it is test code.  To overcome this I got
> the source, modified the pom to release a test-jar, built locally,
> and
> released the test-jar to a local repo.
> There are several easy ways that the CodeNarc project could make this
> easier.  Perhaps release a test-jar and deploy it to the same repos
> as
> the regular CodeNarc jar.  Here are the minor pom modifications that
> are needed
> (http://maven.apache.org/guides/mini/guide-attached-tests.html).
>  Or even simpler is to just move the test building blocks into the
> main source.
> BTW, the CodeNarc project might get more visibility and commits if it
> were on Github.  Are there any plans for this?  If not would there be
> an issue with a fan of the project maintaining a mirror on Github?
> Thanks,
> Clay
> 
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> 

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Codenarc-developer mailing list
Cod...@li...
https://lists.sourceforge.net/lists/listinfo/codenarc-developer

Re: [Codenarc-developer] Release a CodeNarc test-jar please

[Hamlet D. <ham...@ca...>]

This is great news Clay! 

I'm so happy to see other people writing rules, especially if you can share them with others. 

Chris is our Maven Master, so he will have to do the test-jar release. 

As for GitHub... 
In the end it is up to Chris. The only thing I am unhappy about with Sourceforge is the issue tracker. I feel like GitHub has a better issue tracker. But other than that, I don't see a move solving any of our active problems. 

So what are the state of your rules? I'd love to know even the names of the rules or any details. In the past with community rules, I have just merged them into CodeNarc itself. I'd definitely find time for this if you sent them over. 
 

----- Original Message -----
> I'm using CodeNarc on a large Grails app at Netflix.  We have created
> some of our own rules.  Some of these are specific to us, some may be
> useful to a broader audience and submitted back to CodeNarc.  It is
> nice to write and run these rules in our own project as a sandbox.
> Though this is possible, it is not as easy as it could be.  If I am
> going to write my own rule, I will also write a test for it.  I'd
> like
> to use the infrastructure already in CodeNarc for the test (namely
> AbstractRuleTestCase).  The problem is that it isn't available to me
> with the regular jar since it is test code.  To overcome this I got
> the source, modified the pom to release a test-jar, built locally,
> and
> released the test-jar to a local repo.
> There are several easy ways that the CodeNarc project could make this
> easier.  Perhaps release a test-jar and deploy it to the same repos
> as
> the regular CodeNarc jar.  Here are the minor pom modifications that
> are needed
> (http://maven.apache.org/guides/mini/guide-attached-tests.html).
>  Or even simpler is to just move the test building blocks into the
> main source.
> BTW, the CodeNarc project might get more visibility and commits if it
> were on Github.  Are there any plans for this?  If not would there be
> an issue with a fan of the project maintaining a mirror on Github?
> Thanks,
> Clay
> 
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> 

[Codenarc-developer] Release a CodeNarc test-jar please

[Clay M. <cod...@cl...>]

I'm using CodeNarc on a large Grails app at Netflix.  We have created
some of our own rules.  Some of these are specific to us, some may be
useful to a broader audience and submitted back to CodeNarc.  It is
nice to write and run these rules in our own project as a sandbox.
Though this is possible, it is not as easy as it could be.  If I am
going to write my own rule, I will also write a test for it.  I'd like
to use the infrastructure already in CodeNarc for the test (namely
AbstractRuleTestCase).  The problem is that it isn't available to me
with the regular jar since it is test code.  To overcome this I got
the source, modified the pom to release a test-jar, built locally, and
released the test-jar to a local repo.
There are several easy ways that the CodeNarc project could make this
easier.  Perhaps release a test-jar and deploy it to the same repos as
the regular CodeNarc jar.  Here are the minor pom modifications that
are needed (http://maven.apache.org/guides/mini/guide-attached-tests.html).
 Or even simpler is to just move the test building blocks into the
main source.
BTW, the CodeNarc project might get more visibility and commits if it
were on Github.  Are there any plans for this?  If not would there be
an issue with a fan of the project maintaining a mirror on Github?
Thanks,
Clay

[Codenarc-developer] Preparing CodeNarc Maven Plugin version 0.17-1.0.0 Release

[LeClaire G. <gar...@gm...>]

I am preparing for a release of version 0.17-1.0.0 of the CodeNarc Maven Plugin.

Documentation for the CodeNarc Maven Plugin can be found at  http://mojo.codehaus.org/codenarc-maven-plugin/index.html

Please give the SNAPSHOT a test and report any issues.

To get this update, simply specify the version in your project's plugin configuration: 

<plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>codenarc-maven-plugin</artifactId>
        <version>0.17-1.0.0-SNAPSHOT</version>
</plugin>


Release Notes - Mojo - Version codenarc-maven-plugin-0.17-1.0.0



** Bug
    * [MOJO-1814] - Fix relative link to 'sample report' on main page
    * [MOJO-1815] - codenarc-maven-plugin xml file (CodeNarc.xml) contains a package element with path attribute with no value.


** Improvement
    * [MOJO-1822] - Update to CodeNarc 0.17
    * [MOJO-1823] - Update version to a format following CodeNarc versions
    * [MOJO-1824] - Add CodeNarc version info to Site Introduction page


	

Regards,

Garvin LeClaire
gar...@gm...

[Codenarc-developer] Finalizing CodeNarc 0.17 release

[Chris M. <chr...@ea...>]

Just a heads up that I am wrapping up the CodeNarc 0.17 release contents. I
plan on working on the release within the next several days.

 

Chris

[Codenarc-developer] Timeline and scope for CodeNarc 0.17

[Chris M. <chr...@ea...>]

Hey Hamlet,

 

Did you have any opinions or goals about the scope or timeline for the next
CodeNarc release (0.17)?

 

I am still planning to implement a few more rules, but I may wrap that up
within a few weeks.

 

Chris

Re: [Codenarc-developer] UnnecessaryNullCheckBeforeInstanceOf - false negative?

[Hamlet D. <ham...@ca...>]

Hi Chris, 

I think your fix is the correct solution. 

This should be a violation: 

if (x != null && x instanceof MyClass && x.isValid()) { } 





----- Original Message -----
> 
> 
> 
> 
> Hamlet,
> 
> 
> 
> Out in the real world, I ran into what seemed like a false negative
> for UnnecessaryNullCheckBeforeInstanceOf .
> 
> 
> 
> The rule produced no violation for this code, though I would have
> expected one:
> 
> 
> 
> boolean equals(Object object) {
> 
> object != null && object instanceof RequestKey
> 
> }
> 
> 
> 
> I added a failing test, and could “fix” the rule by overriding
> visitBinaryExpression () instead of visitBooleanExpression ().
> 
> 
> 
> But now that causes a violation for the highlighted line, failing the
> test:
> 
> 
> 
> void testSuccessScenario() {
> 
> final SOURCE = '''
> 
> if (x instanceof MyClass) { }
> 
> if (x instanceof MyClass) { } else if (x instanceof OtherClass) {}
> 
> (x instanceof MyClass) ? foo : bar
> 
> if (x != null && x instanceof MyClass && x.isValid()) { } //
> violation
> 
> if (x != null && y instanceof MyClass) { } // different references
> 
> '''
> 
> assertNoViolations(SOURCE)
> 
> }
> 
> 
> 
> Is there a reason that line should not cause a violation?
> 
> 
> 
> Thanks.
> 
> Chris
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft
> developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3,
> MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> 

[Codenarc-developer] UnnecessaryNullCheckBeforeInstanceOf - false negative?

[Chris M. <chr...@ea...>]

Hamlet,

 

Out in the real world, I ran into what seemed like a false negative for
UnnecessaryNullCheckBeforeInstanceOf.

 

The rule produced no violation for this code, though I would have expected
one:

 

            boolean equals(Object object) {

                object != null && object instanceof RequestKey

            }

 

I added a failing test, and could "fix" the rule by overriding
visitBinaryExpression() instead of visitBooleanExpression().

 

But now that causes a violation for the highlighted line, failing the test:

 

    void testSuccessScenario() {

        final SOURCE = '''

            if (x instanceof MyClass) { }

            if (x instanceof MyClass) { } else if (x instanceof OtherClass)
{}

            (x instanceof MyClass) ? foo : bar

            if (x != null && x instanceof MyClass && x.isValid()) { }     //
violation

            if (x != null && y instanceof MyClass) { } // different
references

        '''

        assertNoViolations(SOURCE)

    }

 

Is there a reason that line should not cause a violation? 

 

Thanks.

Chris

Re: [Codenarc-developer] PMD Integration ?

[Romain P. <be...@gm...>]

On 27 January 2012 11:50, Hamlet DArcy <ham...@ca...> wrote:

> So is there a generic AST API that PMD will provide and we need to adapt
> CodeNarc to that?


Now, on our side, I just want to grab your groovy AST and add it to PMD, so
that PMD can support Groovy out of the box.


> One thing I really like about PMD is the XQuery syntax for rules. I have
> wanted to port that to CodeNarc but maybe what we need to do instead is
> port CodeNarc to PMD.
>

Well, it depends what you want to do. If you are thinking that PMD features
in terms of integration (Maven, Ant, Eclipse) and rules processing are good
enough for you, you may want to simply use add Groovy support to PMD, and
renaming the resulting product Codenarc. (ie clearly reducing the code
based you have to take care of).



> If there is a generic API then please send a link. I'd like to read it.
> There are many things that are possible in Java that are not possible in
> Groovy because there is no type information. How did ECMAScript handle that?
>

Well, the sad thing is that most of the work was done by Ryan Gustavson a
while back (2010/2011) and that he has stop working on it (he got a baby
which serioulsy dommaged his coding time :) ), so I cannot tell you about
such detail. I can just tail, we do have a somewhat working support for
ECMAScript.

Please, fell free to poke around PMD code (I'll do so for Codenarc's one ;)
) and ask us question if you are suprised.

-- 
Romain PELISSE,
*"The trouble with having an open mind, of course, is that people will
insist on coming along and trying to put things in it" -- Terry Pratchett*
http://belaran.eu/wordpress/belaran

Re: [Codenarc-developer] PMD Integration ?

[Hamlet D. <ham...@ca...>]

So is there a generic AST API that PMD will provide and we need to adapt CodeNarc to that? 

One thing I really like about PMD is the XQuery syntax for rules. I have wanted to port that to CodeNarc but maybe what we need to do instead is port CodeNarc to PMD. 

If there is a generic API then please send a link. I'd like to read it. There are many things that are possible in Java that are not possible in Groovy because there is no type information. How did ECMAScript handle that? 



----- Original Message -----
> 
> Hi,
> 
> 
> First of all, sorry for sending such a short email - I was exhausted
> yesterday and I should have known better :)
> 
> 
> Well, first state of art on PMD. Basically PMD has been modified (by
> Ryan Gustavson) to process and execute rules on top of AST in a more
> abstract manner. Before then, PMD was deeply tied to the AST
> provided, and now you can simply "plug" an AST, do a little plumbing
> and "voilà", PMD can now support rules for a new language.
> 
> 
> It's of course not as easy as that, but we already managed to do it
> for EcmaScript (Javascript) and XML - and therefore all XML based
> languages, such as XSL.
> 
> 
> My plan will be to support other JVM based languages, such as Groovy,
> Scala and Ceylon, as they all come with AST. In a second time, we
> might dwelve into adding support of non Java based languages, if
> there is an easy way to do it.
> 
> 
> What I'm fishing for in this email is find a way to work closely with
> Codenarc's developer on the Groovy integration, because I assume (I
> may be wrong) that we could easily reuse in PMD whatever you've been
> doing to generate a AST from a Groovy file.
> 
> 
> Now, I utterly aplogized, because I didn't do my homework before
> sending this email (ie I didn't look at the souce code of Codenarc),
> so I would completly understand if you were to say to me "Just look
> at the code, moron !" :)
> 
> 
> 
> On 26 January 2012 17:22, Hamlet D'Arcy < ham...@gm... >
> wrote:
> 
> 
> 
> 
> Rules are implemented as ast transformations, but the groovy compiler
> is quite different from java's. What does it mean for a language to
> be integrated? What is your vision?
> 
> --
> Hamlet D'Arcy
> ham...@gm...
> 
> 
> 
> 
> On Jan 26, 2012 4:35 PM, "Romain Pelisse" < be...@gm... >
> wrote:
> 
> 
> 
> 
> 
> Hi Codenarc Developer,
> 
> 
> After a year of hiatus, I'm happy to announce that development and
> PMD has resume and that we will release, soon, a PMD 5.0 which allow
> to add other language (than Java). In this regards, when I stumbled
> upon Codenarc, I wondered how close you are to PMD. The ruleset
> structure and organizationn does feel quite familiar :) , but how
> did you implemented the rule ? Using an AST lilke PMD ?
> 
> 
> It could make sense that we work together, on way or the other -
> hopefully reducing the amount of work on both project...
> 
> 
> 
> 
> 
> 
> --
> Romain PELISSE,
> "The trouble with having an open mind, of course, is that people will
> insist on coming along and trying to put things in it" -- Terry
> Pratchett
> http://belaran.eu/wordpress/belaran
> 
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft
> developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3,
> MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> 
> 
> 
> 
> 
> 
> 
> --
> Romain PELISSE,
> "The trouble with having an open mind, of course, is that people will
> insist on coming along and trying to put things in it" -- Terry
> Pratchett
> http://belaran.eu/wordpress/belaran
> 
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft
> developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3,
> MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
> 

Re: [Codenarc-developer] PMD Integration ?

[Romain P. <be...@gm...>]

Hi,

First of all, sorry for sending such a short email - I was exhausted
yesterday and I should have known better :)

Well, first state of art on PMD. Basically PMD has been modified (by Ryan
Gustavson) to process and execute rules on top of AST in a more abstract
manner. Before then, PMD was deeply tied to the AST provided, and now you
can simply "plug" an AST, do a little plumbing and "voilà", PMD can now
support rules for a new language.

It's of course not as easy as that, but we already managed to do it for
EcmaScript (Javascript) and XML - and therefore all XML based languages,
such as XSL.

My plan will be to support other JVM based languages, such as Groovy, Scala
and Ceylon, as they all come with AST. In a second time, we might dwelve
into adding support of non Java based languages, if there is an easy way to
do it.

What I'm fishing for in this email is find a way to work closely with
Codenarc's developer on the Groovy integration, because I assume (I may be
wrong) that we could easily reuse in PMD whatever you've been doing to
generate a AST from a Groovy file.

Now, I utterly aplogized, because I didn't do my homework before sending
this email (ie I didn't look at the souce code of Codenarc), so I would
completly understand if you were to say to me "Just look at the code, moron
!" :)

On 26 January 2012 17:22, Hamlet D'Arcy <ham...@gm...> wrote:

> Rules are implemented as ast transformations, but the groovy compiler is
> quite different from java's. What does it mean for a language to be
> integrated? What is your vision?
>
> --
> Hamlet D'Arcy
> ham...@gm...
>
> On Jan 26, 2012 4:35 PM, "Romain Pelisse" <be...@gm...> wrote:
>
>>  Hi Codenarc Developer,
>>
>> After a year of hiatus, I'm happy to announce that development and PMD
>> has resume and that we will release, soon, a PMD 5.0 which allow to add
>> other language (than Java). In this regards, when I stumbled upon Codenarc,
>> I wondered how close you are to PMD. The ruleset structure and
>> organizationn does feel quite familiar :) , but how did you implemented the
>> rule ? Using an AST lilke PMD ?
>>
>> It could make sense that we work together, on way or the other -
>> hopefully reducing the amount of work on both project...
>>
>>
>>
>> --
>> Romain PELISSE,
>> *"The trouble with having an open mind, of course, is that people will
>> insist on coming along and trying to put things in it" -- Terry Pratchett
>> *
>> http://belaran.eu/wordpress/belaran
>>
>>
>> ------------------------------------------------------------------------------
>> Keep Your Developer Skills Current with LearnDevNow!
>> The most comprehensive online learning library for Microsoft developers
>> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
>> Metro Style Apps, more. Free future releases when you subscribe now!
>> http://p.sf.net/sfu/learndevnow-d2d
>> _______________________________________________
>> Codenarc-developer mailing list
>> Cod...@li...
>> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>>
>>


-- 
Romain PELISSE,
*"The trouble with having an open mind, of course, is that people will
insist on coming along and trying to put things in it" -- Terry Pratchett*
http://belaran.eu/wordpress/belaran

Re: [Codenarc-developer] PMD Integration ?

[Hamlet D'A. <ham...@gm...>]

Rules are implemented as ast transformations, but the groovy compiler is
quite different from java's. What does it mean for a language to be
integrated? What is your vision?

--
Hamlet D'Arcy
ham...@gm...

On Jan 26, 2012 4:35 PM, "Romain Pelisse" <be...@gm...> wrote:

> Hi Codenarc Developer,
>
> After a year of hiatus, I'm happy to announce that development and PMD has
> resume and that we will release, soon, a PMD 5.0 which allow to add other
> language (than Java). In this regards, when I stumbled upon Codenarc, I
> wondered how close you are to PMD. The ruleset structure and organizationn
> does feel quite familiar :) , but how did you implemented the rule ? Using
> an AST lilke PMD ?
>
> It could make sense that we work together, on way or the other - hopefully
> reducing the amount of work on both project...
>
>
>
> --
> Romain PELISSE,
> *"The trouble with having an open mind, of course, is that people will
> insist on coming along and trying to put things in it" -- Terry Pratchett*
> http://belaran.eu/wordpress/belaran
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
>

[Codenarc-developer] PMD Integration ?

[Romain P. <be...@gm...>]

Hi Codenarc Developer,

After a year of hiatus, I'm happy to announce that development and PMD has
resume and that we will release, soon, a PMD 5.0 which allow to add other
language (than Java). In this regards, when I stumbled upon Codenarc, I
wondered how close you are to PMD. The ruleset structure and organizationn
does feel quite familiar :) , but how did you implemented the rule ? Using
an AST lilke PMD ?

It could make sense that we work together, on way or the other - hopefully
reducing the amount of work on both project...



-- 
Romain PELISSE,
*"The trouble with having an open mind, of course, is that people will
insist on coming along and trying to put things in it" -- Terry Pratchett*
http://belaran.eu/wordpress/belaran

Re: [Codenarc-developer] Can GetterMethodCouldBeProperty be extended to check static getter methods as well?

[Hamlet D'A. <ham...@gm...>]

Looks good to me!

--
Hamlet D'Arcy
ham...@gm...

On Jan 20, 2012 3:02 AM, "Chris Mair" <chr...@ea...> wrote:

> If a class defines a static getter method to return a constant, that could
> be replaced with a static property.****
>
> e.g.****
>
>                 static String getName() {****
>
>                                 ‘abc’****
>
>                 }****
>
> Could be replaced by:****
>
>                 static (final) name = ‘abc’****
>
> ** **
>
> So, I am inclined to extend *GetterMethodCouldBeProperty*  to check for
> static getter methods as well.****
>
> ** **
>
>
> http://codenarc.sourceforge.net/codenarc-rules-groovyism.html#GetterMethodCouldBeProperty
> ****
>
> ** **
>
> Any objection?****
>
> ** **
>
> Chris****
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
>

[Codenarc-developer] Can GetterMethodCouldBeProperty be extended to check static getter methods as well?

[Chris M. <chr...@ea...>]

If a class defines a static getter method to return a constant, that could
be replaced with a static property.

e.g.

                static String getName() {

                                'abc'

                }

Could be replaced by:

                static (final) name = 'abc'

 

So, I am inclined to extend GetterMethodCouldBeProperty  to check for static
getter methods as well.

 

http://codenarc.sourceforge.net/codenarc-rules-groovyism.html#GetterMethodCo
uldBeProperty

 

Any objection?

 

Chris

Re: [Codenarc-developer] #3436461 - StackOverflowErrors with CodeNarc 0.16 - workaround?

[Hamlet D'A. <ham...@gm...>]

Sounds perfect. Please go forward with that.

--
Hamlet D'Arcy
ham...@gm...

On Nov 13, 2011 2:59 AM, "Chris Mair" <chr...@ea...> wrote:

> Hamlet,****
>
> ** **
>
> I guess the major performance reorganization/rewrite of the code that we
> did for 0.16 exposed the same or similar Groovy 1.8 issue (
> http://jira.codehaus.org/browse/GROOVY-4922) that you fixed (with a
> workaround) for
> https://sourceforge.net/tracker/?func=detail&aid=3314839&group_id=250145&atid=1126573in CodeNarc 0.15.
> ****
>
> ** **
>
> The good news is that I could reproduce pretty easily by running with
> Groovy 1.8.****
>
> ** **
>
> And perhaps more good news, after some experimentation, and researching
> your previous workaround, it looks like we can fix/workaround by changing
> *AbstractAstVisitor* to use your *ClassCodeVisitorSupportHack*, so:****
>
> ** **
>
>     public class AbstractAstVisitor extends ClassCodeVisitorSupport
> implements AstVisitor { ****
>
> ** **
>
> becomes:****
>
> ** **
>
>     public class AbstractAstVisitor extends *ClassCodeVisitorSupportHack*implements AstVisitor {
> ****
>
> ** **
>
> That seems to have little or no performance impact (at least in my
> unscientific tests). Are you ok with that workaround? Or did you want to
> research more?****
>
> ** **
>
> Chris****
>
> -----Original Message-----
> From: SourceForge.net [mailto:no...@so...]
> Sent: Friday, November 11, 2011 9:51 PM
> To: SourceForge.net
> Subject: [ codenarc-Bugs-3436461 ] StackOverflowErrors with CodeNarc 0.16
>
> ** **
>
> Bugs item #3436461, was opened at 2011-11-11 00:27****
>
> Message generated for change (Comment added) made by chrismair****
>
> You can respond by visiting: ****
>
>
> https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3436461&group_id=250145
> ****
>
> ** **
>
> Please note that this message will contain a full copy of the comment
> thread,****
>
> including the initial issue submission, for this request,****
>
> not just the latest update.****
>
> Category: None****
>
> Group: None****
>
> Status: Open****
>
> Resolution: None****
>
> Priority: 5****
>
> Private: No****
>
> Submitted By: https://www.google.com/accounts ()****
>
> Assigned to: Nobody/Anonymous (nobody)****
>
> Summary: StackOverflowErrors with CodeNarc 0.16****
>
> ** **
>
> Initial Comment:****
>
> After upgrading to 0.16, nearly all files we throw at CodeNarc cause it to
> run into an endless recursion like this one. About 4/5 times the causing
> Rule is ImplementationAsTypeRule, but they also happen in
> UnusedPrivateMethodRule and UnnecessaryPackageReferenceRule.****
>
> ** **
>
> One Stacktrace of the hundreds follows, let me know if you need more
> information. ****
>
> ** **
>
> [codenarc] Error from [org.codenarc.rule.design.ImplementationAsTypeRule]
> processing source file
> [/Users/cnr/Documents/dev/lusini/ofbiz/hot-deploy/api/src/main/com/lusini/api/authorization/Action.groovy]
> ****
>
> [codenarc] java.lang.StackOverflowError****
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.getNormalMethodWithCaching(MetaClassImpl.java:1216)
> ****
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.getMethodWithCaching(MetaClassImpl.java:1132)***
> *
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:903)****
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:885)****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.InvokerHelper.invokePojoMethod(InvokerHelper.java:781)
> ****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:772)
> ****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToBoolean(DefaultTypeTransformation.java:156)
> ****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.booleanUnbox(DefaultTypeTransformation.java:65)
> ****
>
> [codenarc]         at
> org.codenarc.rule.design.ImplementationAsTypeAstVisitor.visitDeclarationExpression(ImplementationAsTypeRule.groovy:109)
> ****
>
> [codenarc]         at
> sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)****
>
> [codenarc]         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> ****
>
> [codenarc]         at java.lang.reflect.Method.invoke(Method.java:597)****
>
> [codenarc]         at
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)**
> **
>
> [codenarc]         at
> groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)****
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1055)****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:128)
> ****
>
> [codenarc]         at
> org.codenarc.rule.design.ImplementationAsTypeAstVisitor.visitDeclarationExpression(ImplementationAsTypeRule.groovy:116)
> ****
>
> [codenarc]         at
> sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)****
>
> [codenarc]         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> ****
>
> [codenarc]         at java.lang.reflect.Method.invoke(Method.java:597)****
>
> [codenarc]         at
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)**
> **
>
> [codenarc]         at
> groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)****
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1055)****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:128)
> ****
>
> [codenarc]         at
> org.codenarc.rule.design.ImplementationAsTypeAstVisitor.visitDeclarationExpression(ImplementationAsTypeRule.groovy:116)
> ****
>
> [codenarc]         at
> sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)****
>
> [codenarc]         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> ****
>
> [codenarc]         at java.lang.reflect.Method.invoke(Method.java:597)****
>
> [codenarc]         at
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)**
> **
>
> [codenarc]         at
> groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)****
>
> [codenarc]         at
> groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1055)****
>
> [codenarc]         at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:128)
> ****
>
> ** **
>
> [... removed ...]****
>
> ** **
>
> ----------------------------------------------------------------------****
>
> ** **
>
> >Comment By: Chris Mair (chrismair)****
>
> Date: 2011-11-11 18:51****
>
> ** **
>
> Message:****
>
> I was able to reproduce a similar StackOverflowError running with****
>
> Groovy1.8.2, processing the UnusedPrivateMethodRule, which is one of rules
> ****
>
> mentioned above.****
>
> ** **
>
> As a workaround, running with Groovy 1.7.x should avoid the****
>
> StackOverflowError, until we can figure out a fix.****
>
> ** **
>
> ----------------------------------------------------------------------****
>
> ** **
>
> Comment By: Chris Mair (chrismair)****
>
> Date: 2011-11-11 06:09****
>
> ** **
>
> Message:****
>
> Can you please provide the version of the Java JDK are you running this***
> *
>
> with, and what version of Groovy (jar) is on the classpath. Thanks.****
>
> ** **
>
> ----------------------------------------------------------------------****
>
> ** **
>
> You can respond by visiting: ****
>
>
> https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3436461&group_id=250145
> ****
>
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Save $700 by Nov 18
> Register now
> http://p.sf.net/sfu/rsa-sfdev2dev1
> _______________________________________________
> Codenarc-developer mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codenarc-developer
>
>

[Codenarc-developer] #3436461 - StackOverflowErrors with CodeNarc 0.16 - workaround?

[Chris M. <chr...@ea...>]

Hamlet,

 

I guess the major performance reorganization/rewrite of the code that we did for 0.16 exposed the same or similar Groovy 1.8 issue (http://jira.codehaus.org/browse/GROOVY-4922) that you fixed (with a workaround) for https://sourceforge.net/tracker/?func=detail <https://sourceforge.net/tracker/?func=detail&aid=3314839&group_id=250145&atid=1126573> &aid=3314839&group_id=250145&atid=1126573 in CodeNarc 0.15.

 

The good news is that I could reproduce pretty easily by running with Groovy 1.8.

 

And perhaps more good news, after some experimentation, and researching your previous workaround, it looks like we can fix/workaround by changing AbstractAstVisitor to use your ClassCodeVisitorSupportHack, so:

 

    public class AbstractAstVisitor extends ClassCodeVisitorSupport implements AstVisitor { 

 

becomes:

 

    public class AbstractAstVisitor extends ClassCodeVisitorSupportHack implements AstVisitor {

 

That seems to have little or no performance impact (at least in my unscientific tests). Are you ok with that workaround? Or did you want to research more?

 

Chris

-----Original Message-----
From: SourceForge.net [mailto:no...@so...] 
Sent: Friday, November 11, 2011 9:51 PM
To: SourceForge.net
Subject: [ codenarc-Bugs-3436461 ] StackOverflowErrors with CodeNarc 0.16

 

Bugs item #3436461, was opened at 2011-11-11 00:27

Message generated for change (Comment added) made by chrismair

You can respond by visiting: 

 <https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3436461&group_id=250145> https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3436461&group_id=250145

 

Please note that this message will contain a full copy of the comment thread,

including the initial issue submission, for this request,

not just the latest update.

Category: None

Group: None

Status: Open

Resolution: None

Priority: 5

Private: No

Submitted By:  <https://www.google.com/accounts> https://www.google.com/accounts ()

Assigned to: Nobody/Anonymous (nobody)

Summary: StackOverflowErrors with CodeNarc 0.16

 

Initial Comment:

After upgrading to 0.16, nearly all files we throw at CodeNarc cause it to run into an endless recursion like this one. About 4/5 times the causing Rule is ImplementationAsTypeRule, but they also happen in UnusedPrivateMethodRule and UnnecessaryPackageReferenceRule.

 

One Stacktrace of the hundreds follows, let me know if you need more information. 

 

[codenarc] Error from [org.codenarc.rule.design.ImplementationAsTypeRule] processing source file [/Users/cnr/Documents/dev/lusini/ofbiz/hot-deploy/api/src/main/com/lusini/api/authorization/Action.groovy]

[codenarc] java.lang.StackOverflowError

[codenarc]         at groovy.lang.MetaClassImpl.getNormalMethodWithCaching(MetaClassImpl.java:1216)

[codenarc]         at groovy.lang.MetaClassImpl.getMethodWithCaching(MetaClassImpl.java:1132)

[codenarc]         at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:903)

[codenarc]         at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:885)

[codenarc]         at org.codehaus.groovy.runtime.InvokerHelper.invokePojoMethod(InvokerHelper.java:781)

[codenarc]         at org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:772)

[codenarc]         at org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToBoolean(DefaultTypeTransformation.java:156)

[codenarc]         at org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.booleanUnbox(DefaultTypeTransformation.java:65)

[codenarc]         at org.codenarc.rule.design.ImplementationAsTypeAstVisitor.visitDeclarationExpression(ImplementationAsTypeRule.groovy:109)

[codenarc]         at sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)

[codenarc]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

[codenarc]         at java.lang.reflect.Method.invoke(Method.java:597)

[codenarc]         at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)

[codenarc]         at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)

[codenarc]         at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1055)

[codenarc]         at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:128)

[codenarc]         at org.codenarc.rule.design.ImplementationAsTypeAstVisitor.visitDeclarationExpression(ImplementationAsTypeRule.groovy:116)

[codenarc]         at sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)

[codenarc]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

[codenarc]         at java.lang.reflect.Method.invoke(Method.java:597)

[codenarc]         at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)

[codenarc]         at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)

[codenarc]         at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1055)

[codenarc]         at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:128)

[codenarc]         at org.codenarc.rule.design.ImplementationAsTypeAstVisitor.visitDeclarationExpression(ImplementationAsTypeRule.groovy:116)

[codenarc]         at sun.reflect.GeneratedMethodAccessor115.invoke(Unknown Source)

[codenarc]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

[codenarc]         at java.lang.reflect.Method.invoke(Method.java:597)

[codenarc]         at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)

[codenarc]         at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)

[codenarc]         at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1055)

[codenarc]         at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:128)

 

[... removed ...]

 

----------------------------------------------------------------------

 

>Comment By: Chris Mair (chrismair)

Date: 2011-11-11 18:51

 

Message:

I was able to reproduce a similar StackOverflowError running with

Groovy1.8.2, processing the UnusedPrivateMethodRule, which is one of rules

mentioned above.

 

As a workaround, running with Groovy 1.7.x should avoid the

StackOverflowError, until we can figure out a fix.

 

----------------------------------------------------------------------

 

Comment By: Chris Mair (chrismair)

Date: 2011-11-11 06:09

 

Message:

Can you please provide the version of the Java JDK are you running this

with, and what version of Groovy (jar) is on the classpath. Thanks.

 

----------------------------------------------------------------------

 

You can respond by visiting: 

https://sourceforge.net/tracker/?func=detail&atid=1126573&aid=3436461&group_id=250145